Code Cleanup with ruff.

Fixed: Deprecatios for Django 4.0
Changed: path instead of url_path
Added: fiaxateranking command

.coafile

@@ -5,4 +5,4 @@ language = python
 bears = PEP8Bear,PyLintBear,PyUnusedCodeBear
 use_spaces = True
 pylint_cli_options = --load-plugins pylint_django
-pylint_disable = E1101,R0201,R0901,R0903
+#pylint_disable = E1101,R0201,R0901,R0903

.gitignore

@@ -71,3 +71,4 @@ backup/
 .[a-zA-Z]*
 local_settings.py
 sample.xlsx
+venv/

Makefile

@@ -0,0 +1,80 @@
+ASSETS=requirements static
+DEV_REQUIREMENTS=requirements/development.txt
+DJANGO_SETTINGS_MODULE="kasu.settings"
+EXCLUDE_FILES=*.pyc
+PROJECT_PATH=$(CURDIR)
+PYTHON=${VENV_PATH}/bin/python3
+REQUIREMENTS=requirements/base.txt
+SRC_PATH=${PROJECT_PATH}/src
+MANAGE_PY=${PYTHON} -Wa ${SRC_PATH}/manage.py
+SSH_LOGIN=kasu@kasu.at
+VENV_PATH=$(PROJECT_PATH)/venv
+
+.PHONY: clean venv
+
+all: cleanup migrate testserver
+
+venv: $(VENV_PATH)/bin/activate
+$(VENV_PATH)/bin/activate:
+	@test -d $(VENV_PATH) || python3 -m venv --clear --system-site-packages $(VENV_PATH)
+
+dev-requirements: venv ${DEV_REQUIREMENTS}
+	${PYTHON} -m pip install -qU pip
+	${PYTHON} -m pip install -qUr ${DEV_REQUIREMENTS}
+
+requirements: venv ${REQUIREMENTS}
+	${PYTHON} -m pip install -qU pip
+	${PYTHON} -m pip install -qUr ${REQUIREMENTS}
+
+grunt:
+	-grunt
+
+requirements_remote:
+	@echo "Installing requirements"
+	ssh ${SSH_LOGIN} "virtualenv/bin/pip install -qUr ${REQUIREMENTS}"
+
+sync_assets:
+	@echo "Syncing project assets ..."
+	rsync -qr --copy-links --delete ${ASSETS} ${SSH_LOGIN}:~/
+
+sync_src:
+	@echo "Syncing Sourcecode ..."
+	find . -name EXCLUDE_FILES -exec rm -rf {} \;
+	rsync -qr --copy-links --delete ${SRC_PATH} ${SSH_LOGIN}:~/ --exclude 'src/kasu/local_settings.py'
+
+restart_remote:
+	@echo "Rebuild and reload django..."
+	ssh ${SSH_LOGIN} "~/virtualenv/bin/python ~/src/manage.py collectstatic -l --noinput -v0"
+	ssh ${SSH_LOGIN} "~/init/kasu restart"
+
+sync: sync_assets requirements_remote sync_src restart_remote
+
+testserver: venv
+	${MANAGE_PY} runserver 127.0.0.1:8000
+
+messages: venv
+	@echo "aktualisiere Übersetzungen..."
+	@(for d in ${SRC_PATH}/*; do    \
+    test -d $$d/locale && cd $$d && ${VENV_PATH}/bin/django-admin makemessages -l de;\
+	done)
+	${MANAGE_PY} compilemessages -v0
+
+cleanup-pyc:
+	@echo "lösche den Python Compiler Cache..."
+	find ${SRC_PATH} -name ${EXCLUDE_FILES} -exec rm -rf {} \;
+
+collectstatic: venv
+	@echo "aktualisiere Statics"
+	${MANAGE_PY}  collectstatic --noinput -c -v0
+
+thumbnails: venv
+	@echo "Erstelle Vorschaubilder"
+	${MANAGE_PY} thumbnail_cleanup
+
+cleanup: requirements messages cleanup-pyc collectstatic thumbnails
+
+migrate: venv
+	${MANAGE_PY} migrate
+
+migrations: venv
+	${MANAGE_PY} makemigrations

bin/cleanup.sh

@@ -1,26 +0,0 @@
-#!/bin/bash
-source .virtualenv/bin/activate
-echo "aktualisiere Übersetzungen..."
-cd src
-unset DJANGO_SETTINGS_MODULE
-for dir in *
-do
-    if [ -d ${dir}/locale ]
-    then
-        echo -n "$dir: " 
-        cd ${dir}
-        django-admin.py makemessages -l de
-        cd ..
-    fi
-done
-sleep 5s
-export DJANGO_SETTINGS_MODULE="kasu.settings"
-./manage.py compilemessages
-
-echo "lösche den Python Compiler Cache..."
-find . -name "*.pyc" -exec rm -rf {} \;
-echo "Aktualisiere Statics"
-./manage.py collectstatic --noinput -c
-echo "Erstelle Vorschaubilder"
-./manage.py thumbnail_cleanup
-touch kasu/wsgi.py

bin/sync.sh

@@ -1,23 +0,0 @@
-#!/bin/bash
-
-SSH_LOGIN="kasu@s21.wservices.ch"
-SYNC_ASSESTS="requirements static"
-SYNC_SOURCECODE="src"
-EXCLUDE_FILES="*.pyc"
-
-grunt
-
-echo "Syncing project assets ..."
-rsync -r --copy-links --delete ${SYNC_ASSESTS} ${SSH_LOGIN}:~/
-
-echo "Installing dependecies"
-ssh ${SSH_LOGIN} "virtualenv/bin/pip install --upgrade -r requirements/base.txt"
-
-echo "Syncing Sourcecode ..."
-find . -name "*.pyc" -exec rm -rf {} \;
-rsync -r --copy-links --delete ${SYNC_SOURCECODE} ${SSH_LOGIN}:~/ --exclude 'src/kasu/local_settings.py'
-
-echo "Rebuild and reload django..."
-ssh ${SSH_LOGIN} "rm src/kasu/settings/development.*"
-ssh ${SSH_LOGIN} "~/virtualenv/bin/python ~/src/manage.py collectstatic -l --noinput -v1"
-ssh ${SSH_LOGIN} "~/init/kasu restart"

bin/testserver.sh

@@ -1,6 +0,0 @@
-#!/bin/sh
-
-export DJANGO_SETTINGS_MODULE=kasu.settings
-source .virtualenv/bin/activate
-./manage.py runserver 0.0.0.0:8000
-

requirements/base.txt

@@ -1,5 +1,5 @@
 beautifulsoup4
-django < 2.0
+django < 5.0
 django-appconf
 django-ckeditor
 django-contrib-comments
@@ -8,11 +8,12 @@ django-compressor
 django-extra-views
 django-markdown
 django-recaptcha
-easy-thumbnails
+easy_thumbnails[svg]
 icalendar
+openpyxl
 markdown
 pillow
-psycopg2
+psycopg2-binary
 PyJWT
 pytz
 requests

requirements/development.txt

@@ -4,5 +4,5 @@ django-rosetta
 sqlparse
 
 # Code Linting
-coala-bears
+pylint>=2.0
 pylint-django

src/content/context_processors.py

@@ -5,6 +5,7 @@ from django.core.cache import cache
 from . import models
 from utils import STATUS_PUBLISHED
 
+
 def content_menus(request):
     """ Generate the menu tree and add these info to the template context.
 
@@ -18,9 +19,9 @@ def content_menus(request):
     :param request: a Django request object
     :return: a dict with the template variables mentioned above
     """
-    current_page = None
-    current_top_page = None
-    current_path = request.path_info[1:request.path_info.rfind('.')]
+    current_page: models.Page = models.Page.objects.get(slug='index')
+    current_top_page: models.Page = models.Page.objects.get(slug='index')
+    current_path: str = request.path_info[1:request.path_info.rfind('.')]
 
     # erzeuge das Top-Level Menü
     top_level_pages = cache.get('top_level_pages')

src/content/feeds.py

@@ -3,7 +3,7 @@ import django_comments as comments
 from django.conf import settings
 from django.contrib.syndication.views import Feed
 from django.utils.feedgenerator import Rss201rev2Feed
-from django.utils.translation import ugettext as _
+from django.utils.translation import gettext as _
 
 from content.models import Article
 
@@ -11,15 +11,15 @@ MAX_ARTICLE_ITEMS = 10  # Maximum count of articles in the news RSS feed.
 MAX_COMMENT_ITEMS = 40  # Maximum count of comments in the comments RSS feed.
 
 
-# Start ignoring PyLintBear (R0201)
+# noinspection PyMethodMayBeStatic
 class LatestNews(Feed):
     """ An Feed with the latest news from this site  """
-    link = "http://www.kasu.at/"
     description = _("Current news from Kasu")
-    title = "Kasu - traditonelle asiatische Spielkultur"
+    link = "http://www.kasu.at/"
+    title = _("Current news from Kasu")
     feed_type = Rss201rev2Feed
 
-    def items(self):
+    def items(self) -> object:
         """get the newest published news articles for the feed."""
         return Article.objects.published()[:MAX_ARTICLE_ITEMS]
 
@@ -78,5 +78,3 @@ class LatestComments(Feed):
             'user_name': item.user_name,
             'content_object': item.content_object
         }
-
-# Stop ignoring

src/content/forms.py

@@ -5,7 +5,7 @@ Created on 04.10.2011
 """
 from django import forms
 from django.template.defaultfilters import slugify
-from django.utils.translation import ugettext as _
+from django.utils.translation import gettext as _
 
 from . import models
 

src/content/locale/de/LC_MESSAGES/django.po

@@ -8,7 +8,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: kasu.content\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2018-05-08 00:17+0200\n"
+"POT-Creation-Date: 2023-08-07 20:38+0200\n"
 "PO-Revision-Date: 2018-01-12 15:25+0105\n"
 "Last-Translator: b'Christian Berg <kasu@xendynastie.at>'\n"
 "Language-Team: Deutsch <>\n"
@@ -20,252 +20,247 @@ msgstr ""
 "X-Generator: Poedit 1.8.9\n"
 "X-Translated-Using: django-rosetta 0.7.14\n"
 
-#: .\content\feeds.py:18
+#: feeds.py:17 feeds.py:19
 msgid "Current news from Kasu"
 msgstr "Aktuelle Nachrichten von Kasu"
 
-#: .\content\feeds.py:51
+#: feeds.py:51
 msgid "Latest comments on kasu.at"
 msgstr "Neueste Kommentare auf Kasu.at "
 
-#: .\content\feeds.py:52
+#: feeds.py:52
 msgid "Kasu - latest comments"
 msgstr "Kasu - neue Kommentare"
 
-#: .\content\forms.py:57 .\content\models.py:318
+#: forms.py:57 models.py:320
 msgid "Please upload a PDF-File to this PDF-Page."
 msgstr "Bitte eine PDF Datei für diese PDF Seite hochladen."
 
-#: .\content\models.py:76
+#: models.py:76
 msgid "Headline"
 msgstr "Schlagzeile"
 
-#: .\content\models.py:78
+#: models.py:78
 msgid "Content"
 msgstr "Inhalt"
 
-#: .\content\models.py:82 .\content\models.py:150
-#: .\content\templates\content\article_detail.html:25
+#: models.py:82 models.py:151 templates/content/article_detail.html:28
 msgid "Category"
 msgstr "Kategorie"
 
-#: .\content\models.py:83 .\content\models.py:143
+#: models.py:83 models.py:144
 msgid "Image"
 msgstr "Bild"
 
-#: .\content\models.py:85 .\content\models.py:145
+#: models.py:85 models.py:146
 msgid "Slug"
 msgstr "Slug"
 
-#: .\content\models.py:88 .\content\templates\content\article_detail.html:23
+#: models.py:88 templates/content/article_detail.html:21
 msgid "Author"
 msgstr "Autor"
 
-#: .\content\models.py:89
+#: models.py:89
 msgid "Status"
 msgstr "Status"
 
-#: .\content\models.py:91
+#: models.py:91
 msgid "Created"
 msgstr "Erstellt"
 
-#: .\content\models.py:92
+#: models.py:92
 msgid "Modified"
 msgstr "Bearbeitet"
 
-#: .\content\models.py:97
+#: models.py:97
 msgid "Article"
 msgstr "Artikel"
 
-#: .\content\models.py:98
+#: models.py:98
 msgid "Articles"
 msgstr "Artikel"
 
-#: .\content\models.py:139 .\content\models.py:140
+#: models.py:140 models.py:141
 msgid "Name"
 msgstr "Name"
 
-#: .\content\models.py:141 .\content\models.py:142
+#: models.py:142 models.py:143
 msgid "Description"
 msgstr "Beschreibung"
 
-#: .\content\models.py:151
+#: models.py:152
 msgid "Categories"
 msgstr "Kategorien"
 
-#: .\content\models.py:182 .\content\models.py:188
+#: models.py:184 models.py:190
 msgid "The short name for the menu-entry of this page"
 msgstr "Ein kurzer Name für den Menüeintrag"
 
-#: .\content\models.py:193 .\content\models.py:198
+#: models.py:195 models.py:200
 msgid "The page title as you'd like it to be seen by the public"
 msgstr "Der Seitentitel der öffentlich angezeigt werden soll"
 
-#: .\content\models.py:200
+#: models.py:202
 msgid "slug"
 msgstr "Slug"
 
-#: .\content\models.py:203
+#: models.py:205
 msgid ""
 "The name of the page as it will appear in URLs e.g http://domain.com/blog/"
 "[my-slug]/"
 msgstr "Wie die Seite in der URL aufscheint also http://domain.com/blog/[slug]"
 
-#: .\content\models.py:212
+#: models.py:214
 msgid "Path"
 msgstr "Pfad"
 
-#: .\content\models.py:224
+#: models.py:226
 msgid "Position"
 msgstr "Position"
 
-#: .\content\models.py:229
+#: models.py:231
 msgid "status"
 msgstr "Status"
 
-#: .\content\models.py:232 .\content\models.py:234
+#: models.py:234 models.py:236
 msgid "search description"
 msgstr "Beschreibung für Suchfunktion"
 
-#: .\content\models.py:237
+#: models.py:239
 msgid "content type"
 msgstr "Inhaltstyp"
 
-#: .\content\models.py:242
+#: models.py:244
 msgid "enable comments"
 msgstr "Kommentare möglich"
 
-#: .\content\models.py:247
+#: models.py:249
 msgid "Template"
 msgstr "Vorlage"
 
-#: .\content\models.py:255
+#: models.py:257
 msgid "first created at"
 msgstr "erstellt am"
 
-#: .\content\models.py:260
+#: models.py:262
 msgid "latest updated at"
 msgstr "letzte Aktualisierung am"
 
-#: .\content\models.py:331
+#: models.py:333
 msgid "Page"
 msgstr "Seite"
 
-#: .\content\models.py:332
+#: models.py:334
 msgid "Pages"
 msgstr "Seiten"
 
-#: .\content\templates\content\article_archive.html:5
-#: .\content\templates\content\article_archive.html:20
+#: templates/content/article_archive.html:5
+#: templates/content/article_archive.html:20
 msgid "Article Archive"
 msgstr "Nachrichtenarchiv"
 
-#: .\content\templates\content\article_archive.html:35
-#: .\content\templates\content\article_archive_month.html:5
-#: .\content\templates\content\article_archive_year.html:7
+#: templates/content/article_archive.html:35
+#: templates/content/article_archive_month.html:5
+#: templates/content/article_archive_year.html:7
 msgid "Archive"
 msgstr "Archiv"
 
-#: .\content\templates\content\article_archive.html:56
+#: templates/content/article_archive.html:56
 msgid "All Categories"
 msgstr "Alle Kategorien"
 
-#: .\content\templates\content\article_archive.html:71
+#: templates/content/article_archive.html:71
 msgid "created on"
 msgstr "erstellt am"
 
-#: .\content\templates\content\article_archive.html:73
+#: templates/content/article_archive.html:73
 msgid "by"
 msgstr "von"
 
-#: .\content\templates\content\article_archive.html:74
-#: .\content\templates\content\article_archive.html:75
+#: templates/content/article_archive.html:74
+#: templates/content/article_archive.html:75
 msgid "comments"
 msgstr "Kommentare"
 
-#: .\content\templates\content\article_archive.html:81
+#: templates/content/article_archive.html:81
 msgid "Read More"
 msgstr "Mehr lesen"
 
-#: .\content\templates\content\article_archive.html:86
+#: templates/content/article_archive.html:86
 msgid "We're sorry. Your search yielded no results."
 msgstr "Es tut uns leid. Deine Suche ergab keine Treffer."
 
-#: .\content\templates\content\article_archive.html:104
+#: templates/content/article_archive.html:104
 msgid "Add Article"
 msgstr "neuer Artikel "
 
-#: .\content\templates\content\article_archive_month.html:7
+#: templates/content/article_archive_month.html:7
 msgid "back"
 msgstr "Zurück"
 
-#: .\content\templates\content\article_detail.html:24
+#: templates/content/article_detail.html:25
 msgid "Created on"
 msgstr "Erstellt am"
 
-#: .\content\templates\content\article_detail.html:36
+#: templates/content/article_detail.html:39
 msgid "share on"
 msgstr "Teile auf"
 
-#: .\content\templates\content\article_detail.html:51 .\content\views.py:156
+#: templates/content/article_detail.html:48 views.py:160
 msgid "Edit Article"
 msgstr "Artikel bearbeiten"
 
-#: .\content\templates\content\article_form.html:32
-#: .\content\templates\content\page_form.html:42
-#: .\content\templates\content\page_form.html:49
+#: templates/content/article_form.html:24
+#: templates/content/article_form.html:31 templates/content/page_form.html:42
+#: templates/content/page_form.html:49
 msgid "German"
 msgstr "Deutsch"
 
-#: .\content\templates\content\article_form.html:33
-#: .\content\templates\content\page_form.html:43
-#: .\content\templates\content\page_form.html:57
+#: templates/content/article_form.html:25
+#: templates/content/article_form.html:39 templates/content/page_form.html:43
+#: templates/content/page_form.html:57
 msgid "English"
 msgstr "Englisch"
 
-#: .\content\templates\content\article_form.html:59
-#: .\content\templates\content\page_form.html:66
+#: templates/content/article_form.html:47 templates/content/page_form.html:66
 msgid "reset"
 msgstr "Zurücksetzen"
 
-#: .\content\templates\content\article_form.html:60
-#: .\content\templates\content\page_form.html:67
+#: templates/content/article_form.html:48 templates/content/page_form.html:67
 msgid "save"
 msgstr "Speichern"
 
-#: .\content\templates\content\page_form.html:5
-#: .\content\templates\content\page_form.html:35
+#: templates/content/page_form.html:5 templates/content/page_form.html:35
 msgid "Edit Page"
 msgstr "Seite bearbeiten"
 
-#: .\content\templates\content\page_form.html:5
-#: .\content\templates\content\page_form.html:19
-#: .\content\templates\content\page_form.html:35
+#: templates/content/page_form.html:5 templates/content/page_form.html:19
+#: templates/content/page_form.html:35
 msgid "Add Page"
 msgstr "Seite hinzufügen"
 
-#: .\content\templates\content\page_form.html:18
+#: templates/content/page_form.html:18
 msgid "Edit"
 msgstr "Bearbeiten"
 
-#: .\content\templates\content\page_form.html:37
+#: templates/content/page_form.html:37
 msgid "HTML Specific"
 msgstr "HTML spezifisch"
 
-#: .\content\views.py:53
+#: views.py:53
 msgid "This Category does not exist."
 msgstr "Diese Kategorie existiert nicht."
 
-#: .\content\views.py:157
+#: views.py:161
 msgid "Create Article"
 msgstr "Artikel erstellen"
 
-#: .\content\views.py:233
+#: views.py:241
 #, python-format
 msgid "No Page found matching the Path %s"
 msgstr "Keine Seite unter dem Pfad %s gefunden"
 
-#: .\content\views.py:262
+#: views.py:270
 #, python-format
 msgid "No PDF Document found matching the Path %s"
 msgstr "Kein PDF Dokument unter dem Pfad %s gefunden."

src/content/migrations/0002_auto_20150823_2232.py

@@ -2,7 +2,6 @@
 from __future__ import unicode_literals
 
 from django.db import migrations
-from django.db import models
 import ckeditor.fields
 
 

src/content/migrations/0006_auto_20171115_0653.py

@@ -7,7 +7,6 @@ from django.db import migrations, models
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('content', '0005_auto_20161012_2236'),
     ]
@@ -16,52 +15,68 @@ class Migration(migrations.Migration):
         migrations.AlterField(
             model_name='article',
             name='content_de',
-            field=ckeditor_uploader.fields.RichTextUploadingField(verbose_name='Inhalt'),
+            field=ckeditor_uploader.fields.RichTextUploadingField(
+                verbose_name='Inhalt'),
         ),
         migrations.AlterField(
             model_name='article',
             name='content_en',
-            field=ckeditor_uploader.fields.RichTextUploadingField(blank=True, verbose_name='Content'),
+            field=ckeditor_uploader.fields.RichTextUploadingField(
+                blank=True, verbose_name='Content'),
         ),
         migrations.AlterField(
             model_name='article',
             name='headline_en',
-            field=models.CharField(blank=True, max_length=255, verbose_name='Headline'),
+            field=models.CharField(
+                blank=True, max_length=255, verbose_name='Headline'),
         ),
         migrations.AlterField(
             model_name='article',
             name='image',
-            field=models.ImageField(blank=True, null=True, upload_to='news/', verbose_name='Bild'),
+            field=models.ImageField(blank=True, null=True, upload_to='news/',
+                                    verbose_name='Bild'),
         ),
         migrations.AlterField(
             model_name='article',
             name='slug',
-            field=models.SlugField(unique_for_month='date_created', verbose_name='Slug'),
+            field=models.SlugField(unique_for_month='date_created',
+                                   verbose_name='Slug'),
         ),
         migrations.AlterField(
             model_name='category',
             name='image',
-            field=models.ImageField(blank=True, null=True, upload_to='news/categories/', verbose_name='Bild'),
+            field=models.ImageField(blank=True, null=True,
+                                    upload_to='news/categories/',
+                                    verbose_name='Bild'),
         ),
         migrations.AlterField(
             model_name='page',
             name='content_de',
-            field=ckeditor_uploader.fields.RichTextUploadingField(blank=True, verbose_name='Inhalt'),
+            field=ckeditor_uploader.fields.RichTextUploadingField(
+                blank=True,
+                verbose_name='Inhalt'),
         ),
         migrations.AlterField(
             model_name='page',
             name='content_en',
-            field=ckeditor_uploader.fields.RichTextUploadingField(blank=True, verbose_name='Content'),
+            field=ckeditor_uploader.fields.RichTextUploadingField(
+                blank=True,
+                verbose_name='Content'),
         ),
         migrations.AlterField(
             model_name='page',
             name='menu_name_de',
-            field=models.CharField(help_text='Ein kurzer Name für den Menüeintrag', max_length=255, verbose_name='Menü Name'),
+            field=models.CharField(
+                help_text='Ein kurzer Name für den Menüeintrag',
+                max_length=255, verbose_name='Menü Name'),
         ),
         migrations.AlterField(
             model_name='page',
             name='menu_name_en',
-            field=models.CharField(blank=True, help_text='Ein kurzer Name für den Menüeintrag', max_length=255, verbose_name='Menu Name'),
+            field=models.CharField(
+                blank=True,
+                help_text='Ein kurzer Name für den Menüeintrag',
+                max_length=255, verbose_name='Menu Name'),
         ),
         migrations.AlterField(
             model_name='page',
@@ -76,16 +91,22 @@ class Migration(migrations.Migration):
         migrations.AlterField(
             model_name='page',
             name='template',
-            field=models.CharField(default='content/page.html', max_length=255, verbose_name='Vorlage'),
+            field=models.CharField(default='content/page.html', max_length=255,
+                                   verbose_name='Vorlage'),
         ),
         migrations.AlterField(
             model_name='page',
             name='title_de',
-            field=models.CharField(help_text="The page title as you'd like it to be seen by the public", max_length=255, verbose_name='Titel'),
+            field=models.CharField(
+                help_text="The page title as you'd like it to be seen by the public",
+                max_length=255, verbose_name='Titel'),
         ),
         migrations.AlterField(
             model_name='page',
             name='title_en',
-            field=models.CharField(blank=True, help_text="The page title as you'd like it to be seen by the public", max_length=255, verbose_name='Title'),
+            field=models.CharField(
+                blank=True,
+                help_text="The page title as you'd like it to be seen by the public",
+                max_length=255, verbose_name='Title'),
         ),
     ]

src/content/migrations/0007_auto_20171214_1215.py

@@ -8,7 +8,6 @@ import django.db.models.deletion
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('content', '0006_auto_20171115_0653'),
     ]
@@ -17,11 +16,15 @@ class Migration(migrations.Migration):
         migrations.AlterField(
             model_name='article',
             name='author',
-            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, to=settings.AUTH_USER_MODEL, verbose_name='Autor'),
+            field=models.ForeignKey(
+                on_delete=django.db.models.deletion.PROTECT,
+                to=settings.AUTH_USER_MODEL, verbose_name='Autor'),
         ),
         migrations.AlterField(
             model_name='article',
             name='category',
-            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, to='content.Category', verbose_name='Kategorie'),
+            field=models.ForeignKey(
+                on_delete=django.db.models.deletion.PROTECT,
+                to='content.Category', verbose_name='Kategorie'),
         ),
     ]

src/content/migrations/0008_auto_20190106_1954.py

@@ -0,0 +1,74 @@
+# Generated by Django 2.1.5 on 2019-01-06 18:54
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ('content', '0007_auto_20171214_1215'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='article',
+            name='status',
+            field=models.SmallIntegerField(
+                choices=[(-1, 'Rejected'), (0, 'Waiting...'), (1, 'Published')],
+                default=1, verbose_name='Status'),
+        ),
+        migrations.AlterField(
+            model_name='page',
+            name='date_created',
+            field=models.DateTimeField(
+                auto_now_add=True, db_index=True,
+                verbose_name='erstellt am'),
+        ),
+        migrations.AlterField(
+            model_name='page',
+            name='date_modified',
+            field=models.DateTimeField(auto_now=True,
+                                       verbose_name='letzte Aktualisierung am'),
+        ),
+        migrations.AlterField(
+            model_name='page',
+            name='description_de',
+            field=models.TextField(blank=True,
+                                   verbose_name='Beschreibung für Suchfunktion'),
+        ),
+        migrations.AlterField(
+            model_name='page',
+            name='description_en',
+            field=models.TextField(blank=True,
+                                   verbose_name='Beschreibung für Suchfunktion'),
+        ),
+        migrations.AlterField(
+            model_name='page',
+            name='slug',
+            field=models.SlugField(
+                help_text='Wie die Seite in der URL aufscheint also ' +
+                          'http://domain.com/blog/[slug]',
+                max_length=100, verbose_name='Slug'),
+        ),
+        migrations.AlterField(
+            model_name='page',
+            name='status',
+            field=models.SmallIntegerField(
+                choices=[(-1, 'Rejected'), (0, 'Waiting...'), (1, 'Published')],
+                default=0, verbose_name='Status'),
+        ),
+        migrations.AlterField(
+            model_name='page',
+            name='title_de',
+            field=models.CharField(
+                help_text='Der Seitentitel der öffentlich angezeigt werden soll',
+                max_length=255, verbose_name='Titel'),
+        ),
+        migrations.AlterField(
+            model_name='page',
+            name='title_en',
+            field=models.CharField(
+                blank=True,
+                help_text='Der Seitentitel der öffentlich angezeigt werden soll',
+                max_length=255, verbose_name='Title'),
+        ),
+    ]

src/content/migrations/0009_alter_page_id.py

@@ -0,0 +1,18 @@
+# Generated by Django 4.2.2 on 2023-06-11 09:26
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('content', '0008_auto_20190106_1954'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='page',
+            name='id',
+            field=models.AutoField(primary_key=True, serialize=False),
+        ),
+    ]

src/content/migrations/0010_alter_page_parent.py

@@ -0,0 +1,20 @@
+# Generated by Django 4.2.2 on 2023-06-11 13:41
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ('content', '0009_alter_page_id'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='page',
+            name='parent',
+            field=models.ForeignKey(
+                blank=True, null=True, on_delete=django.db.models.deletion.CASCADE,
+                related_name='subpages', to='content.page'),
+        ),
+    ]

src/content/migrations/0011_alter_page_id.py

@@ -0,0 +1,19 @@
+# Generated by Django 4.2.2 on 2023-07-19 18:11
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ('content', '0010_alter_page_parent'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='page',
+            name='id',
+            field=models.AutoField(
+                auto_created=True, primary_key=True, serialize=False,
+                verbose_name='ID'),
+        ),
+    ]

src/content/models.py

@@ -8,7 +8,7 @@ from django.template.defaultfilters import slugify
 from django.urls import reverse
 from django.utils import timezone
 from django.utils.safestring import mark_safe
-from django.utils.translation import get_language, ugettext as _
+from django.utils.translation import get_language, gettext as _
 
 from utils import STATUS_CHOICES, STATUS_WAITING, STATUS_PUBLISHED, CLEANER
 
@@ -111,6 +111,7 @@ class Article(models.Model):
         """Returns the headline of this article."""
         return self.headline
 
+    # noinspection PyUnresolvedReferences
     @property
     def get_image(self):
         """Return the article image, or the category image if unset."""
@@ -169,6 +170,7 @@ class Category(models.Model):
         return self.name
 
 
+# noinspection PyUnresolvedReferences
 class Page(models.Model):
     """A page on this homepage. It can have a "static" HTML page, the URL of a
     dynamic Django view, or a PDF document.
@@ -216,7 +218,7 @@ class Page(models.Model):
         blank=True,
         null=True,
         related_name='subpages',
-        on_delete=models.SET_NULL
+        on_delete=models.CASCADE
     )
     position = models.PositiveSmallIntegerField(
         blank=True,
@@ -317,12 +319,12 @@ class Page(models.Model):
             raise ValidationError(
                 _(u'Please upload a PDF-File to this PDF-Page.'))
 
-    def get_absolute_url(self):
+    def get_absolute_url(self) -> str:
         """Return the path with an extension that matches the content type.
-        It's useful for an user to match the URL to the contenttype.
+        It's useful for a user to match the URL to the contenttype.
 
-        :return: sting with the absolute URL of this page."""
-        return '/' + self.path + CONTENT_TYPE_EXTENSIONS[self.content_type]
+        :return: string with the absolute URL of this page."""
+        return '/' + str(self.path) + CONTENT_TYPE_EXTENSIONS[self.content_type]
 
     class Meta(object):
         """Set default ordering and an unique priamry key to avoid dupes."""

src/content/news_urls.py

@@ -4,26 +4,22 @@ Created on 03.10.2011
 
 @author: christian
 """
-from django.conf.urls import url
-
-from .views import ArticleArchiveIndex, ArticleForm, ArticleYearArchive, \
-    ArticleMonthArchive, ArticleDetail
-
+from django.urls import path
+from . import views
 
 urlpatterns = [
-    url(r'^$', ArticleArchiveIndex.as_view(), name='article-archive'),
-    url(r'^add/$', ArticleForm.as_view(), name='add-article'),
-    url(r'^edit/(?P<pk>[\d]+)/$', ArticleForm.as_view(), name='edit-article'),
-    url(r'^(?P<year>[\d]{4})/$', ArticleYearArchive.as_view(),
+    path("", views.ArticleArchiveIndex.as_view(), name='article-archive'),
+    path('add/', views.ArticleForm.as_view(), name='add-article'),
+    path('edit/<int:pk>/', views.ArticleForm.as_view(), name='edit-article'),
+    path('<int:year>/', views.ArticleYearArchive.as_view(), name='article-archive'),
+    path('<int:year>/<int:month>/', views.ArticleMonthArchive.as_view(),
          name='article-archive'),
-    url(r'^(?P<year>[\d]{4})/(?P<month>[\d]+)/$', ArticleMonthArchive.as_view(),
+    path('<int:year>/<int:month>/<slug:slug>/', views.ArticleDetail.as_view(),
+         name='show-article'),
+    path('<slug:category>/', views.ArticleArchiveIndex.as_view(),
          name='article-archive'),
-    url(r'^(?P<year>[\d]{4})/(?P<month>[\d]+)/(?P<slug>[\-\d\w]+)/$',
-        ArticleDetail.as_view(), name='show-article'),
-    url(r'^(?P<category>[\-\d\w]+)/$', ArticleArchiveIndex.as_view(),
+    path('<slug:category>/<int:year>/', views.ArticleYearArchive.as_view(),
+         name='article-archive'),
+    path('<slug:category>/<int:year>/<int:month>/', views.ArticleMonthArchive.as_view(),
          name='article-archive'),
-    url(r'^(?P<category>[\-\d\w]+)/(?P<year>[\d]{4})/$',
-        ArticleYearArchive.as_view(), name='article-archive'),
-    url(r'^(?P<category>[\-\d\w]+)/(?P<year>[\d]{4})/(?P<month>[\d]+)/$',
-        ArticleMonthArchive.as_view(), name='article-archive'),
 ]

src/content/sitemaps.py

@@ -8,7 +8,7 @@ class ArticleSitemap(GenericSitemap):
     min_priority = 0.25
 
     @staticmethod
-    def items():
+    def items(**kwargs):
         """only add published articles to the sitemap"""
         return Article.objects.published()
 
@@ -18,6 +18,6 @@ class PageSitemap(GenericSitemap):
     min_priority = 0.5
 
     @staticmethod
-    def items():
+    def items(**kwargs):
         """add all pages to the sitemap."""
         return Page.objects.all()

src/content/templates/content/article_archive.html

@@ -53,10 +53,10 @@
 {% block navigation %}
  <ul id="navigation">
   <li><a href="{{current_top_page.get_absolute_url}}"
-         {% if not active_category %} class="active" {% endif %}>{% trans 'All Categories' %}</a></li>
+         class="active">{% trans 'All Categories' %}</a></li>
  {% for category in categories %}
   <li><a href="{% url 'article-archive' category=category.slug %}"
-       {% ifequal category.slug active_category.slug  %} class="active"{% endifequal %}>{{ category.name }}</a></li>
+         class="active">{{ category.name }}</a></li>
 {% endfor %}
  </ul>
 {% endblock %}
@@ -69,7 +69,7 @@
     <h3><a href="{{article.get_absolute_url}}">{{article.headline}}</a></h3>
     <ul class="info">
      <li><span class="fa fa-calendar-o" title="{% trans 'created on' %}"></span> <time
-       datetime="{{article.date_created|date:'c'}}">{{ article.date_created|date }}</time></li>
+       datetime="{{article.date_created|date:'Y-m-d\TH:i:sO'}}">{{ article.date_created|date }}</time></li>
      <li><span class="fa fa-user" title="{% trans 'by' %}"></span> {{ article.author }}</li>
      <li><span class="fa fa-comments" title="{% trans 'comments' %}"></span> <a
        href="{{article.get_absolute_url}}#comments" >{{comment_count}} {% trans "comments" %}</a></li>

src/content/templates/content/article_detail.html

@@ -1,5 +1,4 @@
-{% extends "base.html" %}
-{% load i18n comments thumbnail %}
+{% extends "base.html" %}{% load i18n comments thumbnail %}
 
 {% block title %}{{ article.headline }}{% endblock %}
 
@@ -11,8 +10,7 @@
 <meta property="og:url" content="http://www.kasu.at{{ article.get_absolute_url }}"/>
 <meta property="og:image" content="http://www.kasu.at{{article.get_image|thumbnail_url:'article'}}"/>
 <meta property="og:description" content="{{article.content|striptags|truncatewords:25|force_escape}}"/>
-  <link rel="image_src" type="image/jpeg" href="{{article.get_image|thumbnail_url:'article'}}" />
-{% endblock %}
+<link rel="image_src" type="image/jpeg" href="{{article.get_image|thumbnail_url:'article'}}"/>{% endblock %}
 
 {% block itemscope %}itemscope itemtype="http://schema.org/Article"{% endblock %}
 
@@ -20,34 +18,31 @@
 <h1 itemprop="name">{{article.headline}}</h1>
 <div id="teaser_text">
   <ul class="info">
-        <li><span class="fa fa-user"></span> <strong>{% trans 'Author' %}:</strong> <a href="{% url 'membership-details' article.author %}" itemprop="author">{{article.author}}</a></li>
-        <li><span class="fa fa-calendar-o"></span> <strong>{% trans 'Created on' %}: </strong><time datetime="{{article.date_created|date:'Y-m-d H:i'}}">{{ article.date_created|date:'DATE_FORMAT' }}</time></li>
-        <li><span class="fa fa-tag"></span> <strong>{% trans "Category"%}: </strong><a href="{{ article.category.get_absolute_url }}" itemprop="articleSection">{{article.category.name}}</a></li>
+    <li><span class="fa fa-user"></span> <strong>{% trans 'Author' %}:</strong>
+      <a href="{% url 'membership-details' article.author %}" itemprop="author">{{article.author}}</a>
+    </li>
+    <li><span class="fa fa-calendar-o"></span>
+      <strong>{% trans 'Created on' %}:</strong>
+      <time datetime="{{article.date_created|date:'Y-m-d\TH:i:sO'}}">{{ article.date_created|date:'DATE_FORMAT' }}</time>
+    </li>
+    <li><span class="fa fa-tag"></span> <strong>{% trans "Category"%}:</strong>
+      <a href="{{ article.category.get_absolute_url }}" itemprop="articleSection">{{article.category.name}}</a>
+    </li>
   </ul>
-</div>
-{% endblock %}
+</div>{% endblock %}
 
 {% block maincontent %}
 <div itemprop="articleBody" class="grid_12">
-    <img alt="{{article.category.name}}" src="{{article.get_image|thumbnail_url:'article'}}" class="posting_image" itemprop="image"/>
-    {{ article.content }}
+  <img alt="{{article.category.name}}" src="{{article.get_image|thumbnail_url:'article'}}" class="posting_image" itemprop="image"/> {{ article.content }}
 </div>
 <p class="right">
   <strong>{% trans 'share on' %}:</strong>
-   <a class="button" href="https://plus.google.com/share?url=http%3A%2F%2Fwww.kasu.at{{article.get_absolute_url|urlencode}}"
-      onclick="javascript:window.open(this.href,'', 'menubar=no,toolbar=no,resizable=yes,scrollbars=yes,height=600,width=600');return false;"><span class="fa fa-google-plus"></span> Google+</a>
+  <a class="button" href="https://plus.google.com/share?url=http%3A%2F%2Fwww.kasu.at{{article.get_absolute_url|urlencode}}" onclick="javascript:window.open(this.href,'', 'menubar=no,toolbar=no,resizable=yes,scrollbars=yes,height=600,width=600');return false;"><span class="fa fa-google-plus"></span> Google+</a>
   <a class="button" href="https://twitter.com/share?url=http%3A%2F%2Fwww.kasu.at{{article.get_absolute_url|urlencode}}" target='_blank'><span class="fa fa-twitter"></span> Twitter</a>
   <a class="button" href="http://facebook.com/sharer.php?u=http%3A%2F%2Fwww.kasu.at{{article.get_absolute_url|urlencode}}?t={{article.headline|urlencode}}" target="_blank"><span class="fa fa-facebook"></span> Facebook</a>
-  </p>
-{% endblock %}
+</p>{% endblock %}
 
-{% block comments%}
- {% render_comment_list for article %}
- {% render_comment_form for article %}
-{% endblock %}
+{% block comments%}{% render_comment_list for article %}{% render_comment_form for article %}{% endblock %}
 
-{% block buttonbar %}
- {% if perms.content.change_article %}
-  <a href="{% url 'edit-article' article.id %}" class="button"><span class="fa fa-pencil"></span> {% trans "Edit Article" %}</a>
- {% endif %}
-{% endblock %}
+{% block buttonbar %}{% if perms.content.change_article %}
+<a href="{% url 'edit-article' article.id %}" class="button"><span class="fa fa-pencil"></span> {% trans "Edit Article" %}</a>{% endif %}{% endblock %}

src/content/templates/content/article_form.html

@@ -9,51 +9,39 @@
 {% endblock %}
 
 {% block maincontent %}
+{% get_fieldset "category, image" from form as fieldset_common %}
+{% get_fieldset "headline_de" from form as fieldset_de %}
+{% get_fieldset "headline_en" from form as fieldset_en %}
+
 <form action="" method="post" enctype="multipart/form-data">
     {{ form.media }} {% csrf_token %}
 
     <fieldset>
-    <div>
-      <label for="id_category" class="field_name {{ form.category.css_classes }}">{{ form.category.label}}</label>
-      {{ form.category }}
-      {% if form.category.help_text %}<p class="help_text">{{form.category.help_text}}</p>{% endif %}
-      {% if form.category.errors %}{{ form.category.errors }}{% endif %}
-    </div>
-    <div>
-      <label for="id_image" class="field_name {{ form.image.css_classes }}">{{ form.image.label}}</label>
-      {{ form.image }}
-      {% if form.image.help_text %}<p class="help_text">{{form.image.help_text}}</p>{% endif %}
-      {% if form.image.errors %}{{ form.image.errors }}{% endif %}
-    </div>
-
+    {% with fieldset_common as form %}{% include "form.html" %}{% endwith %}
     </fieldset>
 
-  <ul class="tabs grid_12">
+    <ul class="tabs">
         <li><a href="#de">{% trans "German" %}</a></li>
         <li><a href="#en">{% trans "English" %}</a></li>
     </ul>
-        <label for="id_{{ form.headline_de.html_name }}" class="fieldname {{ form.headline_de.css_classes }}">
-          {{ form.headline_de.label }}</label>
-        <p class="grid_10">{{ form.headline_de }}</p>
 
     <div class="tab_container">
-    <div id="de" class="tab_content">
-      <fieldset>
-        <legend>Deutsch</legend>
-        <label for="id_{{ form.headline_de.html_name }}" class="fieldname {{ form.headline_de.css_classes }}">
-          {{ form.headline_de.label }}</label>
-        <p class="grid_10">{{ form.headline_de }}</p>
+        <section id="de" class="tab_content">
+            <fieldset class="grid_12">
+                <legend>{% trans "German" %}</legend>
+                {% with fieldset_de as form %}{% include "form.html" %}{% endwith %}
             </fieldset>
+            <br>
             {{form.content_de}}
-    </div>
-    <div id="en" class="tab_content">
-      <h3 class="grid_12">English</h3>
-      <label for="id_{{ form.headline_en.html_name }}" class="grid_2 {{ form.headline_en.css_classes }}">
-        {{ form.headline_en.label }}</label>
-      <p class="grid_10">{{ form.headline_en }}</p>
-      <p>&nbsp;</p>
+        </section>
+        <section id="en" class="tab_content">
+            <fieldset class="grid_12">
+                <legend>{% trans "English" %}</legend>
+                {% with fieldset_en as form %}{% include "form.html" %}{% endwith %}
+            </fieldset>
+            <br>
         {{form.content_en}}
-    </div>
+        </section>
     </div>
     <p class="buttonbar">
         <button type="reset"><span class="fa fa-undo"></span> {% trans 'reset' %}</button>

src/content/templates/content/page_pdf.html

@@ -1,66 +0,0 @@
-<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
-<html>
-<head>
-<title>{% block title %}{{page.title}}{% endblock %}</title>
-<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
-<style>
-@font-face {
-	font-family: 'Amerika Sans';
-	src: url('{{ STATIC_ROOT }}/fonts/amerika_sans.ttf');
-}
-
-@font-face {
-	font-family: 'Philosopher';
-	src: url('{{ STATIC_ROOT }}/fonts/philosopher-regular.ttf');
-	font-weight: normal;
-	font-style: normal;
-}
-
-h1,h2,h3,h4,h5,h6 {
-	font-family: 'Amerika Sans', Helvetica;
-	font-variant: small-caps;
-	font-weight: bold;
-	margin: 0.5em 0 0.2em 0;
-}
-
-body {
-	font-family: Philosopher;
-	font-size: 12pt;
-}
-
-#page_header {
-	text-align: right;
-}
-
-@page {
-	margin-right: 0;
-	margin-bottom: 0;
-	margin-top: 35mm;
-	margin-left: 2cm;
-	@frame header {
-		-pdf-frame-content : page_header;
-		top: 0;
-		margin: 5mm;
-		height: 4cm;
-	}
-	@frame footer {
-		-pdf-frame-content: page_footer;
-		bottom: 0cm;
-		height: 2cm;
-		margin: 5mm;
-	}
-}
-</style>
-</head>
-<body>
-	<h1>{{ page.title }}</h1>
-	{{ page.content }}
-	<div id="page_header">
-		<img src="{{STATIC_ROOT}}/img/logo.png" alt="Kasu">
-	</div>
-	<div id="page_footer">
-		{{ page.title }} Seite:
-		<pdf:pagenumber />
-	</div>
-</body>
-</html>

src/content/views.py

@@ -5,7 +5,7 @@ from csp.decorators import csp_update
 from django.conf import settings
 from django.contrib.auth.mixins import PermissionRequiredMixin
 from django.http import HttpResponse, Http404
-from django.utils.translation import ugettext as _
+from django.utils.translation import gettext as _
 from django.views import generic
 
 from . import models, forms
@@ -19,7 +19,7 @@ class WYSIWYGEditorMixin(PermissionRequiredMixin):
 
     @csp_update(SCRIPT_SRC="'unsafe-eval'")
     def dispatch(self, request, *args, **kwargs):
-        """Add "unsafe-eval" to the Content-Secuirty-Policy HTTP Headers for the
+        """Add "unsafe-eval" to the Content-Security-Policy HTTP Headers for the
         WYSIWYG Editor.
 
         :param request: the HTTP Request Object
@@ -40,7 +40,7 @@ class ArticleArchiveMixin(object):
         Filter the queryset by category if one has been specified in the URL
 
         :param queryset: an model.Article.objects Queryset
-        :return: an model.Article.objects Queryset filterd by category
+        :return: an model.Article.objects Queryset filtered by category
         """
 
         category_slug = self.kwargs.get('category')
@@ -90,7 +90,7 @@ class ArticleArchiveIndex(ArticleArchiveMixin, generic.ArchiveIndexView):
 
 class ArticleYearArchive(ArticleArchiveMixin, generic.YearArchiveView):
     """
-    Displays the Articles filterd by a specific year
+    Displays the Articles filtered by a specific year
     """
 
     queryset = models.Article.objects.filter(status=models.STATUS_PUBLISHED)
@@ -113,7 +113,7 @@ class ArticleYearArchive(ArticleArchiveMixin, generic.YearArchiveView):
 
 class ArticleMonthArchive(ArticleArchiveMixin, generic.MonthArchiveView):
     """
-    Displays the Articles filterd by a specific month
+    Displays the Articles filtered by a specific month
     """
 
     queryset = models.Article.objects.filter(status=models.STATUS_PUBLISHED)
@@ -139,7 +139,11 @@ class ArticleDetail(generic.DetailView):
     Render the news Article, but only if it got published.
     """
 
+    def get_queryset(self):
         queryset = models.Article.objects.filter(status=models.STATUS_PUBLISHED)
+        queryset = queryset.filter(date_created__year=self.kwargs['year'])
+        queryset = queryset.filter(date_created__month=self.kwargs['month'])
+        return queryset
 
 
 class ArticleForm(WYSIWYGEditorMixin, generic.UpdateView):
@@ -170,7 +174,7 @@ class ArticleForm(WYSIWYGEditorMixin, generic.UpdateView):
 
 
 class PageAddForm(WYSIWYGEditorMixin, generic.CreateView):
-    """ Renders an Form to create a new page for users with conforming 
+    """ Renders a Form to create a new page for users with conforming
     permissions."""
 
     form_class = forms.PageForm
@@ -179,6 +183,7 @@ class PageAddForm(WYSIWYGEditorMixin, generic.CreateView):
 
     def get_initial(self):
         """Try to get the path of the parent page as initial data."""
+        if self.kwargs['path']:
             path = os.path.splitext(self.kwargs['path'])[0]
             if path.startswith('/'):
                 path = path[1:]
@@ -186,10 +191,12 @@ class PageAddForm(WYSIWYGEditorMixin, generic.CreateView):
                 path = path[:-1]
             parent = models.Page.objects.get(path=path)
             return {'parent': parent}
+        else:
+            return None
 
 
 class PageEditForm(WYSIWYGEditorMixin, generic.UpdateView):
-    """Renders an Form to edit a page for users with conforming permissions."""
+    """Renders a Form to edit a page for users with conforming permissions."""
 
     form_class = forms.PageForm
     model = models.Page
@@ -198,13 +205,14 @@ class PageEditForm(WYSIWYGEditorMixin, generic.UpdateView):
     def get_object(self, queryset=None):
         """ Get the path from the URL and fetch the corresponding page.
 
-        First get the path wihout fileextentsion leading or trailing slashes,
+        First get the path without file extension leading or trailing slashes,
         then search in the database if such a page exists.
 
         :param queryset: Get the single item from this filtered queryset.
         :return:
         """
-        path = os.path.splitext(self.kwargs['path'])[0]
+        path = self.kwargs['path'] or 'index.html'
+        path = os.path.splitext(path)[0]
         queryset = queryset or self.get_queryset()
         if path.startswith('/'):
             path = path[1:]
@@ -266,9 +274,9 @@ class PagePdf(generic.DeleteView):
     def render_to_response(self, context, **response_kwargs):
         """Stream the PDF File to the client and set the right content headers.
 
-        :param context: useless only for compatility
+        :param context: useless only for compatibility
         :param response_kwargs: will be added to the HttpResponse kwargs.
-        :return: an HTTPResponse with PDF Content or an Http404 exception
+        :return: an HTTPResponse with PDF Content or a Http404 exception
         """
         try:
             with open(self.object.pdf_file.path, 'rb') as pdf_file:
@@ -278,8 +286,8 @@ class PagePdf(generic.DeleteView):
                     **response_kwargs
                 )
                 return response
-        except:
-            raise Http404('File not Found %s.pdf' % self.kwargs['path'])
+        except FileExistsError:
+            raise Http404('File %s.pdf not found' % self.kwargs['path'])
 
 
 class StartPage(generic.TemplateView):
@@ -287,7 +295,7 @@ class StartPage(generic.TemplateView):
     template_name = 'index.html'
 
     def get_context_data(self):
-        """ Adds recent ariticles and recent comments to the context.
+        """ Adds recent articles and recent comments to the context.
 
         :return: array() with the context data
         """

src/events/admin.py

@@ -1,6 +1,6 @@
 """Django admin interface for the event app.
 
-It's the best way to add eventseries, or edit/delete events."""
+It's the best way to add event-series, or edit/delete events."""
 from django.contrib import admin
 from django.utils.translation import gettext as _
 
@@ -8,7 +8,7 @@ from events.models import Event, Photo, Location
 
 
 class EventInline(admin.TabularInline):
-    """To list events of an eventseries below the 'master event'"""
+    """To list events of an event-series below the 'master event'"""
     model = Event
     fields = ('name', 'start', 'end')
     verbose_name_plural = _('Event Series')

src/events/context_processors.py

@@ -1,20 +1,20 @@
 """ Content processor to display upcoming events on every page you want. """
 from django.core.cache import cache
+from django.http import HttpRequest
 from .models import Event
 
 
-def events_overview(request):  # Ignore PyLintBear (W0613)
+def events_overview(request: HttpRequest) -> dict[str, Event]:
     """
     Adds event information as variables to the template context on every page.
 
     For speed reasons everything will be cached for an hour. the following
     variables will be added to the template context:
-    * current_event: If an event is running at this moment, the correspondi
-      event object.
+    * current_event: object for the  currently running event.
     * next_event: the next event that is upcoming.
     * upcoming_events: the next 3 events that are upcoming.
 
-    :param request: An Django HTTPRequest object
+    :param request: a Django HTTPRequest object
     :return: dict() with the new context variables
     """
     current_event = cache.get('current_event', False)

src/events/forms.py

@@ -1,27 +1,42 @@
 """Django Forms to administrate the event content on the frontend."""
 from django import forms
 from django.contrib.auth import get_user_model
-from django.utils.translation import ugettext as _
+from django.utils.translation import gettext as _
 
 from . import models
 
 
+class ClearableMultipleFileInput(forms.widgets.ClearableFileInput):
+    allow_multiple_selected = True
+    accept = "image/jpg"
+
+
+class MultipleFileField(forms.FileField):
+    def __init__(self, *args, **kwargs):
+        kwargs.setdefault("widget", ClearableMultipleFileInput())
+        super().__init__(*args, **kwargs)
+
+    def clean(self, data, initial=None):
+        single_file_clean = super().clean
+        if isinstance(data, (list, tuple)):
+            result = [single_file_clean(d, initial) for d in data]
+        else:
+            result = single_file_clean(data, initial)
+        return result
+
+
 class PhotoUploadForm(forms.Form):
-    """Form to upload multiple photos to a single event."""
+    """Form to upload multiple photos to a single event.
+    TODO: Check multiple upload
+    """
     error_css_class = 'error'
     required_css_class = 'required'
     photographer = forms.ModelChoiceField(get_user_model().objects.all(),
                                           required=True, )
     event = forms.ModelChoiceField(models.Event.objects.all(), required=True, )
-    upload = forms.FileField(
+    upload = MultipleFileField(
         label=_('Images'),
         required=True,
-        widget=forms.widgets.ClearableFileInput(
-            attrs={
-                'multiple': 'multiple',
-                'accept': "image/gif,image/png,image/jpeg"
-            }
-        )
     )
 
 

src/events/gallery_urls.py

@@ -1,18 +1,17 @@
-""" urls for the event gallery part of the events app. """
-from django.conf.urls import url
+from django.urls import path
 
 from . import views
 
 urlpatterns = [
-    url(r'^$', views.EventGallery.as_view(), name='event-gallery'),
-    url(r'^(?P<event>[\d]+)/$', views.EventPhotoList.as_view(),
+    path("", views.EventGallery.as_view(), name='event-gallery'),
+    path('<int:event>/', views.EventPhotoList.as_view(),
          name='event-photo-list'),
-    url(r'^(?P<event>[\d]+)/upload/$', views.EventPhotoUpload.as_view(),
+    path('<int:event>/upload/', views.EventPhotoUpload.as_view(),
          name='event-photo-upload'),
-    url(r'^(?P<event>[\d]+)/(?P<pk>[\d]+)/$', views.EventPhoto.as_view(),
+    path('<int:event>/<int:pk>/', views.EventPhoto.as_view(),
          name='event-photo'),
-    url(r'^delete/(?P<pk>[\d]+)/$', views.DeleteEventPhoto.as_view(),
+    path('delete/<int:pk>/', views.DeleteEventPhoto.as_view(),
          name='delete-event-photo'),
-    url(r'^upload/$', views.EventPhotoUpload.as_view(),
+    path('upload/', views.EventPhotoUpload.as_view(),
          name='event-photo-upload'),
 ]

src/events/locale/de/LC_MESSAGES/django.po

@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: kasu.events\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2018-05-08 00:17+0200\n"
+"POT-Creation-Date: 2023-08-07 20:38+0200\n"
 "PO-Revision-Date: 2018-01-12 15:25+0105\n"
 "Last-Translator: b'Christian Berg <kasu@xendynastie.at>'\n"
 "Language-Team: Kasu <verein@kasu.at>\n"
@@ -19,58 +19,58 @@ msgstr ""
 "X-Generator: Poedit 1.8.9\n"
 "X-Translated-Using: django-rosetta 0.7.14\n"
 
-#: .\events\admin.py:14 .\events\models.py:82
+#: admin.py:14 models.py:83
 msgid "Event Series"
 msgstr "Veranstaltungsreihen"
 
-#: .\events\forms.py:17
+#: forms.py:38
 msgid "Images"
 msgstr "Bilder"
 
-#: .\events\forms.py:46
+#: forms.py:61
 msgid "start"
 msgstr "Beginn"
 
-#: .\events\forms.py:49
+#: forms.py:64
 msgid "end"
 msgstr "Ende"
 
-#: .\events\models.py:52 .\events\models.py:176 .\events\models.py:217
+#: mixins.py:86
+msgid "Event does not exist"
+msgstr "Veranstaltung gibt es nicht"
+
+#: models.py:53 models.py:177 models.py:218
 msgid "Name"
 msgstr "Name"
 
-#: .\events\models.py:53 .\events\models.py:177 .\events\models.py:225
+#: models.py:54 models.py:178 models.py:226
 msgid "Description"
 msgstr "Beschreibung"
 
-#: .\events\models.py:55 .\events\templates\events\event_detail.html:29
-#: .\events\templates\events\event_detail.html:87
-#: .\events\templates\events\event_list.html:28
-#: .\events\templates\events\photo_upload.html:13
+#: models.py:56 templates/events/event_detail.html:29
+#: templates/events/event_detail.html:87 templates/events/event_list.html:28
 msgid "Start"
 msgstr "Beginn"
 
-#: .\events\models.py:56 .\events\templates\events\event_detail.html:30
-#: .\events\templates\events\event_detail.html:89
+#: models.py:57 templates/events/event_detail.html:30
+#: templates/events/event_detail.html:89
 msgid "End"
 msgstr "Ende"
 
-#: .\events\models.py:57 .\events\models.py:185
-#: .\events\templates\events\event_detail.html:34
-#: .\events\templates\events\event_detail.html:80
-#: .\events\templates\events\event_detail.html:92
+#: models.py:58 models.py:186 templates/events/event_detail.html:34
+#: templates/events/event_detail.html:80 templates/events/event_detail.html:92
 msgid "Homepage"
 msgstr "Homepage"
 
-#: .\events\models.py:59 .\events\models.py:179 .\events\models.py:219
+#: models.py:60 models.py:180 models.py:220
 msgid "Image"
 msgstr "Bild"
 
-#: .\events\models.py:66
+#: models.py:67
 msgid "Mahjong Tournament"
 msgstr "Mahjong Turnier"
 
-#: .\events\models.py:68
+#: models.py:69
 msgid ""
 "This event is a tournament, different rules apply for         the kyu "
 "ranking."
@@ -78,11 +78,11 @@ msgstr ""
 "Diese Veranstaltung ist ein Turnier, es gelten andere Regeln für das Kyu "
 "Ranking."
 
-#: .\events\models.py:72
+#: models.py:73
 msgid "Mahjong Season"
 msgstr "Mahjong Saison"
 
-#: .\events\models.py:83
+#: models.py:84
 msgid ""
 "Wenn dieser Event zu einer Veranstaltungsreihe gehört         werden Ort, "
 "Beschreibung, Bild und Homepage von dem hier angegebenen         Event "
@@ -91,248 +91,223 @@ msgstr ""
 "Wenn dieser Termin zu einer Veranstaltungsreihe gehört werden Ort, "
 "Beschreibung, Bild und Homepage von dem hier angegebenen Event übernommen."
 
-#: .\events\models.py:92 .\events\models.py:195 .\events\models.py:248
+#: models.py:93 models.py:196 models.py:249
 msgid "first created at"
 msgstr "erstellt am"
 
-#: .\events\models.py:97 .\events\models.py:200 .\events\models.py:253
+#: models.py:98 models.py:201 models.py:254
 msgid "latest updated at"
 msgstr "letzte Aktualisierung am"
 
-#: .\events\models.py:103
+#: models.py:104
 msgid "Event"
 msgstr "Termin"
 
-#: .\events\models.py:104
+#: models.py:105
 msgid "Events"
 msgstr "Termine"
 
-#: .\events\models.py:117
+#: models.py:118
 msgid "A event can't end before it had started"
 msgstr "Eine Veranstaltung kann nicht enden bevor sie begonnen hat"
 
-#: .\events\models.py:186
+#: models.py:187
 msgid "Postal Code"
 msgstr "Postleitzahl"
 
-#: .\events\models.py:187
+#: models.py:188
 msgid "Street Address"
 msgstr "Straße"
 
-#: .\events\models.py:188
+#: models.py:189
 msgid "Locality"
 msgstr "Ort"
 
-#: .\events\models.py:189
+#: models.py:190
 msgid "Country"
 msgstr "Land"
 
-#: .\events\models.py:204
+#: models.py:205
 msgid "Venue"
 msgstr "Veranstaltungsort"
 
-#: .\events\models.py:205
+#: models.py:206
 msgid "Venues"
 msgstr "Veranstaltungsorte"
 
-#: .\events\models.py:232
+#: models.py:233
 msgid "Startpage"
 msgstr "Startseite"
 
-#: .\events\models.py:235
+#: models.py:236
 msgid "Display this Photo on the Startpage Teaser"
 msgstr "Foto als Teaser auf der Startseite verwenden."
 
-#: .\events\models.py:237
+#: models.py:238
 msgid "Published on"
 msgstr "Veröffentlicht am"
 
-#: .\events\models.py:239
+#: models.py:240
 msgid "Number of views"
 msgstr "Wie oft gesehen"
 
-#: .\events\models.py:263 .\events\templates\events\event_archive.html:38
-#: .\events\templates\events\event_list.html:18
+#: models.py:264 templates/events/event_archive.html:38
+#: templates/events/event_list.html:18
 msgid "Event Image"
 msgstr "Veranstaltungsbild"
 
-#: .\events\models.py:264
+#: models.py:265
 msgid "Event Images"
 msgstr "Veranstaltungsbilder"
 
-#: .\events\templates\events\event_archive.html:5
-#: .\events\templates\events\event_archive.html:9
+#: templates/events/event_archive.html:5 templates/events/event_archive.html:9
 msgid "Event Archive"
 msgstr "Veranstaltungsarchiv"
 
-#: .\events\templates\events\event_archive.html:42
-#: .\events\templates\events\event_detail.html:85
-#: .\events\templates\events\event_list.html:22
-#: .\events\templates\events\photo_detail.html:53
+#: templates/events/event_archive.html:42 templates/events/event_detail.html:85
+#: templates/events/event_list.html:22 templates/events/photo_detail.html:53
 msgid "Date"
 msgstr "Datum"
 
-#: .\events\templates\events\event_archive.html:47
+#: templates/events/event_archive.html:47
 msgid "Time"
 msgstr "Zeit"
 
-#: .\events\templates\events\event_archive.html:49
-#: .\events\templates\events\photo_upload.html:16
+#: templates/events/event_archive.html:49
 msgid "from"
 msgstr "von"
 
-#: .\events\templates\events\event_archive.html:49
-#: .\events\templates\events\photo_upload.html:16
+#: templates/events/event_archive.html:49
 msgid "to"
 msgstr "bis"
 
-#: .\events\templates\events\event_archive.html:57
-#: .\events\templates\events\event_detail.html:31
-#: .\events\templates\events\event_detail.html:72
-#: .\events\templates\events\event_list.html:32
-#: .\events\templates\events\photo_upload.html:23
+#: templates/events/event_archive.html:57 templates/events/event_detail.html:31
+#: templates/events/event_detail.html:72 templates/events/event_list.html:32
 msgid "Location"
 msgstr "Ort"
 
-#: .\events\templates\events\event_archive.html:58
-#: .\events\templates\events\event_list.html:35
-#: .\events\templates\events\photo_upload.html:25
-#: .\events\templates\events\photo_upload.html:26
+#: templates/events/event_archive.html:58 templates/events/event_list.html:35
 msgid "Comments"
 msgstr "Kommentare"
 
-#: .\events\templates\events\event_archive.html:59
-#: .\events\templates\events\event_detail.html:36
-#: .\events\templates\events\event_detail.html:48
-#: .\events\templates\events\photo_list.html:4
-#: .\events\templates\events\photo_upload.html:28
-#: .\events\templates\events\photo_upload.html:29
+#: templates/events/event_archive.html:59 templates/events/event_detail.html:36
+#: templates/events/event_detail.html:48 templates/events/photo_list.html:4
 msgid "Photos"
 msgstr "Fotos"
 
-#: .\events\templates\events\event_archive.html:60
-#: .\events\templates\events\event_archive.html:61
-#: .\events\templates\events\event_detail.html:35
-#: .\events\templates\events\event_detail.html:51
+#: templates/events/event_archive.html:60
+#: templates/events/event_archive.html:61 templates/events/event_detail.html:35
+#: templates/events/event_detail.html:51
 msgid "Hanchans"
 msgstr "Hanchans"
 
-#: .\events\templates\events\event_detail.html:37
+#: templates/events/event_detail.html:37
 msgid "tourney"
 msgstr "Turnier"
 
-#: .\events\templates\events\event_detail.html:37
+#: templates/events/event_detail.html:37
 msgid "other rules apply here"
 msgstr "hier gelten andere Regeln"
 
-#: .\events\templates\events\event_detail.html:45
+#: templates/events/event_detail.html:45
 msgid "Info"
 msgstr "Info"
 
-#: .\events\templates\events\event_detail.html:54
+#: templates/events/event_detail.html:54
 msgid "Mai-Star Games"
 msgstr "Mai-Star Spiele"
 
-#: .\events\templates\events\event_detail.html:57
+#: templates/events/event_detail.html:57
 msgid "Event Ranking"
 msgstr "Veranstaltungs Wertung"
 
-#: .\events\templates\events\event_detail.html:100
+#: templates/events/event_detail.html:100
 msgid "Share on Facebook"
 msgstr "Auf Facebook teilen"
 
-#: .\events\templates\events\event_detail.html:104
+#: templates/events/event_detail.html:104
 msgid "Share on Google+"
 msgstr "Auf Google+ teilen"
 
-#: .\events\templates\events\event_detail.html:109
+#: templates/events/event_detail.html:109
 msgid "Share on Twitter"
 msgstr "Auf Twitter teilen"
 
-#: .\events\templates\events\event_detail.html:113
+#: templates/events/event_detail.html:113
 msgid "Show on Google Maps"
 msgstr "Auf Google Maps zeigen"
 
-#: .\events\templates\events\event_detail.html:127
-#: .\events\templates\events\event_form.html:9 .\events\views.py:62
+#: templates/events/event_detail.html:127 templates/events/event_form.html:9
+#: views.py:61
 msgid "Edit Event"
 msgstr "Termin bearbeiten"
 
-#: .\events\templates\events\event_detail.html:131
+#: templates/events/event_detail.html:131
 msgid "Add Dates"
 msgstr "Termine hinzufügen"
 
-#: .\events\templates\events\event_form.html:9
-#: .\events\templates\events\page.html:9 .\events\views.py:64
+#: templates/events/event_form.html:9 templates/events/page.html:9 views.py:61
 msgid "Add Event"
 msgstr "Neuer Termin"
 
-#: .\events\templates\events\event_form.html:18
-#: .\events\templates\events\photo_list.html:35
+#: templates/events/event_form.html:18 templates/events/photo_list.html:35
 msgid "reset"
 msgstr "Zurücksetzen"
 
-#: .\events\templates\events\event_form.html:19
-#: .\events\templates\events\eventseries_form.html:25
+#: templates/events/event_form.html:19
+#: templates/events/eventseries_form.html:25
 msgid "save"
 msgstr "Speichern"
 
-#: .\events\templates\events\event_list.html:4
-#: .\events\templates\events\event_list.html:5
+#: templates/events/event_list.html:4 templates/events/event_list.html:5
 msgid "Upcoming Events"
 msgstr "Bevorstehende Veranstaltungen"
 
-#: .\events\templates\events\eventseries_form.html:24
+#: templates/events/eventseries_form.html:24
 msgid "back"
 msgstr "Zurück"
 
-#: .\events\templates\events\photo_confirm_delete.html:17
+#: templates/events/photo_confirm_delete.html:17
 msgid "Cancel"
 msgstr "Abbrechen"
 
-#: .\events\templates\events\photo_confirm_delete.html:21
-#: .\events\templates\events\photo_list.html:21
+#: templates/events/photo_confirm_delete.html:21
+#: templates/events/photo_list.html:21
 msgid "Delete"
 msgstr "Löschen"
 
-#: .\events\templates\events\photo_detail.html:44
+#: templates/events/photo_detail.html:44
 msgid "previous"
 msgstr "Zurück"
 
-#: .\events\templates\events\photo_detail.html:52
+#: templates/events/photo_detail.html:52
 msgid "Photographer"
 msgstr "Fotograf"
 
-#: .\events\templates\events\photo_detail.html:58
+#: templates/events/photo_detail.html:58
 msgid "share on"
 msgstr "Teile auf"
 
-#: .\events\templates\events\photo_detail.html:81
+#: templates/events/photo_detail.html:78
 msgid "download"
 msgstr "Herunterladen"
 
-#: .\events\templates\events\photo_detail.html:82
+#: templates/events/photo_detail.html:79
 msgid "Rotate counter clockwise"
 msgstr "mit dem Uhrzeiger drehen"
 
-#: .\events\templates\events\photo_detail.html:83
+#: templates/events/photo_detail.html:80
 msgid "Rotate clockwise"
 msgstr "gegen den Uhrzeiger drehen"
 
-#: .\events\templates\events\photo_detail.html:84
+#: templates/events/photo_detail.html:81
 msgid "Save"
 msgstr "Speichern"
 
-#: .\events\templates\events\photo_list.html:36
-#: .\events\templates\events\photo_upload.html:35
-#: .\events\templates\events\photo_upload.html:49
+#: templates/events/photo_list.html:36 templates/events/photo_upload.html:13
 msgid "Upload"
 msgstr "Hochladen"
 
-#: .\events\views.py:150
-msgid "Event does not exist"
-msgstr "Veranstaltung gibt es nicht"
-
 #~ msgid " Edit"
 #~ msgstr "Bearbeiten"
 

src/events/migrations/0001_initial.py

@@ -29,16 +29,21 @@ class Migration(migrations.Migration):
                 ('image', models.ImageField(storage=utils.OverwriteStorage(
                 ), upload_to=events.models.get_upload_path, null=True,
                     verbose_name='Bild', blank=True)),
-                ('is_tournament', models.BooleanField(default=False,
-                                                      help_text='Diese Veranstaltung ist ein Turnier, es gelten andere Regeln f\xfcr das Kyu Ranking.',
+                ('is_tournament', models.BooleanField(
+                    default=False,
+                    help_text='Diese Veranstaltung ist ein Turnier, ' +
+                              'es gelten andere Regeln f\xfcr das Kyu Ranking.',
                     verbose_name='Turnier')),
                 ('photo_count', models.PositiveIntegerField(
                     default=0, editable=False)),
                 ('event_series',
-                 models.ForeignKey(on_delete=django.db.models.deletion.SET_NULL,
+                 models.ForeignKey(
+                     on_delete=django.db.models.deletion.SET_NULL,
                      editable=False, to='events.Event',
                      blank=True,
-                                   help_text='Wenn dieser Termin zu einer Veranstaltungsreihe geh\xf6rt werden Ort, Beschreibung, Bild und Homepage von dem hier angegebenen Event \xfcbernommen.',
+                     help_text='Wenn dieser Termin zu einer Veranstaltungsreihe ' +
+                               'geh\xf6rt werden Ort, Beschreibung, Bild und ' +
+                               'Homepage von dem hier angegebenen Event \xfcbernommen.',
                      null=True,
                      verbose_name='Veranstaltungsreihen')),
             ],
@@ -67,21 +72,19 @@ class Migration(migrations.Migration):
                     max_length=127, verbose_name='Stra\xdfe')),
                 ('locality',
                  models.CharField(max_length=127, verbose_name='Ort')),
-                ('country', models.CharField(max_length=2, verbose_name='Land',
-                                             choices=[(b'GB',
-                                                       'Vereinigtes K\xf6nigreich'),
+                ('country', models.CharField(
+                    max_length=2, verbose_name='Land',
+                    choices=[(b'GB', 'Vereinigtes K\xf6nigreich'),
                              (b'AF', 'Afghanistan'),
                              (b'AX', 'Aland Islands'),
                              (b'AL', 'Albanien'),
-                                                      (b'DZ', 'Algerien'), (
-                                                          b'AS',
-                                                          'Amerikanisch-Samoa'),
+                             (b'DZ', 'Algerien'),
+                             (b'AS', 'Amerikanisch-Samoa'),
                              (b'AD', 'Andorra'),
                              (b'AO', 'Angola'),
                              (b'AI', 'Anguilla'),
-                                                      (b'AQ', 'Antarktika'), (
-                                                          b'AG',
-                                                          'Antigua und Barbuda'),
+                             (b'AQ', 'Antarktika'),
+                             (b'AG', 'Antigua und Barbuda'),
                              (b'AR', 'Argentinien'),
                              (b'AM', 'Armenien'),
                              (b'AW', 'Aruba'),
@@ -91,24 +94,20 @@ class Migration(migrations.Migration):
                              (b'BS', 'Bahamas'),
                              (b'BH', 'Bahrein'),
                              (b'BD', 'Bangladesch'),
-                                                      (b'BB', 'Barbados'), (
-                                                          b'BY',
-                                                          'Wei\xdfrussland'),
+                             (b'BB', 'Barbados'),
+                             (b'BY', 'Wei\xdfrussland'),
                              (b'BE', 'Belgien'),
                              (b'BZ', 'Belize'),
                              (b'BJ', 'Benin'),
                              (b'BM', 'Bermuda'),
                              (b'BT', 'Bhutan'),
-                                                      (b'BO', 'Bolivien'), (
-                                                          b'BA',
-                                                          'Bosnien und Herzegowina'),
+                             (b'BO', 'Bolivien'),
+                             (b'BA', 'Bosnien und Herzegowina'),
                              (b'BW', 'Botswana'),
                              (b'BV', 'Bouvet Island'),
-                                                      (b'BR', 'Brasilien'), (
-                                                          b'IO',
-                                                          'British Indian Ocean Territory'),
-                                                      (b'BN',
-                                                       'Brunei Darussalam'),
+                             (b'BR', 'Brasilien'),
+                             (b'IO', 'British Indian Ocean Territory'),
+                             (b'BN', 'Brunei Darussalam'),
                              (b'BG', 'Bulgarien'),
                              (b'BF', 'Burkina Faso'),
                              (b'BI', 'Burundi'),
@@ -117,51 +116,42 @@ class Migration(migrations.Migration):
                              (b'CA', 'Kanada'),
                              (b'CV', 'Cape Verde'),
                              (b'KY', 'Cayman Islands'),
-                                                      (b'CF',
-                                                       'Zentralafrikanische Republik'),
+                             (b'CF', 'Zentralafrikanische Republik'),
                              (b'TD', 'Tschad'),
                              (b'CL', 'Chile'),
-                                                      (b'CN', 'China'), (b'CX',
-                                                                         'Christmas Island'),
-                                                      (b'CC',
-                                                       'Cocos (Keeling) Islands'),
+                             (b'CN', 'China'),
+                             (b'CX', 'Christmas Island'),
+                             (b'CC', 'Cocos (Keeling) Islands'),
                              (b'CO', 'Kolumbien'),
                              (b'KM', 'Komoren'),
-                                                      (b'CG', 'Kongo'), (b'CD',
-                                                                         'Kongo, Demokratische Republik'),
+                             (b'CG', 'Kongo'),
+                             (b'CD', 'Kongo, Demokratische Republik'),
                              (b'CK', 'Cook-Inseln'),
                              (b'CR', 'Costa Rica'),
                              (b'CI', "Cote d'Ivoire"),
                              (b'HR', 'Kroatien'),
                              (b'CU', 'Kuba'),
-                                                      (b'CY', 'Zypern'), (b'CZ',
-                                                                          'Tschechische Republik'),
+                             (b'CY', 'Zypern'),
+                             (b'CZ', 'Tschechische Republik'),
                              (b'DK', 'D\xe4nemark'),
                              (b'DJ', 'Dschibuti'),
-                                                      (b'DM', 'Dominica'), (
-                                                          b'DO',
-                                                          'Dominikanische Republik'),
+                             (b'DM', 'Dominica'),
+                             (b'DO', 'Dominikanische Republik'),
                              (b'EC', 'Ecuador'),
                              (b'EG', '\xc4gypten'),
-                                                      (b'SV', 'El Salvador'), (
-                                                          b'GQ',
-                                                          '\xc4quatorial-Guinea'),
+                             (b'SV', 'El Salvador'),
+                             (b'GQ', '\xc4quatorial-Guinea'),
                              (b'ER', 'Eritrea'),
                              (b'EE', 'Estland'),
-                                                      (b'ET', '\xc4thiopien'), (
-                                                          b'FK',
-                                                          'Falklandinseln (Malvinas)'),
-                                                      (b'FO',
-                                                       'F\xe4r\xf6er-Inseln'),
+                             (b'ET', '\xc4thiopien'),
+                             (b'FK', 'Falklandinseln (Malvinas)'),
+                             (b'FO', 'F\xe4r\xf6er-Inseln'),
                              (b'FJ', 'Fidschi'),
                              (b'FI', 'Finnland'),
-                                                      (b'FR', 'Frankreich'), (
-                                                          b'GF',
-                                                          'Franz\xf6sisch-Guayana'),
-                                                      (b'PF',
-                                                       'Franz\xf6sisch-Polynesien'),
-                                                      (b'TF',
-                                                       'Franz\xf6sisch S\xfcdliche Territorien'),
+                             (b'FR', 'Frankreich'),
+                             (b'GF', 'Franz\xf6sisch-Guayana'),
+                             (b'PF', 'Franz\xf6sisch-Polynesien'),
+                             (b'TF', 'Franz\xf6sisch S\xfcdliche Territorien'),
                              (b'GA', 'Gabun'),
                              (b'GM', 'Gambia'),
                              (b'GE', 'Georgia'),
@@ -178,18 +168,16 @@ class Migration(migrations.Migration):
                              (b'GN', 'Guinea'),
                              (b'GW', 'Guinea-Bissau'),
                              (b'GY', 'Guyana'),
-                                                      (b'HT', 'Haiti'), (b'HM',
-                                                                         'Heard und McDonald Inseln'),
-                                                      (b'VA',
-                                                       'Heiliger Stuhl (Vatikanstadt)'),
+                             (b'HT', 'Haiti'),
+                             (b'HM', 'Heard und McDonald Inseln'),
+                             (b'VA', 'Heiliger Stuhl (Vatikanstadt)'),
                              (b'HN', 'Honduras'),
                              (b'HK', 'Hongkong'),
                              (b'HU', 'Ungarn'),
                              (b'IS', 'Island'),
                              (b'IN', 'Indien'),
-                                                      (b'ID', 'Indonesien'), (
-                                                          b'IR',
-                                                          'Iran, Islamische Republik'),
+                             (b'ID', 'Indonesien'),
+                             (b'IR', 'Iran, Islamische Republik'),
                              (b'IQ', 'Irak'),
                              (b'IE', 'Irland'),
                              (b'IM', 'Isle of Man'),
@@ -201,39 +189,36 @@ class Migration(migrations.Migration):
                              (b'JO', 'Jordan'),
                              (b'KZ', 'Kasachstan'),
                              (b'KE', 'Kenia'),
-                                                      (b'KI', 'Kiribati'), (
-                                                          b'KP',
-                                                          'Korea, Demokratische Volksrepublik'),
-                                                      (
-                                                          b'KR',
-                                                          'Korea, Republik'),
+                             (b'KI', 'Kiribati'),
+                             (b'KP', 'Korea, Demokratische Volksrepublik'),
+                             (b'KR', 'Korea, Republik'),
                              (b'KW', 'Kuwait'),
-                                                      (b'KG', 'Kirgisistan'), (
-                                                          b'LA',
-                                                          'Lao Demokratischen Volksrepublik'),
+                             (b'KG', 'Kirgisistan'),
+                             (b'LA', 'Lao Demokratischen Volksrepublik'),
                              (b'LV', 'Lettland'),
-                                                      (b'LB', 'Libanon'), (
-                                                          b'LS', 'Lesotho'),
+                             (b'LB', 'Libanon'),
+                             (b'LS', 'Lesotho'),
                              (b'LR', 'Liberia'),
                              (b'LY', 'Libyen'),
                              (b'LI', 'Liechtenstein'),
                              (b'LT', 'Litauen'),
                              (b'LU', 'Luxemburg'),
-                                                      (b'MO', 'Macao'), (b'MK',
+                             (b'MO', 'Macao'),
+                             (b'MK',
                               'Mazedonien, die ehemalige jugoslawische Republik'),
                              (b'MG', 'Madagaskar'),
                              (b'MW', 'Malawi'),
                              (b'MY', 'Malaysia'),
                              (b'MV', 'Malediven'),
                              (b'ML', 'Mali'),
-                                                      (b'MT', 'Malta'), (b'MH',
-                                                                         'Marshall Islands'),
+                             (b'MT', 'Malta'),
+                             (b'MH', 'Marshall Islands'),
                              (b'MQ', 'Martinique'),
                              (b'MR', 'Mauretanien'),
                              (b'MU', 'Mauritius'),
                              (b'YT', 'Mayotte'),
-                                                      (b'MX', 'Mexiko'), (b'FM',
-                                                                          'Mikronesien, F\xf6derierte Staaten von'),
+                             (b'MX', 'Mexiko'),
+                             (b'FM', 'Mikronesien, F\xf6derierte Staaten von'),
                              (b'MD', 'Moldawien'),
                              (b'MC', 'Monaco'),
                              (b'MN', 'Mongolei'),
@@ -245,9 +230,8 @@ class Migration(migrations.Migration):
                              (b'NA', 'Namibia'),
                              (b'NR', 'Nauru'),
                              (b'NP', 'Nepal'),
-                                                      (b'NL', 'Niederlande'), (
-                                                          b'AN',
-                                                          'Niederl\xe4ndische Antillen'),
+                             (b'NL', 'Niederlande'),
+                             (b'AN', 'Niederl\xe4ndische Antillen'),
                              (b'NC', 'Neukaledonien'),
                              (b'NZ', 'New Zealand'),
                              (b'NI', 'Nicaragua'),
@@ -260,11 +244,10 @@ class Migration(migrations.Migration):
                              (b'NO', 'Norwegen'),
                              (b'OM', 'Oman'),
                              (b'PK', 'Pakistan'),
-                                                      (b'PW', 'Palau'), (b'PS',
-                                                                         'Pal\xe4stinensische Autonomiegebiete'),
-                                                      (b'PA', 'Panama'), (
-                                                          b'PG',
-                                                          'Papua-Neuguinea'),
+                             (b'PW', 'Palau'),
+                             (b'PS', 'Pal\xe4stinensische Autonomiegebiete'),
+                             (b'PA', 'Panama'),
+                             (b'PG', 'Papua-Neuguinea'),
                              (b'PY', 'Paraguay'),
                              (b'PE', 'Peru'),
                              (b'PH', 'Philippinen'),
@@ -272,26 +255,21 @@ class Migration(migrations.Migration):
                              (b'PL', 'Polen'),
                              (b'PT', 'Portugal'),
                              (b'PR', 'Puerto Rico'),
-                                                      (b'QA', 'Katar'), (b'RE',
-                                                                         'Wiedervereinigung'),
-                                                      (b'RO', 'Rum\xe4nien'), (
-                                                          b'RU',
-                                                          'Russischen F\xf6deration'),
-                                                      (b'RW', 'Ruanda'), (b'BL',
-                                                                          'Saint Barthelemy'),
-                                                      (b'SH', 'Saint Helena'), (
-                                                          b'KN',
-                                                          'Saint Kitts und Nevis'),
+                             (b'QA', 'Katar'),
+                             (b'RE', 'Wiedervereinigung'),
+                             (b'RO', 'Rum\xe4nien'),
+                             (b'RU', 'Russischen F\xf6deration'),
+                             (b'RW', 'Ruanda'),
+                             (b'BL', 'Saint Barthelemy'),
+                             (b'SH', 'Saint Helena'),
+                             (b'KN', 'Saint Kitts und Nevis'),
                              (b'LC', 'Santa Lucia'),
-                                                      (b'MF', 'Santa Martin'), (
-                                                          b'PM',
-                                                          'Saint Pierre und Miquelon'),
-                                                      (b'VC',
-                                                       'Saint Vincent und die Grenadinen'),
+                             (b'MF', 'Santa Martin'),
+                             (b'PM', 'Saint Pierre und Miquelon'),
+                             (b'VC', 'Saint Vincent und die Grenadinen'),
                              (b'WS', 'Samoa'),
-                                                      (b'SM', 'San Marino'), (
-                                                          b'ST',
-                                                          'Sao Tome und Principe'),
+                             (b'SM', 'San Marino'),
+                             (b'ST', 'Sao Tome und Principe'),
                              (b'SA', 'Saudi-Arabien'),
                              (b'SN', 'Senegal'),
                              (b'RS', 'Serbien'),
@@ -302,56 +280,46 @@ class Migration(migrations.Migration):
                              (b'SI', 'Slowenien'),
                              (b'SB', 'Salomon-Inseln'),
                              (b'SO', 'Somalia'),
-                                                      (b'ZA', 'S\xfcdafrika'), (
-                                                          b'GS',
+                             (b'ZA', 'S\xfcdafrika'),
+                             (b'GS',
                               'S\xfcdgeorgien und die S\xfcdlichen Sandwichinseln'),
                              (b'ES', 'Spanien'),
                              (b'LK', 'Sri Lanka'),
                              (b'SD', 'Sudan'),
-                                                      (b'SR', 'Suriname'), (
-                                                          b'SJ',
-                                                          'Svalbard und Jan Mayen'),
+                             (b'SR', 'Suriname'),
+                             (b'SJ', 'Svalbard und Jan Mayen'),
                              (b'SZ', 'Swaziland'),
                              (b'SE', 'Schweden'),
-                                                      (b'CH', 'Schweiz'), (
-                                                          b'SY',
-                                                          'Arabische Republik Syrien'),
+                             (b'CH', 'Schweiz'),
+                             (b'SY', 'Arabische Republik Syrien'),
                              (b'TW',
                               'Taiwan, Province of China'),
                              (b'TJ', 'Tadschikistan'),
-                                                      (b'TZ',
-                                                       'Tansania, Vereinigte Republik'),
+                             (b'TZ', 'Tansania, Vereinigte Republik'),
                              (b'TH', 'Thailand'),
                              (b'TL', 'Timor-Leste'),
                              (b'TG', 'Togo'),
                              (b'TK', 'Tokelau'),
-                                                      (b'TO', 'Tonga'), (b'TT',
-                                                                         'Trinidad und Tobago'),
+                             (b'TO', 'Tonga'),
+                             (b'TT', 'Trinidad und Tobago'),
                              (b'TN', 'Tunesien'),
                              (b'TR', 'T\xfcrkei'),
-                                                      (b'TM', 'Turkmenistan'), (
-                                                          b'TC',
-                                                          'Turks-und Caicosinseln'),
+                             (b'TM', 'Turkmenistan'),
+                             (b'TC', 'Turks-und Caicosinseln'),
                              (b'TV', 'Tuvalu'),
                              (b'UG', 'Uganda'),
-                                                      (b'UA', 'Ukraine'), (
-                                                          b'AE',
-                                                          'Vereinigte Arabische Emirate'),
-                                                      (b'US',
-                                                       'Vereinigte Staaten'), (
-                                                          b'UM',
-                                                          'United States Minor Outlying Islands'),
+                             (b'UA', 'Ukraine'),
+                             (b'AE', 'Vereinigte Arabische Emirate'),
+                             (b'US', 'Vereinigte Staaten'),
+                             (b'UM', 'United States Minor Outlying Islands'),
                              (b'UY', 'Uruguay'),
                              (b'UZ', 'Usbekistan'),
                              (b'VU', 'Vanuatu'),
                              (b'VE', 'Venezuela'),
-                                                      (b'VN', 'Vietnam'), (
-                                                          b'VG',
-                                                          'Virgin Islands, British'),
-                                                      (b'VI',
-                                                       'Virgin Islands, US'), (
-                                                          b'WF',
-                                                          'Wallis und Futuna'),
+                             (b'VN', 'Vietnam'),
+                             (b'VG', 'Virgin Islands, British'),
+                             (b'VI', 'Virgin Islands, US'),
+                             (b'WF', 'Wallis und Futuna'),
                              (b'EH', 'Westsahara'),
                              (b'YE', 'Jemen'),
                              (b'ZM', 'Sambia'),

src/events/migrations/0002_auto_20150818_2139.py

@@ -5,7 +5,6 @@ from django.db import models, migrations
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('events', '0001_initial'),
     ]
@@ -25,6 +24,9 @@ class Migration(migrations.Migration):
             model_name='event',
             name='mahjong_tournament',
             field=models.BooleanField(
-                default=False, help_text='Diese Veranstaltung ist ein Turnier, es gelten andere Regeln f\xfcr das Kyu Ranking.', verbose_name='Mahjong Tournament'),
+                default=False,
+                help_text='Diese Veranstaltung ist ein Turnier, ' +
+                          'es gelten andere Regeln f\xfcr das Kyu Ranking.',
+                verbose_name='Mahjong Tournament'),
         ),
     ]

src/events/migrations/0003_auto_20150823_2232.py

@@ -5,7 +5,6 @@ from django.db import models, migrations
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('events', '0002_auto_20150818_2139'),
     ]
@@ -15,6 +14,9 @@ class Migration(migrations.Migration):
             model_name='event',
             name='mahjong_tournament',
             field=models.BooleanField(
-                default=False, help_text='Diese Veranstaltung ist ein Turnier, es gelten andere Regeln f\xfcr das Kyu Ranking.', verbose_name='Mahjong Turnier'),
+                default=False,
+                help_text='Diese Veranstaltung ist ein Turnier, ' +
+                          'es gelten andere Regeln f\xfcr das Kyu Ranking.',
+                verbose_name='Mahjong Turnier'),
         ),
     ]

src/events/migrations/0004_auto_20150901_2204.py

@@ -32,12 +32,14 @@ class Migration(migrations.Migration):
                 ('description', models.TextField(max_length=300,
                                                  verbose_name='Beschreibung',
                                                  blank=True)),
-                ('on_startpage', models.BooleanField(default=False,
+                ('on_startpage', models.BooleanField(
+                    default=False,
                     help_text='Display this Photo on the Startpage Teaser',
                     verbose_name='Startpage')),
                 ('created_date',
                  models.DateTimeField(verbose_name='Published on')),
-                ('views', models.PositiveIntegerField(default=0,
+                ('views', models.PositiveIntegerField(
+                    default=0,
                     verbose_name='Number of views',
                     editable=False)),
             ],
@@ -67,7 +69,9 @@ class Migration(migrations.Migration):
             field=models.ForeignKey(
                 on_delete=django.db.models.deletion.SET_NULL, blank=True,
                 to='events.Event',
-                help_text='Wenn dieser Termin zu einer Veranstaltungsreihe geh\xf6rt werden Ort, Beschreibung, Bild und Homepage von dem hier angegebenen Event \xfcbernommen.',
+                help_text='Wenn dieser Termin zu einer Veranstaltungsreihe geh\xf6rt ' +
+                          'werden Ort, Beschreibung, Bild und Homepage von dem hier ' +
+                          'angegebenen Event \xfcbernommen.',
                 null=True, verbose_name='Veranstaltungsreihen'),
         ),
         migrations.AlterField(

src/events/migrations/0005_auto_20150907_2021.py

@@ -5,7 +5,6 @@ from django.db import models, migrations
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('events', '0004_auto_20150901_2204'),
     ]
@@ -15,6 +14,7 @@ class Migration(migrations.Migration):
             model_name='photo',
             name='on_startpage',
             field=models.BooleanField(
-                default=False, help_text='Display this Photo on the Startpage Teaser', db_index=True, verbose_name='Startpage'),
+                default=False, help_text='Display this Photo on the Startpage Teaser',
+                db_index=True, verbose_name='Startpage'),
         ),
     ]

src/events/migrations/0006_auto_20160916_1800.py

@@ -5,7 +5,6 @@ from django.db import migrations, models
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('events', '0005_auto_20150907_2021'),
     ]
@@ -14,7 +13,8 @@ class Migration(migrations.Migration):
         migrations.AlterModelOptions(
             name='photo',
             options={'ordering': ['created_date'], 'get_latest_by': 'created_date',
-                     'verbose_name': 'Veranstaltungsbild', 'verbose_name_plural': 'Veranstaltungsbilder'},
+                     'verbose_name': 'Veranstaltungsbild',
+                     'verbose_name_plural': 'Veranstaltungsbilder'},
         ),
         migrations.AlterField(
             model_name='event',
@@ -31,7 +31,9 @@ class Migration(migrations.Migration):
             model_name='photo',
             name='on_startpage',
             field=models.BooleanField(
-                default=False, help_text='Foto als Teaser auf der Startseite verwenden.', db_index=True, verbose_name='Startseite'),
+                default=False,
+                help_text='Foto als Teaser auf der Startseite verwenden.',
+                db_index=True, verbose_name='Startseite'),
         ),
         migrations.AlterField(
             model_name='photo',

src/events/migrations/0007_auto_20161012_2224.py

@@ -3,11 +3,10 @@ from __future__ import unicode_literals
 
 from django.db import migrations, models
 import datetime
-from django.utils.timezone import utc
+from datetime import timezone
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('events', '0006_auto_20160916_1800'),
     ]
@@ -17,39 +16,45 @@ class Migration(migrations.Migration):
             model_name='event',
             name='date_created',
             field=models.DateTimeField(
-                auto_now_add=True, null=True, verbose_name='first created at', db_index=True),
+                auto_now_add=True, null=True, verbose_name='first created at',
+                db_index=True),
         ),
         migrations.AddField(
             model_name='event',
             name='date_modified',
             field=models.DateTimeField(default=datetime.datetime(
-                2016, 10, 12, 20, 24, 39, 910492, tzinfo=utc), verbose_name='latest updated at', auto_now=True),
+                2016, 10, 12, 20, 24, 39, 910492, tzinfo=timezone.utc),
+                verbose_name='latest updated at', auto_now=True),
             preserve_default=False,
         ),
         migrations.AddField(
             model_name='location',
             name='date_created',
             field=models.DateTimeField(
-                auto_now_add=True, null=True, verbose_name='first created at', db_index=True),
+                auto_now_add=True, null=True, verbose_name='first created at',
+                db_index=True),
         ),
         migrations.AddField(
             model_name='location',
             name='date_modified',
             field=models.DateTimeField(default=datetime.datetime(
-                2016, 10, 12, 20, 24, 44, 566305, tzinfo=utc), verbose_name='latest updated at', auto_now=True),
+                2016, 10, 12, 20, 24, 44, 566305, tzinfo=timezone.utc),
+                verbose_name='latest updated at', auto_now=True),
             preserve_default=False,
         ),
         migrations.AddField(
             model_name='photo',
             name='date_created',
             field=models.DateTimeField(
-                auto_now_add=True, null=True, verbose_name='first created at', db_index=True),
+                auto_now_add=True, null=True, verbose_name='first created at',
+                db_index=True),
         ),
         migrations.AddField(
             model_name='photo',
             name='date_modified',
             field=models.DateTimeField(default=datetime.datetime(
-                2016, 10, 12, 20, 24, 50, 509970, tzinfo=utc), verbose_name='latest updated at', auto_now=True),
+                2016, 10, 12, 20, 24, 50, 509970, tzinfo=timezone.utc),
+                verbose_name='latest updated at', auto_now=True),
             preserve_default=False,
         ),
     ]

src/events/migrations/0009_auto_20171214_1215.py

@@ -8,7 +8,6 @@ import django.db.models.deletion
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('events', '0008_auto_20171115_0653'),
     ]
@@ -17,16 +16,19 @@ class Migration(migrations.Migration):
         migrations.AlterField(
             model_name='event',
             name='location',
-            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, to='events.Location'),
+            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT,
+                                    to='events.Location'),
         ),
         migrations.AlterField(
             model_name='photo',
             name='event',
-            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, to='events.Event'),
+            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT,
+                                    to='events.Event'),
         ),
         migrations.AlterField(
             model_name='photo',
             name='photographer',
-            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, to=settings.AUTH_USER_MODEL),
+            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT,
+                                    to=settings.AUTH_USER_MODEL),
         ),
     ]

src/events/migrations/0010_auto_20190106_1954.py

@@ -0,0 +1,158 @@
+# Generated by Django 2.1.5 on 2019-01-06 18:54
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ('events', '0009_auto_20171214_1215'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='event',
+            name='date_created',
+            field=models.DateTimeField(auto_now_add=True, db_index=True, null=True,
+                                       verbose_name='erstellt am'),
+        ),
+        migrations.AlterField(
+            model_name='event',
+            name='date_modified',
+            field=models.DateTimeField(auto_now=True,
+                                       verbose_name='letzte Aktualisierung am'),
+        ),
+        migrations.AlterField(
+            model_name='location',
+            name='country',
+            field=models.CharField(
+                choices=[('GB', 'United Kingdom'), ('AF', 'Afghanistan'),
+                         ('AX', 'Aland Islands'), ('AL', 'Albania'), ('DZ', 'Algeria'),
+                         ('AS', 'American Samoa'), ('AD', 'Andorra'), ('AO', 'Angola'),
+                         ('AI', 'Anguilla'), ('AQ', 'Antarctica'),
+                         ('AG', 'Antigua and Barbuda'), ('AR', 'Argentina'),
+                         ('AM', 'Armenia'), ('AW', 'Aruba'), ('AU', 'Australia'),
+                         ('AT', 'Austria'), ('AZ', 'Azerbaijan'), ('BS', 'Bahamas'),
+                         ('BH', 'Bahrain'), ('BD', 'Bangladesh'), ('BB', 'Barbados'),
+                         ('BY', 'Belarus'), ('BE', 'Belgium'), ('BZ', 'Belize'),
+                         ('BJ', 'Benin'), ('BM', 'Bermuda'), ('BT', 'Bhutan'),
+                         ('BO', 'Bolivia'), ('BA', 'Bosnia and Herzegovina'),
+                         ('BW', 'Botswana'), ('BV', 'Bouvet Island'), ('BR', 'Brazil'),
+                         ('IO', 'British Indian Ocean Territory'),
+                         ('BN', 'Brunei Darussalam'), ('BG', 'Bulgaria'),
+                         ('BF', 'Burkina Faso'), ('BI', 'Burundi'), ('KH', 'Cambodia'),
+                         ('CM', 'Cameroon'), ('CA', 'Canada'), ('CV', 'Cape Verde'),
+                         ('KY', 'Cayman Islands'), ('CF', 'Central African Republic'),
+                         ('TD', 'Chad'), ('CL', 'Chile'), ('CN', 'China'),
+                         ('CX', 'Christmas Island'), ('CC', 'Cocos (Keeling) Islands'),
+                         ('CO', 'Colombia'), ('KM', 'Comoros'), ('CG', 'Congo'),
+                         ('CD', 'Congo, The Democratic Republic of the'),
+                         ('CK', 'Cook Islands'), ('CR', 'Costa Rica'),
+                         ('CI', "Cote d'Ivoire"), ('HR', 'Croatia'), ('CU', 'Cuba'),
+                         ('CY', 'Cyprus'), ('CZ', 'Czech Republic'), ('DK', 'Denmark'),
+                         ('DJ', 'Djibouti'), ('DM', 'Dominica'),
+                         ('DO', 'Dominican Republic'), ('EC', 'Ecuador'),
+                         ('EG', 'Egypt'), ('SV', 'El Salvador'),
+                         ('GQ', 'Equatorial Guinea'), ('ER', 'Eritrea'),
+                         ('EE', 'Estonia'), ('ET', 'Ethiopia'),
+                         ('FK', 'Falkland Islands (Malvinas)'), ('FO', 'Faroe Islands'),
+                         ('FJ', 'Fiji'), ('FI', 'Finland'), ('FR', 'France'),
+                         ('GF', 'French Guiana'), ('PF', 'French Polynesia'),
+                         ('TF', 'French Southern Territories'), ('GA', 'Gabon'),
+                         ('GM', 'Gambia'), ('GE', 'Georgia'), ('DE', 'Germany'),
+                         ('GH', 'Ghana'), ('GI', 'Gibraltar'), ('GR', 'Greece'),
+                         ('GL', 'Greenland'), ('GD', 'Grenada'), ('GP', 'Guadeloupe'),
+                         ('GU', 'Guam'), ('GT', 'Guatemala'), ('GG', 'Guernsey'),
+                         ('GN', 'Guinea'), ('GW', 'Guinea-Bissau'), ('GY', 'Guyana'),
+                         ('HT', 'Haiti'), ('HM', 'Heard Island and McDonald Islands'),
+                         ('VA', 'Holy See (Vatican City State)'), ('HN', 'Honduras'),
+                         ('HK', 'Hong Kong'), ('HU', 'Hungary'), ('IS', 'Iceland'),
+                         ('IN', 'India'), ('ID', 'Indonesia'),
+                         ('IR', 'Iran, Islamic Republic of'), ('IQ', 'Iraq'),
+                         ('IE', 'Ireland'), ('IM', 'Isle of Man'), ('IL', 'Israel'),
+                         ('IT', 'Italy'), ('JM', 'Jamaica'), ('JP', 'Japan'),
+                         ('JE', 'Jersey'), ('JO', 'Jordan'), ('KZ', 'Kazakhstan'),
+                         ('KE', 'Kenya'), ('KI', 'Kiribati'),
+                         ('KP', "Korea, Democratic People's Republic of"),
+                         ('KR', 'Korea, Republic of'), ('KW', 'Kuwait'),
+                         ('KG', 'Kyrgyzstan'),
+                         ('LA', "Lao People's Democratic Republic"), ('LV', 'Latvia'),
+                         ('LB', 'Lebanon'), ('LS', 'Lesotho'), ('LR', 'Liberia'),
+                         ('LY', 'Libyan Arab Jamahiriya'), ('LI', 'Liechtenstein'),
+                         ('LT', 'Lithuania'), ('LU', 'Luxembourg'), ('MO', 'Macao'),
+                         ('MK', 'Macedonia, The Former Yugoslav Republic of'),
+                         ('MG', 'Madagascar'), ('MW', 'Malawi'), ('MY', 'Malaysia'),
+                         ('MV', 'Maldives'), ('ML', 'Mali'), ('MT', 'Malta'),
+                         ('MH', 'Marshall Islands'), ('MQ', 'Martinique'),
+                         ('MR', 'Mauritania'), ('MU', 'Mauritius'), ('YT', 'Mayotte'),
+                         ('MX', 'Mexico'), ('FM', 'Micronesia, Federated States of'),
+                         ('MD', 'Moldova'), ('MC', 'Monaco'), ('MN', 'Mongolia'),
+                         ('ME', 'Montenegro'), ('MS', 'Montserrat'), ('MA', 'Morocco'),
+                         ('MZ', 'Mozambique'), ('MM', 'Myanmar'), ('NA', 'Namibia'),
+                         ('NR', 'Nauru'), ('NP', 'Nepal'), ('NL', 'Netherlands'),
+                         ('AN', 'Netherlands Antilles'), ('NC', 'New Caledonia'),
+                         ('NZ', 'New Zealand'), ('NI', 'Nicaragua'), ('NE', 'Niger'),
+                         ('NG', 'Nigeria'), ('NU', 'Niue'), ('NF', 'Norfolk Island'),
+                         ('MP', 'Northern Mariana Islands'), ('NO', 'Norway'),
+                         ('OM', 'Oman'), ('PK', 'Pakistan'), ('PW', 'Palau'),
+                         ('PS', 'Palestinian Territory, Occupied'), ('PA', 'Panama'),
+                         ('PG', 'Papua New Guinea'), ('PY', 'Paraguay'), ('PE', 'Peru'),
+                         ('PH', 'Philippines'), ('PN', 'Pitcairn'), ('PL', 'Poland'),
+                         ('PT', 'Portugal'), ('PR', 'Puerto Rico'), ('QA', 'Qatar'),
+                         ('RE', 'Reunion'), ('RO', 'Romania'),
+                         ('RU', 'Russian Federation'), ('RW', 'Rwanda'),
+                         ('BL', 'Saint Barthelemy'), ('SH', 'Saint Helena'),
+                         ('KN', 'Saint Kitts and Nevis'), ('LC', 'Saint Lucia'),
+                         ('MF', 'Saint Martin'), ('PM', 'Saint Pierre and Miquelon'),
+                         ('VC', 'Saint Vincent and the Grenadines'), ('WS', 'Samoa'),
+                         ('SM', 'San Marino'), ('ST', 'Sao Tome and Principe'),
+                         ('SA', 'Saudi Arabia'), ('SN', 'Senegal'), ('RS', 'Serbia'),
+                         ('SC', 'Seychelles'), ('SL', 'Sierra Leone'),
+                         ('SG', 'Singapore'), ('SK', 'Slovakia'), ('SI', 'Slovenia'),
+                         ('SB', 'Solomon Islands'), ('SO', 'Somalia'),
+                         ('ZA', 'South Africa'),
+                         ('GS', 'South Georgia and the South Sandwich Islands'),
+                         ('ES', 'Spain'), ('LK', 'Sri Lanka'), ('SD', 'Sudan'),
+                         ('SR', 'Suriname'), ('SJ', 'Svalbard and Jan Mayen'),
+                         ('SZ', 'Swaziland'), ('SE', 'Sweden'), ('CH', 'Switzerland'),
+                         ('SY', 'Syrian Arab Republic'),
+                         ('TW', 'Taiwan, Province of China'), ('TJ', 'Tajikistan'),
+                         ('TZ', 'Tanzania, United Republic of'), ('TH', 'Thailand'),
+                         ('TL', 'Timor-Leste'), ('TG', 'Togo'), ('TK', 'Tokelau'),
+                         ('TO', 'Tonga'), ('TT', 'Trinidad and Tobago'),
+                         ('TN', 'Tunisia'), ('TR', 'Turkey'), ('TM', 'Turkmenistan'),
+                         ('TC', 'Turks and Caicos Islands'), ('TV', 'Tuvalu'),
+                         ('UG', 'Uganda'), ('UA', 'Ukraine'),
+                         ('AE', 'United Arab Emirates'), ('US', 'United States'),
+                         ('UM', 'United States Minor Outlying Islands'),
+                         ('UY', 'Uruguay'), ('UZ', 'Uzbekistan'), ('VU', 'Vanuatu'),
+                         ('VE', 'Venezuela'), ('VN', 'Viet Nam'),
+                         ('VG', 'Virgin Islands, British'),
+                         ('VI', 'Virgin Islands, U.S.'), ('WF', 'Wallis and Futuna'),
+                         ('EH', 'Western Sahara'), ('YE', 'Yemen'), ('ZM', 'Zambia'),
+                         ('ZW', 'Zimbabwe')], max_length=2, verbose_name='Land'),
+        ),
+        migrations.AlterField(
+            model_name='location',
+            name='date_created',
+            field=models.DateTimeField(auto_now_add=True, db_index=True, null=True,
+                                       verbose_name='erstellt am'),
+        ),
+        migrations.AlterField(
+            model_name='location',
+            name='date_modified',
+            field=models.DateTimeField(auto_now=True,
+                                       verbose_name='letzte Aktualisierung am'),
+        ),
+        migrations.AlterField(
+            model_name='photo',
+            name='date_created',
+            field=models.DateTimeField(auto_now_add=True, db_index=True, null=True,
+                                       verbose_name='erstellt am'),
+        ),
+        migrations.AlterField(
+            model_name='photo',
+            name='date_modified',
+            field=models.DateTimeField(auto_now=True,
+                                       verbose_name='letzte Aktualisierung am'),
+        ),
+    ]

src/events/mixins.py

@@ -1,6 +1,10 @@
 """Mixins for Events."""
+from django.core.exceptions import ImproperlyConfigured
+from django.db.models import Q
 from django.http import Http404
 from django.shortcuts import get_object_or_404
+from django.utils.translation import gettext as _
+
 from . import models
 
 
@@ -29,19 +33,19 @@ class EventDetailMixin(object):
     event = None
 
     def get_context_data(self, **kwargs):
-        """Add self.event or the related event of self.object to the template
-        context.
+        """Adds this  or the related event of the given object to the
+        template context.
 
         :return: TemplateContext object"""
         context = super(EventDetailMixin, self).get_context_data(**kwargs)
-        if hasattr(self, 'event'):
+        if getattr(self, 'event'):
             context['event'] = self.event
-        elif hasattr(self, 'object') and isinstance(self.object, models.Event):
+        elif isinstance(getattr(self, 'object'), models.Event):
             context['event'] = self.object
-        elif hasattr(self, 'object') and hasattr(self.object, 'event'):
+        elif getattr(getattr(self, 'object'), 'event'):
             context['event'] = self.object.event
         else:
-            print("No Event in Context!")
+            raise ImproperlyConfigured("No Event in Context!")
         return context
 
     def get_queryset(self):
@@ -52,8 +56,32 @@ class EventDetailMixin(object):
         """
         if self.model == models.Event:
             self.event = get_object_or_404(models.Event, pk=self.kwargs['pk'])
-            queryset = self.model.objects.all()
-        else:
-            self.event = get_object_or_404(models.Event, pk=self.kwargs['event'])
+            queryset = self.model._default_manager.all()
+        elif self.kwargs.get('event'):
+            self.event = get_object_or_404(
+                models.Event,
+                pk=self.kwargs['event'])
             queryset = self.model.objects.filter(event=self.event)
+        elif self.model:
+            queryset = self.model._default_manager.all()
+        else:
+            raise ImproperlyConfigured(
+                "%(cls)s is missing a QuerySet. Define "
+                "%(cls)s.model, %(cls)s.queryset, or override "
+                "%(cls)s.get_queryset()." % {
+                    'cls': self.__class__.__name__
+                })
         return queryset.prefetch_related()
+
+
+class EventPhotoMixin(EventDetailMixin):
+
+    def get_queryset(self):
+        try:
+            self.event = models.Event.objects.get(id=self.kwargs['event'])
+            return models.Photo.objects.filter(
+                Q(event=self.event) |
+                Q(event__event_series=self.event)
+            )
+        except models.Event.DoesNotExist:
+            raise Http404(_('Event does not exist'))

src/events/models.py

@@ -1,4 +1,4 @@
-"""Models to solitary events, events series with an location and photos."""
+"""Models to solitary events, events series with a location and photos."""
 import os
 
 from ckeditor.fields import RichTextField
@@ -9,21 +9,22 @@ from django.db.models import Q
 from django.template.defaultfilters import slugify
 from django.urls import reverse
 from django.utils.timezone import now
-from django.utils.translation import ugettext as _
+from django.utils.translation import gettext as _
 from easy_thumbnails.fields import ThumbnailerImageField
 
 from utils import COUNTRIES, OverwriteStorage
 from .managers import EventManager
 
 
-def get_upload_path(instance, filename):
+def get_upload_path(instance: models.Model, filename: str) -> str:
     """
     Generates the desired file path and filename for an uploaded Image.
-    With this function Django can save the uploaded images to subfolders that
+    With this function Django can save the uploaded images to a subfolder that
     also have a meaning for humans.
 
-    @param instance: an Django Object for which the Image has been uploaded.
-    @type instance: a instace of an models.Model sub-class.
+    @return: String: path for the image.
+    @param instance: a Django Object for which the Image has been uploaded.
+    @type instance: an instance of a models.Model subclass.
     @param filename: The filename of the uploaded image.
     @type filename: String
     """
@@ -48,7 +49,7 @@ def get_upload_path(instance, filename):
 
 
 class Event(models.Model):
-    """An Event that could be a tournament, a game session, or an convention."""
+    """An Event that could be a tournament, a game session, or a convention."""
     name = models.CharField(_('Name'), max_length=255)
     description = RichTextField(_("Description"), blank=True)
     location = models.ForeignKey('Location', on_delete=models.PROTECT)
@@ -108,7 +109,7 @@ class Event(models.Model):
         try:
             return "%(name)s (%(date)s)" % {'name': self.name,
                                             'date': self.start.date()}
-        except:
+        except AttributeError:
             return "New Event Model"
 
     def clean(self):
@@ -131,7 +132,7 @@ class Event(models.Model):
             'year': self.start.strftime('%Y'),
             'month': self.start.strftime('%m')
         }
-        return reverse('eventseries-form', kwargs=kwargs)
+        return reverse('event-series-form', kwargs=kwargs)
 
     def get_edit_url(self):
         kwargs = {
@@ -167,7 +168,7 @@ class Event(models.Model):
         self.photo_count = self.photo_set.count()
         super(Event, self).save(**kwargs)
 
-        # Update the Hanchans if necesery:
+        # Update the Hanchans if necessary:
         for hanchan in self.hanchan_set.all():
             hanchan.save()
 
@@ -267,7 +268,7 @@ class Photo(models.Model):
         return os.path.basename(self.image.name)
 
     def rotate(self, rotate):
-        # TODO: Eine vernüftigte Methode ohne viele Abhängigkeiten finden um
+        # TODO: Eine vernünftige Methode ohne viele Abhängigkeiten finden um
         # die Bilder bei Bedarf zu drehen.
         if rotate == 'clockwise':
             pass

src/events/sitemaps.py

@@ -1,16 +1,16 @@
-"""To geneate a Sitemap with all events."""
 from kasu.sitemaps import GenericSitemap
-from django.utils import timezone
 from .models import Event
 
 
 class EventSitemap(GenericSitemap):
     """sitemap to help indexing all events on this site."""
-    changefreq = "never"
-    protocol = 'https'
-    priority_field = 'start'
+    changefreq: str = "never"
+    protocol: str = 'https'
+    priority_field: str = 'start'
 
     @staticmethod
-    def items():
-        """add all upcoming and archived events to the sitemap."""
+    def items(**kwargs) -> Event:
+        """add all upcoming and archived events to the sitemap.
+        @param **kwargs:
+        """
         return Event.objects.all()

src/events/templates/events/event_archive.html

@@ -40,7 +40,7 @@
     <h4><a href="{{ event.get_absolute_url }}">{{ event.name }}</a></h4>
     <p>
         <span class="fa fa-calendar-o" title="{% trans 'Date' %}" aria-label="{% trans 'Date' %}"></span>
-        <time datetime="{{event.start|date:'c'}}">
+        <time datetime="{{event.start|date:'Y-m-d\TH:i:sO'}}">
            {{ event.start|date:'D' }}
            {{ event.start|date:'SHORT_DATE_FORMAT' }} {{hanchan.start|time:'H:i'}}
         </time>
@@ -66,4 +66,5 @@
 </div>
 {% endfor %}
 {% endfor %}
+{% block form %}{% endblock %}
 {% endblock %}

src/events/templates/events/event_form.html

@@ -10,7 +10,7 @@
 {% include "form.html" %}
 {% if event.id and event.event_set.count %}
 <p class="warning">
- <strong>Achtung! Das ist eine Veranstaltungsreihe!</strong> Diese kann man im Moment nur im Admin-Interface vernünfig bearbeiten.<br />
+ <strong>Achtung! Das ist eine Veranstaltungsreihe!</strong> Diese kann man im Moment nur im Admin-Interface vernünftig bearbeiten.<br />
  Du bearbeitest hier den "Hauptevent" der Reihe ({{event.event_set.count}}). Alle Änderungen (abgesehen von Name, Start und Ende) werden von den darauf folgendem Veranstaltungen übernommen.  
 </p>
 {% endif %}

src/events/templates/events/event_list.html

@@ -20,7 +20,7 @@
             <h4><a href="{{ event.get_absolute_url }}">{{ event.name }}</a></h4>
             <ul class="info">
                 <li><span class="fa fa-calendar-o" title="{% trans 'Date' %}" aria-label="{% trans 'Date' %}"></span>
-                    <time datetime="{{event.start|date:'c'}}">
+                    <time datetime="{{event.start|date:'Y-m-d\TH:i:sO'}}">
                         {{ event.start|date:'D' }}
                         {{ event.start|date:'SHORT_DATE_FORMAT' }}
                     </time>

src/events/templates/events/photo_confirm_delete.html

@@ -5,7 +5,7 @@
 <form action="" method="post" class="grid_12">
     {% csrf_token %}
     <header>
-        <h1 class="grid_12">Dieses Photo wirklich löschen?</h1>
+        <h1 class="grid_12">Dieses Foto wirklich löschen?</h1>
     </header>
     <p>Sind Sie sicher, dass Sie das Bild &ldquo;{{photo.name}}&rdquo; löschen wollen?</p>
     <img src="{{photo.image|thumbnail_url:'display'}}" alt="{{photo.name}}" title="{{photo.name}}" class="grid_10 push_1"/>

src/events/templates/events/photo_detail.html

@@ -59,9 +59,6 @@ if ($('a.next').attr('href')) {
     <a class="button" href="http://facebook.com/sharer.php?u=http%3A%2F%2Fwww.kasu.at{{photo.get_absolute_url|urlencode}}" target="_blank" rel="nofollow">
         <span class="fa fa-twitter"></span>Facebook
     </a>
-    <a class="button" href="https://m.google.com/app/plus/x/?v=compose&amp;content={{photo.headline|urlencode}}+-+http%3A%2F%2Fwww.kasu.at/{{photo.get_absolute_url|urlencode}}" target="_blank" rel="nofollow">
-        <span class="fa fa-google-plus"></span> Google+
-    </a>
     <a class="button" href="https://twitter.com/share?url=http%3A%2F%2Fwww.kasu.at/{{photo.get_absolute_url|urlencode}}" target='_blank' rel="nofollow">
         <span class="fa fa-twitter"></span> Twitter
     </a>

src/events/templates/events/photo_upload.html

@@ -1,46 +1,10 @@
-{% extends "base.html" %}
+{% extends "events/event_archive.html" %}
 {% load i18n comments thumbnail %}
 
-{% block maincontent %}
-  {% for event in event_list %}
- {% get_comment_count for event as comment_count %}
- {% ifchanged %}<h3 class="grid_12">{{ event.start|date:'F Y' }}</h3>{% endifchanged %}
- <div style="float:left">
-<a href="{% url 'event-photo-list' event.pk %}"><img src="{{ event.get_image|thumbnail_url:'thumbnail' }}" alt="" class="thumbnail"/></a>
-<div class="grid_4" />
-<h4><a href="{% url 'event-photo-list' event.pk %}">{{ event.name }}</a></h4>
-<div class="info">
-<span class="fa fa-calendar-o" title="{% trans 'Start' %}"></span>
-{{ event.start|date }}
-{% if event.end %}
-  {% trans "from" %} {{ event.start|time:'H:i' }} {% trans "to" %} {{ event.end|time:'H:i' }}
-{% else %}
-  {{ event.start|time:'H:i' }}
-{% endif %}
-</div>
-{% if event.description %}<p>{{event.description}}</p>{% endif %}
-<div class="info">
-<span class="fa fa-map-marker" title="{% trans 'Location' %}"></span>
-{{ event.location }}
-<span class="fa fa-comments"  title="{% trans 'Comments' %}"></span>
-<a href="{{event.get_absolute_url}}#comments">{{ comment_count }} {% trans 'Comments' %}</a>
-
-    <span class="fa fa-camera-retro" title="{% trans 'Photos' %}"></span>
-<a href="{% url 'event-photo-list' event.pk %}">{{ event.photo_count }} {% trans 'Photos' %}</a>
-</div>
-<p style="text-align:right">
-  {% if perms.events.add_photo %}
-  <a href="{% url 'event-photo-list' event.pk %}" class="button">
-      <span class="fa fa-cloud-upload"></span>
-      {%trans "Upload" %}</a>
-  {% endif %}
-</p>
-</div>
-{% endfor %}
-
+{% block bottom %}
 <form method="post" enctype="multipart/form-data">
  {% csrf_token %}
-  <fieldset class="grid_8 push_2">
+  <fieldset id="bottom_buttonbar" class="grid_12">
   <legend>Photos hochladen</legend>
   {% include "form.html" %}
   <p class="buttonbar">
@@ -52,5 +16,5 @@
  </fieldset>
  </form>
 {% endblock %}
-
-
+{% block buttonbar %}
+{% endblock %}

src/events/tests.py

@@ -1,20 +1,19 @@
 """
 This file should test the functionality of the events app using the unittest
 module. These will pass when you run "manage.py test".
-
-Usefull tests have to been written yet. sorry!
+useful tests have to be written yet. sorry!
 """
 
 from django.test import TestCase
 
 
 class EventTest(TestCase):
-    """ Here we should test the creation and modifiaction of Events. """
+    """ Here we should test the creation and modification of Events. """
 
 
 class LocationTest(TestCase):
-    """ Here we should test the creation and modifiaction of Locations. """
+    """ Here we should test the creation and modification of Locations. """
 
 
 class PhotoTest(TestCase):
-    """ Here we should test the creation and modifiaction of Photos. """
+    """ Here we should test the creation and modification of Photos. """

src/events/urls.py

@@ -1,22 +1,21 @@
 """URLS to access upcoming events and the event archive."""
-from django.conf.urls import url
+from django.urls import path
 from django.views.generic import RedirectView
 from . import views
 
 urlpatterns = [
-    url(r'^$', RedirectView.as_view(url='/events/upcoming/', permanent=True)),
-    url(r'^(?P<year>[\d]{4})/$', views.EventArchiveYear.as_view(),
+    path("", RedirectView.as_view(url='/events/upcoming/', permanent=True)),
+    path('<int:year>/', views.EventArchiveYear.as_view(), name='event-archive'),
+    path('<int:year>/<int:month>/', views.EventArchiveMonth.as_view(),
          name='event-archive'),
-    url(r'^(?P<year>[\d]{4})/(?P<month>[\d]+)/$',
-        views.EventArchiveMonth.as_view(),
-        name='event-archive'),
-    url(r'^(?P<year>[\d]{4})/(?P<month>[\d]+)/(?P<pk>[\d]+)/$',
-        views.EventDetail.as_view(), name='event-detail'),
-    url(r'^(?P<year>[\d]{4})/(?P<month>[\d]+)/(?P<pk>[\d]+)/add_dates/$',
-        views.EventSeriesForm.as_view(), name='eventseries-form'),
-    url(r'^(?P<year>[\d]{4})/(?P<month>[\d]+)/(?P<pk>[\d]+)/edit/$',
-        views.EventForm.as_view(), name='event-form'),
-    url(r'^add/$', views.EventForm.as_view(), name='event-form'),
-    url(r'^archive/$', views.EventArchiveIndex.as_view(), name='event-archive'),
-    url(r'^upcoming/$', views.UpcomingEvents.as_view(), name='upcoming-events'),
+    path('<int:year>/<int:month>/<int:pk>/', views.EventDetail.as_view(),
+         name='event-detail'),
+    path('<int:year>/<int:month>/<int:pk>/add_dates/',
+         views.EventSeriesForm.as_view(),
+         name='event-series-form'),
+    path('<int:year>/<int:month>/<int:pk>/edit/', views.EventForm.as_view(),
+         name='event-form'),
+    path('add/', views.EventForm.as_view(), name='event-form'),
+    path('archive/', views.EventArchiveIndex.as_view(), name='event-archive'),
+    path('upcoming/', views.UpcomingEvents.as_view(), name='upcoming-events'),
 ]

src/events/views.py

@@ -4,11 +4,10 @@ from datetime import timedelta
 from django.contrib.auth import get_user_model
 from django.contrib.auth.mixins import PermissionRequiredMixin
 from django.urls import reverse
-from django.db.models import Q
-from django.http import HttpResponse, Http404
-from django.shortcuts import redirect
+from django.http import HttpResponse
+from django.shortcuts import redirect, get_object_or_404
 from django.utils import timezone
-from django.utils.translation import ugettext as _
+from django.utils.translation import gettext as _
 from django.views import generic
 from extra_views import InlineFormSetView
 from icalendar import Calendar, Event
@@ -49,19 +48,16 @@ class EventDetail(mixins.EventDetailMixin, generic.DetailView):
 
 class EventForm(PermissionRequiredMixin, mixins.EventDetailMixin,
                 generic.UpdateView):
-    """Frontend formular to add or edit a Event."""
+    """Frontend formular to add or edit an Event."""
     form_class = forms.EventForm
     template_name = 'events/event_form.html'
     permission_required = 'events.add_event'
 
     def get_context_data(self, **kwargs):
-        """Dynamicle set the title to Add or Edit Event, depanding if an
-        event ID was given, or not."""
+        """sets the title to add or edit Event,
+        depending on the fact if an event ID was given."""
         context = super(EventForm, self).get_context_data(**kwargs)
-        if self.kwargs.get('pk'):
-            context['title'] = _("Edit Event")
-        else:
-            context['title'] = _("Add Event")
+        context['title'] = _("Edit Event") if self.kwargs.get('pk') else _("Add Event")
         return context
 
     def get_object(self, queryset=None):
@@ -73,19 +69,22 @@ class EventForm(PermissionRequiredMixin, mixins.EventDetailMixin,
 
 
 class EventGallery(generic.ListView):
-    """Display a overview of all event photo albums."""
+    """Display an overview of all event photo albums."""
     template_name = 'events/photo_gallery.html'
+    paginate_by = 24
+
+    def get_queryset(self):
         queryset = models.Event.objects.filter(
             start__lt=timezone.now(),
             event_series__isnull=True,
             photo_count__gt=0
         )
         queryset = queryset.order_by('-start')
-    paginate_by = 24
+        return queryset
 
 
 class EventListIcal(generic.View):
-    """Generates an returns an iCal File with all upcoming events."""
+    """Generates and returns an iCal File with all upcoming events."""
 
     def get(self, request, *args, **kwargs):
         """Add all upcoming events to an .ics file and send it."""
@@ -110,7 +109,7 @@ class EventListIcal(generic.View):
         return response
 
 
-class EventPhoto(mixins.EventDetailMixin, generic.UpdateView):
+class EventPhoto(mixins.EventPhotoMixin, generic.UpdateView):
     """Display the requested Photo and allows rotation if the user has change
     permissions."""
     form_class = forms.EditPhotoForm
@@ -127,8 +126,8 @@ class EventPhoto(mixins.EventDetailMixin, generic.UpdateView):
             return generic.UpdateView.post(self, request, *args, **kwargs)
 
 
-class EventPhotoList(mixins.EventDetailMixin, generic.ListView):
-    """List all Photos of the event or event series in an album."""
+class EventPhotoList(mixins.EventPhotoMixin, generic.ListView):
+    """List all Photos of the event or event series."""
     context_object_name = 'photo_list'
     event = None
     paginate_by = 36
@@ -139,16 +138,6 @@ class EventPhotoList(mixins.EventDetailMixin, generic.ListView):
             initial={'event': self.event, 'photographer': self.request.user})
         return context
 
-    def get_queryset(self):
-        try:
-            self.event = models.Event.objects.get(id=self.kwargs['event'])
-            return models.Photo.objects.filter(
-                Q(event=self.event) |
-                Q(event__event_series=self.event)
-            )
-        except models.Event.DoesNotExist:
-            raise Http404(_('Event does not exist'))
-
 
 class EventPhotoUpload(mixins.EventDetailMixin, generic.FormView):
     form_class = forms.PhotoUploadForm
@@ -187,20 +176,21 @@ class EventSeriesForm(mixins.EventDetailMixin, PermissionRequiredMixin,
                       InlineFormSetView):
     model = models.Event
     inline_model = models.Event
-    fk_name = 'event_series'
     fields = ('start', 'end')
     form_class = forms.EventForm
-    extra = 3
+    factory_kwargs = {'extra': 3, 'fk_name': 'event_series'}
     permission_required = 'events.add_event'
     template_name = 'events/eventseries_form.html'
 
     def get_object(self, queryset=None):
-        self.event = models.Event.objects.get(pk=self.kwargs['pk'])
+        self.event = get_object_or_404(models.Event, pk=self.kwargs['pk'])
         if self.event.event_series:
             self.event = self.event.event_series
         return self.event
 
 
 class UpcomingEvents(generic.ListView):
-    queryset = models.Event.objects.upcoming(limit=None)
     paginate_by = 16
+
+    def get_queryset(self):
+        return models.Event.objects.upcoming(limit=None)

src/kasu/locale/de/LC_MESSAGES/django.po

@@ -7,9 +7,9 @@ msgid ""
 msgstr ""
 "Project-Id-Version: kasu.utils\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2018-05-08 00:17+0200\n"
-"PO-Revision-Date: 2016-09-28 00:24+0200\n"
-"Last-Translator: Christian Berg <xeniac.at@gmail.com>\n"
+"POT-Creation-Date: 2023-08-07 20:38+0200\n"
+"PO-Revision-Date: 2018-12-30 11:14+0105\n"
+"Last-Translator: b'  <kasu@xendynastie.at>'\n"
 "Language-Team: Kasu <verein@kasu.at>\n"
 "Language: de\n"
 "MIME-Version: 1.0\n"
@@ -17,172 +17,183 @@ msgstr ""
 "Content-Transfer-Encoding: 8bit\n"
 "Plural-Forms: nplurals=2; plural=(n != 1);\n"
 "X-Generator: Poedit 1.8.9\n"
-"X-Translated-Using: django-rosetta 0.7.6\n"
+"X-Translated-Using: django-rosetta 0.9.0\n"
 
-#: .\kasu\settings.py:141
+#: settings.py:144
 msgid "German"
 msgstr "Deutsch"
 
-#: .\kasu\settings.py:141
+#: settings.py:144
 msgid "English"
 msgstr "Englisch"
 
-#: .\kasu\templates\404.html:8
+#: templates/404.html:8
 msgid "The page your requested does not exist on this server."
 msgstr "Die angeforderte Seite existiert auf diesem Server nicht."
 
-#: .\kasu\templates\base.html:22
+#: templates/base.html:22
 msgid "Current News"
 msgstr "Aktuelle Neuigkeiten"
 
-#: .\kasu\templates\base.html:24 .\kasu\templates\index.html:40
+#: templates/base.html:24 templates/index.html:40
 msgid "Recent Comments"
 msgstr "Kürzliche Kommentare"
 
-#: .\kasu\templates\base.html:45
+#: templates/base.html:45
 msgid "Menu"
 msgstr "Menü"
 
-#: .\kasu\templates\base.html:69
+#: templates/base.html:69
 msgid "Current Event"
 msgstr "Aktuelle Veranstaltung"
 
-#: .\kasu\templates\base.html:72
+#: templates/base.html:72
 msgid "Since"
 msgstr "seit"
 
-#: .\kasu\templates\base.html:73 .\kasu\templates\base.html:87
+#: templates/base.html:73 templates/base.html:87
 msgid "Start"
 msgstr "Beginn"
 
-#: .\kasu\templates\base.html:76 .\kasu\templates\base.html:90
+#: templates/base.html:76 templates/base.html:90
 msgid "Location"
 msgstr "Ort"
 
-#: .\kasu\templates\base.html:81 .\kasu\templates\base.html:94
+#: templates/base.html:81 templates/base.html:94
 msgid "More Details"
 msgstr "Mehr Details"
 
-#: .\kasu\templates\base.html:83
+#: templates/base.html:83
 msgid "Next Event"
 msgstr "Nächste Veranstaltung"
 
-#: .\kasu\templates\base.html:86
+#: templates/base.html:86
 msgid "in"
 msgstr "in"
 
-#: .\kasu\templates\base.html:97
+#: templates/base.html:97
 msgid "Upcoming events"
 msgstr "Bevorstehende Veranstaltungen"
 
-#: .\kasu\templates\base.html:147
+#: templates/base.html:107
+msgid "No events found"
+msgstr "Keine Veranstaltungen gefunden"
+
+#: templates/base.html:150
 msgid "Add Subpage"
 msgstr "Unterseite Hinzufügen"
 
-#: .\kasu\templates\base.html:152
+#: templates/base.html:154
 msgid "Edit Page"
 msgstr "Seite bearbeiten"
 
-#: .\kasu\templates\base.html:160
+#: templates/base.html:163
 msgid "Imprint"
 msgstr "Impressum"
 
-#: .\kasu\templates\base.html:161
+#: templates/base.html:164
 msgid "contact"
 msgstr "Kontakt"
 
-#: .\kasu\templates\base.html:166
+#: templates/base.html:169
 msgid "Language"
 msgstr "Sprache"
 
-#: .\kasu\templates\base.html:175
+#: templates/base.html:178
 msgid "Go"
 msgstr "Los"
 
-#: .\kasu\templates\base.html:180
+#: templates/base.html:183
 msgid "Logged in as"
 msgstr "Angemeldet als"
 
-#: .\kasu\templates\base.html:182
+#: templates/base.html:185
 msgid "Admin"
 msgstr "Admin"
 
-#: .\kasu\templates\base.html:183
+#: templates/base.html:186
 msgid "Logout"
 msgstr "Abmelden"
 
-#: .\kasu\templates\base.html:185
+#: templates/base.html:188
 msgid "no user logged in"
 msgstr "Niemand angemeldet"
 
-#: .\kasu\templates\base.html:186 .\kasu\templates\comments\form.html:43
+#: templates/base.html:189 templates/comments/form.html:43
 msgid "register"
 msgstr "Registrieren"
 
-#: .\kasu\templates\base.html:187 .\kasu\templates\comments\form.html:44
+#: templates/base.html:190 templates/comments/form.html:44
 msgid "login"
 msgstr "anmelden"
 
-#: .\kasu\templates\comments\form.html:5
+#: templates/comments/form.html:5
 msgid "New Comment"
 msgstr "Neuer Kommentar"
 
-#: .\kasu\templates\comments\form.html:20
+#: templates/comments/form.html:20
 msgid "now"
 msgstr "Jetzt"
 
-#: .\kasu\templates\comments\form.html:25
+#: templates/comments/form.html:25
 msgid "Preview"
 msgstr "Vorschau"
 
-#: .\kasu\templates\comments\form.html:26
+#: templates/comments/form.html:26
 msgid "Post"
 msgstr "Schreiben"
 
-#: .\kasu\templates\comments\form.html:34
+#: templates/comments/form.html:34
 msgid "not logged in"
 msgstr "Nicht angemeldet"
 
-#: .\kasu\templates\comments\form.html:38
+#: templates/comments/form.html:38
 msgid "Register now, or Login to leave a comment here."
 msgstr "Jetzt registrieren, oder anmelden um einen Kommentar zu schreiben."
 
-#: .\kasu\templates\comments\list.html:2 .\kasu\templates\index.html:25
+#: templates/comments/list.html:2 templates/index.html:25
 msgid "Comments"
 msgstr "Kommentare"
 
-#: .\kasu\templates\comments\posted.html:4
-#: .\kasu\templates\comments\posted.html:7
+#: templates/comments/posted.html:4 templates/comments/posted.html:7
 msgid "Thank you for your comment"
 msgstr "Danke für deinen Kommentar."
 
-#: .\kasu\templates\comments\preview.html:4
-#: .\kasu\templates\comments\preview.html:6
+#: templates/comments/preview.html:4 templates/comments/preview.html:6
 msgid "Preview your comment"
 msgstr "Vorschau deines Kommentars"
 
-#: .\kasu\templates\comments\preview.html:10
+#: templates/comments/preview.html:10
 msgid "Please correct the error below"
 msgid_plural "Please correct the errors below"
 msgstr[0] "Bitte den Fehler weiter unten beheben"
 msgstr[1] "Bitte die Fehler weiter unten beheben"
 
-#: .\kasu\templates\index.html:4
+#: templates/index.html:4
 msgid "traditional Asian game culture"
 msgstr "traditionelle asiatische Spielkultur"
 
-#: .\kasu\templates\index.html:33
+#: templates/index.html:33
 msgid "Read More"
 msgstr "Mehr lesen"
 
-#: .\kasu\templates\index.html:47
-#, python-format
+#: templates/index.html:47
+#, fuzzy, python-format
+#| msgid ""
+#| "\n"
+#| "                From <a href=\"%(user_link)s\">%(author)s</a> in\n"
+#| "                <a href=\"%(comment_link)s\">&ldquo;%(object)s&rdquo;</"
+#| "a>\n"
+#| "                since\n"
+#| "                <time datetime=\"%(submit_date)s\">%(since)s</time>\n"
+#| "                "
 msgid ""
 "\n"
 "                From <a href=\"%(user_link)s\">%(author)s</a> in\n"
 "                <a href=\"%(comment_link)s\">&ldquo;%(object)s&rdquo;</a>\n"
 "                since\n"
-"                <time datetime=\"%(submit_date)s\">%(since)s</time>\n"
+"                <time "
+"datetime=\"%(submit_date|date:'Y-m-d\\TH:i:sO')s\">%(since)s</time>\n"
 "                "
 msgstr ""
 "\n"
@@ -192,23 +203,23 @@ msgstr ""
 "                <time datetime=\"%(submit_date)s\">%(since)s</time>\n"
 "                "
 
-#: .\kasu\templates\index.html:59
+#: templates/index.html:59
 msgid "Kasu in the social network"
 msgstr "Kasu im sozialem Netzwerk"
 
-#: .\kasu\templates\index.html:62 .\kasu\templates\index.html:65
+#: templates/index.html:62 templates/index.html:65
 msgid "Visit us on"
 msgstr "Besuche uns auf"
 
-#: .\kasu\templates\index.html:74
+#: templates/index.html:74
 msgid "Add Article"
 msgstr "Artikel hinzufügen"
 
-#: .\kasu\templates\paginator.html:8
+#: templates/paginator.html:5 templates/paginator.html:7
 msgid "Previous"
 msgstr "Vorherige"
 
-#: .\kasu\templates\paginator.html:20
+#: templates/paginator.html:17 templates/paginator.html:20
 msgid "Next"
 msgstr "Nächste"
 

src/kasu/settings.py

@@ -68,17 +68,16 @@ CACHES = {
 }
 
 # Request Middleware
-MIDDLEWARE_CLASSES = [
+MIDDLEWARE = [
     'csp.middleware.CSPMiddleware',
     'django.middleware.security.SecurityMiddleware',
     'django.contrib.sessions.middleware.SessionMiddleware',
     'django.middleware.common.CommonMiddleware',
     'django.middleware.csrf.CsrfViewMiddleware',
     'django.contrib.auth.middleware.AuthenticationMiddleware',
-    'django.contrib.auth.middleware.SessionAuthenticationMiddleware',
-    'django.middleware.locale.LocaleMiddleware',
     'django.contrib.messages.middleware.MessageMiddleware',
     'django.middleware.clickjacking.XFrameOptionsMiddleware',
+    'django.middleware.locale.LocaleMiddleware',
     'utils.middleware.SetRemoteAddrFromForwardedFor',
     'mahjong_ranking.middleware.DenormalizationUpdateMiddleware',
 ]
@@ -134,6 +133,10 @@ LOGIN_URL = '/membership/login/'
 LOGIN_ERROR_URL = '/membership/login/error/'
 LOGIN_REDIRECT_URL = '/users/'
 
+
+# Set the primarykey handing to old django style
+DEFAULT_AUTO_FIELD = 'django.db.models.AutoField'
+
 # Localization
 USE_I18N = True
 USE_L10N = True
@@ -188,7 +191,8 @@ LOGGING = {
     },
     'formatters': {
         'verbose': {
-            'format': '%(levelname)s %(asctime)s %(module)s %(process)d %(thread)d %(message)s'
+            'format': '%(levelname)s %(asctime)s %(module)s %(process)d ' +
+                      '%(thread)d %(message)s'
         },
         'simple': {
             'format': '%(levelname)s %(message)s'
@@ -272,7 +276,7 @@ KYU_RANKS = (
 )
 
 try:
-    from .local_settings import *  # Ignore PyLintBear (W0401, W0614)
+    from .local_settings import *    # noqa: F403
 except ImportError:
     pass
 

src/kasu/templates/base.html

@@ -37,7 +37,7 @@
     {% block extra_head %}{% endblock %}
     <script src="{{ STATIC_URL }}js/piwik.js"></script>
 </head>
-<body id="body" {% block itemscope %}{% endblock %}>
+<body id="body" itemscope>
     <header id="siteheader">
     <div id="sitelogo"><a href="/index.html">Kasu - traditionelle asiatische Spielkultur</a></div>
     <nav id="mainnav">
@@ -51,7 +51,7 @@
                 <ul class="main_dropdown">
                   {% for subpage in item.subpages.all %}<li><a
                   href="{{subpage.get_absolute_url}}"
-                  {% ifequal subpage current_page %}class="active"{% endifequal %}>{{subpage.menu_name}}</a></li>
+                >{{subpage.menu_name}}</a></li>
                   {% endfor %}
                 </ul>
                 {% endif %}
@@ -71,7 +71,7 @@
             <ul class="fa-ul">
                 <li><span class="fa-li fa fa-clock-o"></span><strong>{% trans "Since" %}:</strong> {{current_event.start|timesince}}</li>
                 <li><span class="fa-li fa fa-calendar"></span><strong>{% trans "Start" %}:</strong>
-                    <time datetime="{{current_event.start|date:'c'}}">{{current_event.start|date:'DATETIME_FORMAT'}}</time>
+                    <time datetime="{{current_event.start|date:'Y-m-d\TH:i:sO'}}">{{current_event.start|date:'DATETIME_FORMAT'}}</time>
                 </li>
                 <li><span class="fa-li fa fa-map-marker"></span><strong>{% trans "Location" %}:</strong> {{ current_event.location }}
                 - {{current_event.location.street_address}}, {{current_event.location.postal_code}} {{current_event.location.locality}}
@@ -79,13 +79,13 @@
             </ul>
             <div class="right"><a class="button" href="{{current_event.get_absolute_url}}">
             {% trans "More Details" %} <span class="fa fa-arrow-right"></span></a></div>
-        {% else %}
+        {% elif next_event %}
         <h2>{% trans "Next Event" %}</h2>
             <h3>{{ next_event.name}}</h3>
             <ul class="fa-ul">
                 <li><span class="fa-li fa fa-clock-o"></span><strong>{% trans "in" %}:</strong> {{next_event.start|timeuntil}}</li>
                 <li><span class="fa-li fa fa-calendar"></span><strong>{% trans "Start" %}:</strong>
-                    <time datetime="{{next_event.start|date:'c'}}">{{next_event.start|date:'DATETIME_FORMAT' }}</time>
+                    <time datetime="{{next_event.start|date:'Y-m-d\TH:i:sO'}}">{{next_event.start|date:'DATETIME_FORMAT' }}</time>
                 </li>
                 <li><span class="fa-li fa fa-map-marker"></span><strong>{% trans "Location" %}:</strong> {{ next_event.location }}
                 - {{next_event.location.street_address}}, {{next_event.location.postal_code}} {{next_event.location.locality}}
@@ -101,8 +101,10 @@
             {% for event in upcoming_events %}
             <li><span class="fa-li fa fa-calendar-o"></span>
                 <a href="{{ event.get_absolute_url}}">
-                <time datetime="{{event.start|date:'c'}}">{{event.start|date:'D d. M:'}}</time>
+                <time datetime="{{event.start|date:'Y-m-d\TH:i:sO'}}">{{event.start|date:'D d. M:'}}</time>
                 {{event.name}}</a></li>
+            {% empty %}
+            <li>{% trans 'No events found' %}.</li>
             {% endfor %}
         </ul>
         {% endblock %}
@@ -114,9 +116,9 @@
     {% block navigation %}{% if current_top_page.subpages.count %}
     <ul id="navigation">
     <li><a href="{{current_top_page.get_absolute_url}}"
-           class="{% ifequal current_page current_top_page %}{% endifequal %}">{{current_top_page.menu_name}}</a></li>
+           class="{% if current_page == current_top_page %}{% endif %}">{{current_top_page.menu_name}}</a></li>
     {% for subpage in current_top_page.subpages.all %}
-    <li><a href="{{subpage.get_absolute_url}}" class="{% ifequal subpage current_page %}active{% endifequal %}">{{subpage.menu_name}}</a>
+    <li><a href="{{subpage.get_absolute_url}}" class="{% if subpage == current_page %}active{% endif %}">{{subpage.menu_name}}</a>
     </li>
     {% endfor %}
     {% block additional_nav_elements %}{% endblock %}
@@ -140,20 +142,21 @@
     {% endblock %}
     {% block comments %}{% endblock %}
     <br class="clear"/>
-    <p id="bottom_buttonbar" class="buttonbar">
+    {% block bottom %}
+    <div id="bottom_buttonbar" class="buttonbar">
         {% block buttonbar %}
         {% if current_page and perms.content.add_page %}
             <a href="{% url 'add-page' current_page.path %}" class="button"><span class="fa fa-plus"></span>
                 {% trans "Add Subpage" %}</a>
         {% endif %}
-
         {% if current_page and perms.content.change_page %}
         <a href="{% url 'edit-page' current_page.path %}" class="button"><span class="fa fa-pencil"></span>
             {% trans "Edit Page" %}</a>
         {% endif %}
         {% block additional_buttonbar %}{% endblock %}
         {% endblock %}
-    </p>
+    </div>
+    {% endblock %}
 </main>
     <footer id="footer">
     <p><strong>Herausgeber:</strong> Verein Kasu - traditionelle asiatische Spielkultur (<a
@@ -167,8 +170,8 @@
         <select name="language" id="language">
             {% get_language_info_list for LANGUAGES as languages %}
             {% for language in languages %}
-            <option value="{{language.code}}" {% ifequal language.code LANGUAGE_CODE %}
-                    selected="selected" {% endifequal %}>{{ language.name_local }} ({{ language.code }})
+            <option value="{{language.code}}"
+                    selected="selected">{{ language.name_local }} ({{ language.code }})
             </option>
             {% endfor %}
         </select>

src/kasu/templates/comments/list.html

@@ -7,7 +7,7 @@
     </div>
     <header class="comment_header">
         <h3><a href="{{ comment.user.get_profile.get_absolute_url }}" class="user">{{comment.user}}</a></h3>
-        <time datetime="{{comment.submit_date|date:'Y-m-d'}}" class="submit_date">{{comment.submit_date|timesince}}</time>
+        <time datetime="{{comment.submit_date|date:'Y-m-d\TH:i:sO'}}" class="submit_date">{{comment.submit_date|timesince}}</time>
     </header>
     <div class="comment_text">{{comment.comment}}</div>
 </article>

src/kasu/templates/comments/preview.html

@@ -16,7 +16,7 @@
     </div>
     <header class="comment_header">
         <a href="{{ user.get_profile.get_absolute_url }}" class="user">{{comment.user}}</a>
-        <div class="submit_date"><time time="{% now 'c' %}">{% now 'DATETIME_FORMAT' %}</time></div>
+        <div class="submit_date"><time>{% now 'DATETIME_FORMAT' %}</time></div>
     </header>
     <div class="comment_text">{{comment}}</div>
 </article>

src/kasu/templates/django/forms/widgets/html5input.html

@@ -1 +1,2 @@
-<input type="{{ type|default:'text' }}" name="{{ widget.name }}"{% if widget.value != None %} value="{{ widget.value|stringformat:'s' }}"{% endif %}{% include "django/forms/widgets/attrs.html" %} />
+<input type="{{ type|default:'text' }}" name="{{ widget.name }}"
+       value="{{ widget.value|stringformat:'s' }}"     "django/forms/widgets/attrs.html" %} />

src/kasu/templates/form.html

@@ -2,7 +2,7 @@
 {% for hidden in form.hidden_fields %}{{ hidden }}{% endfor %}
 {% for field in form.visible_fields %}
 <div>
-  <label {% if field.html_name != 'recaptcha' %} for="id_{{ field.html_name}}" {% endif %}
+  <label for="id_{{ field.html_name}}"
          class="field_name {{ field.css_classes }}">{{ field.label}}</label>
   {{ field }}
   {% if field.field.widget.input_type == 'checkbox' %}

src/kasu/templates/index.html

@@ -17,7 +17,7 @@
             <h2><a href="{{article.get_absolute_url}}">{{article.headline}}</a></h2>
             <ul class="info">
                 <li><span class="fa fa-calendar"></span>
-                    <time datetime="{{article.date_created|date:'Y-m-d H:i'}}">{{ article.date_created|date:'DATE_FORMAT' }}</time>
+                    <time datetime="{{article.date_created|date:'Y-m-d\TH:i:sO'}}">{{ article.date_created|date:'DATE_FORMAT' }}</time>
                 </li>
                 <li><span class="fa fa-user"></span> {{ article.author }}
                 </li>
@@ -48,7 +48,7 @@
                 From <a href="{{user_link}}">{{author}}</a> in
                 <a href="{{comment_link}}">&ldquo;{{object}}&rdquo;</a>
                 since
-                <time datetime="{{submit_date}}">{{since}}</time>
+                <time datetime="{{submit_date|date:'Y-m-d\TH:i:sO'}}">{{since}}</time>
                 {% endblocktrans %}
             </li>
             {% endfor %}

src/kasu/templates/paginator.html

@@ -1,22 +1,22 @@
 {% load i18n %}
 <nav class="grid_12 pagination">
-    <a {% if page_obj.has_previous %}
-       class="previous" href="?page={{ page_obj.previous_page_number }}"
+    {% if page_obj.has_previous %}
+    <a class="previous" href="?page={{ page_obj.previous_page_number }}"><span class="fa fa-arrow-left"></span>
+        {% trans "Previous" %}</a>
     {% else %}
-       class="previous disabled"
-       {% endif %}>
-       <span class="fa fa-arrow-left"></span>{% trans "Previous" %}
-    </a>
-
+    <a class="previous disabled"><span class="fa fa-arrow-left"></span>{% trans "Previous" %}</a>
+    {% endif %}
     {% for page in paginator.page_range %}
-      <a {% ifequal page_obj.number page %}class="active"{% else %}href="?page={{page}}"{% endifequal %}>{{page}}</a>
-    {% endfor %}
-
-    <a {% if page_obj.has_next %}
-       class="next" href="?page={{ page_obj.next_page_number }}"
+    {% if page_obj.number == page %}
+    <a class="active">{{page}}</a>
     {% else %}
-       class="next disabled"
-       {% endif %}>
-       {% trans "Next" %} <span class="fa fa-arrow-right"></span>
-    </a>
+    <a href="?page={{page}}">{{page}}</a>
+    {% endif %}
+    {% endfor %}
+    {% if page_obj.has_next %}
+    <a class="next" href="?page={{ page_obj.next_page_number }}">{% trans "Next" %}
+        <span class="fa fa-arrow-right"></span></a>
+    {% else %}
+    <a class="next disabled">{% trans "Next" %} <span class="fa fa-arrow-right"></span></a>
+    {% endif %}
 </nav>

src/kasu/urls.py

@@ -1,6 +1,6 @@
 """ the main URL config that imports many URL configs from the applications. """
 from django.conf import settings
-from django.conf.urls import include, url
+from django.urls import include, path
 from django.conf.urls.static import static
 from django.contrib import admin
 from django.contrib.sitemaps.views import sitemap
@@ -10,58 +10,55 @@ from content import views, feeds
 from content.sitemaps import ArticleSitemap, PageSitemap
 from events.sitemaps import EventSitemap
 from events.views import EventListIcal
-from mahjong_ranking.sitemaps import *
-from maistar_ranking.sitemaps import *
+
+import mahjong_ranking.sitemaps
+import maistar_ranking.sitemaps
 from membership.views import MembershipDetail
 
 admin.autodiscover()
+# register_converter('path')
 
 sitemaps = {
-    'event_rankings': EventRankingSitemap,
-    'event_hanchans': EventHanchanSitemap,
-    'mahjong_seasons': MajongSeasonSitemap,
-    'maistar_games': MaistarGamesSitemap,
+    'event_rankings': mahjong_ranking.sitemaps.EventRankingSitemap,
+    'event_hanchans': mahjong_ranking.sitemaps.EventHanchanSitemap,
+    'mahjong_seasons': mahjong_ranking.sitemaps.MahjongSeasonSitemap,
+    'maistar_games': maistar_ranking.sitemaps.MaistarGamesSitemap,
     'articles': ArticleSitemap,
     'events': EventSitemap,
     'pages': PageSitemap,
 }
 
 urlpatterns = [  # Ignore PyLintBear (C0103)
-    url(r'^$', views.StartPage.as_view()),
-    url(r'^404/$', TemplateView.as_view(template_name='404.html')),
-    url(r'^add_page/(?P<path>[\+\.\-\d\w\/]+)/$',
-        views.PageAddForm.as_view(), name='add-page'),
-    url(r'^admin/doc/', include('django.contrib.admindocs.urls')),
-    url(r'^admin/', admin.site.urls),
-    url(r'^ckeditor/', include('ckeditor_uploader.urls')),
-    url(r'^comments/', include('django_comments.urls')),
-    url(r'^edit_page/(?P<path>[\+\.\-\d\w\/]+)/$',
-        views.PageEditForm.as_view(), name='edit-page'),
-    url(r'^events/', include('events.urls')),
-    url(r'^events.ics$', EventListIcal.as_view(), name='events-ical'),
-    url(r'^feeds/latest/$', feeds.LatestNews(), name='feed-latest-news'),
-    url(r'^feeds/comments/$', feeds.LatestComments(),
-        name='feed-latest-comments'),
-    url(r'^gallery/', include('events.gallery_urls')),
-    url(r'^google25dabc1a49a9ef03.html$', TemplateView.as_view(
-        template_name='google25dabc1a49a9ef03.html')),
-    url(r'^i18n/', include('django.conf.urls.i18n'), name='start-page'),
-    url(r'^index.html$', views.StartPage.as_view()),
-    url(r'^manifest.json$',
-        TemplateView.as_view(template_name='manifest.json')),
-    url(r'^membership/', include('membership.urls')),
-    url(r'^news/', include('content.news_urls')),
-    url(r'^ranking/', include('mahjong_ranking.urls')),
-    url(r'^ranking/', include('maistar_ranking.urls')),
-    url(r'^sitemap\.xml$', sitemap, {
-        'sitemaps': sitemaps}, name='django.contrib.sitemaps.views.sitemap'),
-    url(r'^robots.txt$', TemplateView.as_view(template_name='robots.txt')),
-    url(r'^users/$', MembershipDetail.as_view(), name='membership-details'),
-    url(r'^users/(?P<username>[\-\.\d\w]+)/$',
+    path("", views.StartPage.as_view(), name="index"),
+    path('index.html', views.StartPage.as_view()),
+    path('404/', TemplateView.as_view(template_name='404.html'), name="404"),
+    path('admin/doc/', include('django.contrib.admindocs.urls'), name="django-docs"),
+    path('admin/', admin.site.urls, name="django-admin"),
+    path('ckeditor/', include('ckeditor_uploader.urls')),
+    path('comments/', include('django_comments.urls')),
+    path('events/', include('events.urls')),
+    path('events.ics', EventListIcal.as_view(), name='events-ical'),
+    path('feeds/latest/', feeds.LatestNews(), name='feed-latest-news'),
+    path('feeds/comments/', feeds.LatestComments(), name='feed-latest-comments'),
+    path('gallery/', include('events.gallery_urls')),
+    path('google25dabc1a49a9ef03.html',
+         TemplateView.as_view(template_name='google25dabc1a49a9ef03.html')),
+    path('i18n/', include('django.conf.urls.i18n'), name='start-page'),
+    path('manifest.json', TemplateView.as_view(template_name='manifest.json')),
+    path('membership/', include('membership.urls')),
+    path('news/', include('content.news_urls')),
+    path('ranking/', include('mahjong_ranking.urls')),
+    path('ranking/', include('maistar_ranking.urls')),
+    path('robots.txt', TemplateView.as_view(template_name='robots.txt')),
+    path('users/', MembershipDetail.as_view(), name='membership-details'),
+    path('users/<slug:username>/',
          MembershipDetail.as_view(), name='membership-details'),
-    url(r'^(?P<path>[\-\d\w\/]+)\.html$',
-        views.PageHtml.as_view(), name='view-page'),
-    url(r'^(?P<path>[\-\d\w\/]+)\.pdf$', views.PagePdf.as_view()),
+    path('add_page/<path:path>', views.PageAddForm.as_view(), name='add-page'),
+    path('edit_page/<path:path>', views.PageEditForm.as_view(), name='edit-page'),
+    path('<path:path>.html', views.PageHtml.as_view(), name='view-page'),
+    path('<path:path>.pdf', views.PagePdf.as_view()),
+    path('sitemap.xml', sitemap, {'sitemaps': sitemaps},
+         name='django.contrib.sitemaps.views.sitemap'),
 ]
 
 if settings.DEBUG:
@@ -70,8 +67,8 @@ if settings.DEBUG:
     urlpatterns += static(settings.STATIC_URL,
                           document_root=settings.STATIC_ROOT)
     if 'rosetta' in settings.INSTALLED_APPS:
-        urlpatterns += [url(r'^rosetta/', include('rosetta.urls'))]
+        urlpatterns += [path("rosetta/", include('rosetta.urls'))]
     if 'debug_toolbar' in settings.INSTALLED_APPS:
         import debug_toolbar
 
-        urlpatterns += [url(r'^__debug__/', include(debug_toolbar.urls)), ]
+        urlpatterns += [path('__debug__/', include(debug_toolbar.urls)), ]

src/kasu/wsgi.py

@@ -1,7 +1,7 @@
 """ Script to start Django as an WSGI Application.
 
 src_path and virtpy_path are host dependet variables.
-TODO: Check if this file is really needet and make it host independet
+TODO: Check if this file is really needed and make it independent from host
 """
 import os
 import sys
@@ -14,8 +14,8 @@ if VENV_PATH not in sys.path:
 if SOURCE_PATH not in sys.path:
     sys.path.append(SOURCE_PATH)
 
-from django.core.wsgi import get_wsgi_application  # Ignore PyLintBear (C0413)  # Ignore PyLintBear (C0413)
+from django.core.wsgi import get_wsgi_application  # noqa: E402
 
 os.environ['DJANGO_SETTINGS_MODULE'] = 'kasu.settings'
 
-application = get_wsgi_application()  # Ignore PyLintBear (C0103)  # Ignore PyLintBear (C0103)
+application = get_wsgi_application()

src/kasu/xlsx.py

@@ -1,6 +1,7 @@
 """
 Helper to generate XLSX Spreadsheets in an uniform way.
 """
+import datetime
 from datetime import date
 
 import openpyxl
@@ -61,13 +62,15 @@ def getattr_recursive(obj, attr_string):
 
     :param obj: a python object.
     :param attr_string: the desired attribute of the object.
-    :return: a getattr_recursice(obj, 'attr1.attr2') will return the value of attr2 of attr1 from obj
+    :return:  return the value from attr2 of attr1 from obj
     """
     attr_list = attr_string.split('.')
     return_value = None
     for attr in attr_list:
         return_value = getattr(obj, attr)
         obj = return_value
+    if isinstance(return_value, datetime.datetime):
+        return_value = return_value.replace(tzinfo=None)
     return return_value
 
 
@@ -80,7 +83,8 @@ class Workbook(object):
         :rtype: object
         """
         self.workbook = openpyxl.Workbook()
-        [self.workbook.add_named_style(style) for style in XLSX_STYLES.values()]
+        [self.workbook.add_named_style(style)
+         for style in XLSX_STYLES.values()]
         [self.workbook.remove(sheet) for sheet in self.workbook.worksheets]
 
     def generate_sheet(self, title, columns_settings, object_list,
@@ -135,7 +139,8 @@ class Workbook(object):
 
         # write table footer
         for column, settings in enumerate(columns_settings, 1):
-            cell = ws.cell(column=column, row=row, value=settings.get('footer'))
+            cell = ws.cell(column=column, row=row,
+                           value=settings.get('footer'))
             cell.style = settings['style']
         row += 1
 

src/mahjong_ranking/admin.py

@@ -1,7 +1,7 @@
-""" Adds management of the mahong ranking system to the admin interface. """
+""" Adds management of the mahjong ranking system to the admin interface. """
 
 from django.contrib import admin
-from django.utils.translation import ugettext as _
+from django.utils.translation import gettext as _
 
 from . import models, set_dirty
 
@@ -21,6 +21,8 @@ def recalculate(modeladmin, request, queryset):  # Ignore PyLintBear (W0613)
         for ladder_ranking in queryset:
             set_dirty(user=ladder_ranking.user_id,
                       season=ladder_ranking.season)
+
+
 recalculate.short_description = _("Recalculate")
 
 
@@ -34,14 +36,14 @@ def confirm(modeladmin, request, queryset):  # Ignore PyLintBear (W0613)
 confirm.short_description = _("Confirm")
 
 
-def unconfirm(modeladmin, request, queryset):  # Ignore PyLintBear (W0613)
+def reject(modeladmin, request, queryset):  # Ignore PyLintBear (W0613)
     """An admin action to quickly set selected hanchans to unconfirmed. """
     for hanchan in queryset:
         hanchan.confirmed = False
         hanchan.save()
 
 
-unconfirm.short_description = _('Set unconfirmed')
+reject.short_description = _('Reject')
 
 
 class EventRankingAdmin(admin.ModelAdmin):
@@ -55,7 +57,7 @@ class EventRankingAdmin(admin.ModelAdmin):
 
 class HanchanAdmin(admin.ModelAdmin):
     """ To administrate the stored Hanchans. """
-    actions = [recalculate, confirm, unconfirm]
+    actions = [recalculate, confirm, reject]
     date_hierarchy = 'start'
     list_filter = ('season', 'event', 'confirmed')
     search_fields = ('player_names',)

src/mahjong_ranking/forms.py

@@ -7,7 +7,7 @@ Created on 04.10.2011
 """
 from django import forms
 from django.contrib.auth import get_user_model
-from django.utils.translation import ugettext as _
+from django.utils.translation import gettext as _
 
 from events.models import Event
 from . import models
@@ -64,7 +64,7 @@ class HanchanAdminForm(HanchanForm):
     """ Extends the HanchanForm for users with admin privileges.
 
     They are allowed to confirm/unconfirm Hanchans, this could be userful if
-    one games smells fishy and needs the opinion of an referee."""
+    one games smells fishy and needs the opinion of a referee."""
 
     class Meta(object):
         """ Extend the formfields to add the confirmed checkbox. """

src/mahjong_ranking/locale/de/LC_MESSAGES/django.po

@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: kasu.mahjong_ranking\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2018-05-08 00:17+0200\n"
+"POT-Creation-Date: 2023-08-07 20:38+0200\n"
 "PO-Revision-Date: 2018-05-08 00:20+0105\n"
 "Last-Translator: b'Christian Berg <kasu@xendynastie.at>'\n"
 "Language-Team: Kasu <verein@kasu.at>\n"
@@ -19,385 +19,380 @@ msgstr ""
 "X-Generator: Poedit 1.8.9\n"
 "X-Translated-Using: django-rosetta 0.8.1\n"
 
-#: .\mahjong_ranking\admin.py:24
+#: admin.py:26
 msgid "Recalculate"
 msgstr "Neuberechnen"
 
-#: .\mahjong_ranking\admin.py:34
+#: admin.py:36
 msgid "Confirm"
 msgstr "Bestätigen"
 
-#: .\mahjong_ranking\admin.py:44
-msgid "Set unconfirmed"
-msgstr "Als unbestätigt markieren"
+#: admin.py:46
+msgid "Reject"
+msgstr ""
 
-#: .\mahjong_ranking\forms.py:22
+#: forms.py:22
 msgid "start"
 msgstr "Beginn"
 
-#: .\mahjong_ranking\models.py:91
-#: .\mahjong_ranking\templates\mahjong_ranking\player_dan_score.html:14
-#: .\mahjong_ranking\templates\mahjong_ranking\player_invalid_score.html:13
-#: .\mahjong_ranking\templates\mahjong_ranking\player_kyu_score.html:15
-#: .\mahjong_ranking\templates\mahjong_ranking\player_ladder_score.html:15
-#: .\mahjong_ranking\templates\mahjong_ranking\seasonranking_list.html:10
+#: models.py:93 templates/mahjong_ranking/player_dan_score.html:14
+#: templates/mahjong_ranking/player_invalid_score.html:13
+#: templates/mahjong_ranking/player_kyu_score.html:15
+#: templates/mahjong_ranking/player_ladder_score.html:15
+#: templates/mahjong_ranking/seasonranking_list.html:10
 msgid "Start"
 msgstr "Beginn"
 
-#: .\mahjong_ranking\models.py:92
+#: models.py:94
 msgid "This is crucial to get the right Hanchans that scores"
 msgstr "Wichtig damit die richtigen Hanchans in die Wertung kommen."
 
-#: .\mahjong_ranking\models.py:99
+#: models.py:101
 msgid "Player 1"
 msgstr "Spieler 1"
 
-#: .\mahjong_ranking\models.py:100 .\mahjong_ranking\models.py:102
-#: .\mahjong_ranking\models.py:119 .\mahjong_ranking\models.py:121
-#: .\mahjong_ranking\models.py:138 .\mahjong_ranking\models.py:140
-#: .\mahjong_ranking\models.py:157 .\mahjong_ranking\models.py:159
-#: .\mahjong_ranking\templates\mahjong_ranking\eventhanchan_list.html:19
-#: .\mahjong_ranking\templates\mahjong_ranking\eventranking_list.html:21
-#: .\mahjong_ranking\templates\mahjong_ranking\hanchan_confirm_delete.html:16
-#: .\mahjong_ranking\templates\mahjong_ranking\hanchan_form.html:19
-#: .\mahjong_ranking\templates\mahjong_ranking\kyudanranking_list.html:30
-#: .\mahjong_ranking\templates\mahjong_ranking\seasonranking_list.html:31
+#: models.py:102 models.py:104 models.py:121 models.py:123 models.py:140
+#: models.py:142 models.py:159 models.py:161
+#: templates/mahjong_ranking/eventhanchan_list.html:19
+#: templates/mahjong_ranking/eventranking_list.html:21
+#: templates/mahjong_ranking/hanchan_confirm_delete.html:16
+#: templates/mahjong_ranking/hanchan_form.html:19
+#: templates/mahjong_ranking/kyudanranking_list.html:30
+#: templates/mahjong_ranking/seasonranking_list.html:31
 msgid "Score"
 msgstr "Punkte"
 
-#: .\mahjong_ranking\models.py:112 .\mahjong_ranking\models.py:131
-#: .\mahjong_ranking\models.py:150 .\mahjong_ranking\models.py:169
-#: .\mahjong_ranking\models.py:171
-#: .\mahjong_ranking\templates\mahjong_ranking\hanchan_form.html:20
-#: .\mahjong_ranking\templates\mahjong_ranking\player_dan_score.html:18
-#: .\mahjong_ranking\templates\mahjong_ranking\player_invalid_score.html:17
+#: models.py:114 models.py:133 models.py:152 models.py:171 models.py:173
+#: templates/mahjong_ranking/hanchan_form.html:20
+#: templates/mahjong_ranking/player_dan_score.html:18
+#: templates/mahjong_ranking/player_invalid_score.html:17
 msgid "Comment"
 msgstr "Kommentar"
 
-#: .\mahjong_ranking\models.py:118
+#: models.py:120
 msgid "Player 2"
 msgstr "Spieler 2"
 
-#: .\mahjong_ranking\models.py:137
+#: models.py:139
 msgid "Player 3"
 msgstr "Spieler 3"
 
-#: .\mahjong_ranking\models.py:156
+#: models.py:158
 msgid "Player 4"
 msgstr "Spieler 4"
 
-#: .\mahjong_ranking\models.py:173
+#: models.py:175
 msgid "Has been Confirmed"
 msgstr "Wurde bestätigt"
 
-#: .\mahjong_ranking\models.py:174
+#: models.py:176
 msgid "Only valid and confirmed Hanchans will be counted in the rating."
 msgstr "Nur gültige und bestätigte Hanchans kommen in die Wertung."
 
-#: .\mahjong_ranking\models.py:179 .\mahjong_ranking\models.py:607
-#: .\mahjong_ranking\templates\mahjong_ranking\ladder_redbox.html:29
-#: .\mahjong_ranking\templates\mahjong_ranking\player_ladder_score.html:63
+#: models.py:181 models.py:619 templates/mahjong_ranking/ladder_redbox.html:29
+#: templates/mahjong_ranking/player_ladder_score.html:63
 msgid "Season"
 msgstr "Saison"
 
-#: .\mahjong_ranking\models.py:184
+#: models.py:186
 msgid "Hanchan"
 msgstr "Hanchan"
 
-#: .\mahjong_ranking\models.py:185
-#: .\mahjong_ranking\templates\mahjong_ranking\eventranking_list.html:17
+#: models.py:187 templates/mahjong_ranking/eventranking_list.html:17
 msgid "Hanchans"
 msgstr "Hanchans"
 
-#: .\mahjong_ranking\models.py:188
+#: models.py:190
 msgid "Hanchan from {0:%Y-%m-%d} at {0:%H:%M} with {1}"
 msgstr "Hanchan vom {0:%Y-%m-%d} um {0:%H:%M} mit {1}"
 
-#: .\mahjong_ranking\models.py:215
+#: models.py:217
 #, python-format
 msgid "%s can't attend the same game multiple times"
 msgstr "%s kann an einem Spiel nicht mehrfach teilnehmen."
 
-#: .\mahjong_ranking\models.py:223
+#: models.py:225
 msgid "Games in the future may not be added, Dr. Brown"
 msgstr "Spiele aus der Zukunft dürfen noch nicht erfasst werden. Dr. Brown."
 
-#: .\mahjong_ranking\models.py:225
+#: models.py:227
 msgid "Only games during the event are allowed"
 msgstr "Nur Spiele während der Veranstaltung zählen."
 
-#: .\mahjong_ranking\models.py:228
+#: models.py:230
 msgid "Gamescore is lower then 100.000 Pt."
 msgstr "Spielstand ist weniger als 100.000 Punkte"
 
-#: .\mahjong_ranking\models.py:230
+#: models.py:232
 msgid "Gamescore is over 100.000 Pt."
 msgstr "Spielstand ist über 100.000 Punkte."
 
-#: .\mahjong_ranking\models.py:362
+#: models.py:367
 msgid "Kyū/Dan Ranking"
 msgstr "Kyū/Dan Wertung"
 
-#: .\mahjong_ranking\models.py:363
+#: models.py:368
 msgid "Kyū/Dan Rankings"
 msgstr "Kyū/Dan Wertungen"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\eventhanchan_form.html:11
-#: .\mahjong_ranking\templates\mahjong_ranking\eventhanchan_list.html:55
+#: templates/mahjong_ranking/eventhanchan_form.html:11
+#: templates/mahjong_ranking/eventhanchan_list.html:55
 msgid "Edit Hanchans"
 msgstr "Hanchans bearbeiten"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\eventhanchan_form.html:49
-#: .\mahjong_ranking\templates\mahjong_ranking\hanchan_form.html:58
+#: templates/mahjong_ranking/eventhanchan_form.html:49
+#: templates/mahjong_ranking/hanchan_form.html:58
 msgid "Total"
 msgstr "Total"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\eventhanchan_form.html:51
+#: templates/mahjong_ranking/eventhanchan_form.html:51
 msgid "Difference"
 msgstr "Unterschied"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\eventhanchan_form.html:103
-#: .\mahjong_ranking\templates\mahjong_ranking\eventhanchan_list.html:56
-#: .\mahjong_ranking\templates\mahjong_ranking\eventranking_list.html:52
-#: .\mahjong_ranking\templates\mahjong_ranking\hanchan_form.html:4
-#: .\mahjong_ranking\templates\mahjong_ranking\hanchan_form.html:14
+#: templates/mahjong_ranking/eventhanchan_form.html:103
+#: templates/mahjong_ranking/eventhanchan_list.html:56
+#: templates/mahjong_ranking/eventranking_list.html:52
+#: templates/mahjong_ranking/hanchan_form.html:4
+#: templates/mahjong_ranking/hanchan_form.html:14
 msgid "Add Hanchan"
 msgstr "Hanchan hinzufügen"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\eventhanchan_form.html:105
-#: .\mahjong_ranking\templates\mahjong_ranking\eventhanchan_list.html:37
-#: .\mahjong_ranking\templates\mahjong_ranking\hanchan_confirm_delete.html:4
-#: .\mahjong_ranking\templates\mahjong_ranking\hanchan_confirm_delete.html:33
-#: .\mahjong_ranking\templates\mahjong_ranking\player_dan_score.html:44
-#: .\mahjong_ranking\templates\mahjong_ranking\player_invalid_score.html:33
-#: .\mahjong_ranking\templates\mahjong_ranking\player_kyu_score.html:41
-#: .\mahjong_ranking\templates\mahjong_ranking\player_ladder_score.html:52
+#: templates/mahjong_ranking/eventhanchan_form.html:105
+#: templates/mahjong_ranking/eventhanchan_list.html:37
+#: templates/mahjong_ranking/hanchan_confirm_delete.html:4
+#: templates/mahjong_ranking/hanchan_confirm_delete.html:33
+#: templates/mahjong_ranking/player_dan_score.html:44
+#: templates/mahjong_ranking/player_invalid_score.html:33
+#: templates/mahjong_ranking/player_kyu_score.html:41
+#: templates/mahjong_ranking/player_ladder_score.html:52
 msgid "Delete Hanchan"
 msgstr "Hanchan löschen"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\eventhanchan_form.html:118
-#: .\mahjong_ranking\templates\mahjong_ranking\hanchan_form.html:71
+#: templates/mahjong_ranking/eventhanchan_form.html:118
+#: templates/mahjong_ranking/hanchan_form.html:71
 msgid "back"
 msgstr "Zurück"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\eventhanchan_form.html:119
-#: .\mahjong_ranking\templates\mahjong_ranking\hanchan_form.html:72
+#: templates/mahjong_ranking/eventhanchan_form.html:119
+#: templates/mahjong_ranking/hanchan_form.html:72
 msgid "save"
 msgstr "Speichern"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\eventhanchan_list.html:7
+#: templates/mahjong_ranking/eventhanchan_list.html:7
 msgid "Played Hanchans"
 msgstr "Gespielte Hanchans"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\eventhanchan_list.html:18
-#: .\mahjong_ranking\templates\mahjong_ranking\hanchan_confirm_delete.html:15
+#: templates/mahjong_ranking/eventhanchan_list.html:18
+#: templates/mahjong_ranking/hanchan_confirm_delete.html:15
 msgid "Place"
 msgstr "Platz"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\eventhanchan_list.html:21
-#: .\mahjong_ranking\templates\mahjong_ranking\hanchan_confirm_delete.html:18
-#: .\mahjong_ranking\templates\mahjong_ranking\player_dan_score.html:17
+#: templates/mahjong_ranking/eventhanchan_list.html:21
+#: templates/mahjong_ranking/hanchan_confirm_delete.html:18
+#: templates/mahjong_ranking/player_dan_score.html:17
 msgid "Dan Points"
 msgstr "Dan Punkte"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\eventhanchan_list.html:23
-#: .\mahjong_ranking\templates\mahjong_ranking\hanchan_confirm_delete.html:20
-#: .\mahjong_ranking\templates\mahjong_ranking\player_invalid_score.html:16
-#: .\mahjong_ranking\templates\mahjong_ranking\player_kyu_score.html:18
+#: templates/mahjong_ranking/eventhanchan_list.html:23
+#: templates/mahjong_ranking/hanchan_confirm_delete.html:20
+#: templates/mahjong_ranking/player_invalid_score.html:16
+#: templates/mahjong_ranking/player_kyu_score.html:18
 msgid "Kyu Points"
 msgstr "Kyu Punkte"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\eventhanchan_list.html:43
-#: .\mahjong_ranking\templates\mahjong_ranking\hanchan_form.html:4
-#: .\mahjong_ranking\templates\mahjong_ranking\hanchan_form.html:14
-#: .\mahjong_ranking\templates\mahjong_ranking\player_dan_score.html:47
-#: .\mahjong_ranking\templates\mahjong_ranking\player_invalid_score.html:36
-#: .\mahjong_ranking\templates\mahjong_ranking\player_kyu_score.html:44
-#: .\mahjong_ranking\templates\mahjong_ranking\player_ladder_score.html:55
+#: templates/mahjong_ranking/eventhanchan_list.html:43
+#: templates/mahjong_ranking/hanchan_form.html:4
+#: templates/mahjong_ranking/hanchan_form.html:14
+#: templates/mahjong_ranking/player_dan_score.html:47
+#: templates/mahjong_ranking/player_invalid_score.html:36
+#: templates/mahjong_ranking/player_kyu_score.html:44
+#: templates/mahjong_ranking/player_ladder_score.html:55
 msgid "Edit Hanchan"
 msgstr "Hanchan bearbeiten"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\eventhanchan_list.html:48
+#: templates/mahjong_ranking/eventhanchan_list.html:48
 msgid "No Hanchan has been added to this event yet."
 msgstr "Für diese Veranstaltung wurde noch keine Hanchan eingetragen."
 
-#: .\mahjong_ranking\templates\mahjong_ranking\eventhanchan_list.html:54
-#: .\mahjong_ranking\templates\mahjong_ranking\eventranking_list.html:51
+#: templates/mahjong_ranking/eventhanchan_list.html:54
+#: templates/mahjong_ranking/eventranking_list.html:51
 msgid "Edit Event"
 msgstr "Veranstaltung bearbeiten"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\eventranking_list.html:4
-#: .\mahjong_ranking\templates\mahjong_ranking\eventranking_list.html:5
+#: templates/mahjong_ranking/eventranking_list.html:4
+#: templates/mahjong_ranking/eventranking_list.html:5
 msgid "Tournament Ranking"
 msgstr "Turnierwertung"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\eventranking_list.html:12
-#: .\mahjong_ranking\templates\mahjong_ranking\kyudanranking_list.html:25
-#: .\mahjong_ranking\templates\mahjong_ranking\seasonranking_list.html:23
+#: templates/mahjong_ranking/eventranking_list.html:12
+#: templates/mahjong_ranking/kyudanranking_list.html:25
+#: templates/mahjong_ranking/seasonranking_list.html:23
 msgid "Rank"
 msgstr "Rang"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\eventranking_list.html:13
-#: .\mahjong_ranking\templates\mahjong_ranking\kyudanranking_list.html:17
-#: .\mahjong_ranking\templates\mahjong_ranking\seasonranking_list.html:24
+#: templates/mahjong_ranking/eventranking_list.html:13
+#: templates/mahjong_ranking/kyudanranking_list.html:17
+#: templates/mahjong_ranking/seasonranking_list.html:24
 msgid "Avatar"
 msgstr "Avatar"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\eventranking_list.html:14
-#: .\mahjong_ranking\templates\mahjong_ranking\kyudanranking_list.html:20
-#: .\mahjong_ranking\templates\mahjong_ranking\seasonranking_list.html:25
+#: templates/mahjong_ranking/eventranking_list.html:14
+#: templates/mahjong_ranking/kyudanranking_list.html:20
+#: templates/mahjong_ranking/seasonranking_list.html:25
 msgid "Nickname"
 msgstr "Spitzname"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\eventranking_list.html:15
+#: templates/mahjong_ranking/eventranking_list.html:15
 msgid "Name"
 msgstr "Name"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\eventranking_list.html:16
-#: .\mahjong_ranking\templates\mahjong_ranking\seasonranking_list.html:26
+#: templates/mahjong_ranking/eventranking_list.html:16
+#: templates/mahjong_ranking/seasonranking_list.html:26
 msgid "Average"
 msgstr "Durchschnitt"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\eventranking_list.html:20
-#: .\mahjong_ranking\templates\mahjong_ranking\player_dan_score.html:15
-#: .\mahjong_ranking\templates\mahjong_ranking\player_invalid_score.html:15
-#: .\mahjong_ranking\templates\mahjong_ranking\player_kyu_score.html:16
-#: .\mahjong_ranking\templates\mahjong_ranking\player_ladder_score.html:16
-#: .\mahjong_ranking\templates\mahjong_ranking\seasonranking_list.html:30
+#: templates/mahjong_ranking/eventranking_list.html:20
+#: templates/mahjong_ranking/player_dan_score.html:15
+#: templates/mahjong_ranking/player_invalid_score.html:15
+#: templates/mahjong_ranking/player_kyu_score.html:16
+#: templates/mahjong_ranking/player_ladder_score.html:16
+#: templates/mahjong_ranking/seasonranking_list.html:30
 msgid "Placement"
 msgstr "Platzierung"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\eventranking_list.html:22
-#: .\mahjong_ranking\templates\mahjong_ranking\seasonranking_list.html:32
+#: templates/mahjong_ranking/eventranking_list.html:22
+#: templates/mahjong_ranking/seasonranking_list.html:32
 msgid "count"
 msgstr "Anzahl"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\eventranking_list.html:23
-#: .\mahjong_ranking\templates\mahjong_ranking\seasonranking_list.html:33
+#: templates/mahjong_ranking/eventranking_list.html:23
+#: templates/mahjong_ranking/seasonranking_list.html:33
 msgid "good"
 msgstr "gut"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\eventranking_list.html:24
-#: .\mahjong_ranking\templates\mahjong_ranking\seasonranking_list.html:34
+#: templates/mahjong_ranking/eventranking_list.html:24
+#: templates/mahjong_ranking/seasonranking_list.html:34
 msgid "won"
 msgstr "gewonnen"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\hanchan_confirm_delete.html:39
+#: templates/mahjong_ranking/hanchan_confirm_delete.html:39
 msgid "Cancel"
 msgstr "Abbruch"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\hanchan_confirm_delete.html:40
+#: templates/mahjong_ranking/hanchan_confirm_delete.html:40
 msgid "Delete"
 msgstr "Löschen"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\hanchan_form.html:18
+#: templates/mahjong_ranking/hanchan_form.html:18
 msgid "Player"
 msgstr "Spieler"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\kyudanranking_list.html:4
-#: .\mahjong_ranking\templates\mahjong_ranking\kyudanranking_list.html:9
-#| msgid "Player List"
+#: templates/mahjong_ranking/kyudanranking_list.html:4
+#: templates/mahjong_ranking/kyudanranking_list.html:9
 msgid "Players list"
 msgstr "Spielerliste"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\kyudanranking_list.html:35
+#: templates/mahjong_ranking/kyudanranking_list.html:35
 msgid "Games Total"
 msgstr "Spiele total"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\ladder_redbox.html:3
+#: templates/mahjong_ranking/ladder_redbox.html:3
 msgid "Latest Hanchans"
 msgstr "Letzten Hanchans"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\ladder_redbox.html:15
+#: templates/mahjong_ranking/ladder_redbox.html:15
 msgid "Latest Events"
 msgstr "Letzte Veranstaltungen"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\ladder_redbox.html:27
+#: templates/mahjong_ranking/ladder_redbox.html:27
 msgid "Ladder Archive"
 msgstr "Ladder Archiv"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\player_dan_score.html:4
-#: .\mahjong_ranking\templates\mahjong_ranking\player_dan_score.html:5
+#: templates/mahjong_ranking/player_dan_score.html:4
+#: templates/mahjong_ranking/player_dan_score.html:5
 msgid "Dan Score for"
 msgstr "Dan Wertung für"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\player_dan_score.html:8
+#: templates/mahjong_ranking/player_dan_score.html:8
 msgid "Hanchans that apply to the Dan Score"
 msgstr "Hanchans welche zur Dan Wertung zählen"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\player_dan_score.html:12
-#: .\mahjong_ranking\templates\mahjong_ranking\player_kyu_score.html:13
-#: .\mahjong_ranking\templates\mahjong_ranking\player_ladder_score.html:13
+#: templates/mahjong_ranking/player_dan_score.html:12
+#: templates/mahjong_ranking/player_kyu_score.html:13
+#: templates/mahjong_ranking/player_ladder_score.html:13
 msgid "Date"
 msgstr "Datum"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\player_dan_score.html:13
-#: .\mahjong_ranking\templates\mahjong_ranking\player_invalid_score.html:12
-#: .\mahjong_ranking\templates\mahjong_ranking\player_kyu_score.html:14
-#: .\mahjong_ranking\templates\mahjong_ranking\player_ladder_score.html:14
+#: templates/mahjong_ranking/player_dan_score.html:13
+#: templates/mahjong_ranking/player_invalid_score.html:12
+#: templates/mahjong_ranking/player_kyu_score.html:14
+#: templates/mahjong_ranking/player_ladder_score.html:14
 msgid "Event"
 msgstr "Veranstaltung"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\player_dan_score.html:16
-#: .\mahjong_ranking\templates\mahjong_ranking\player_invalid_score.html:14
-#: .\mahjong_ranking\templates\mahjong_ranking\player_kyu_score.html:17
-#: .\mahjong_ranking\templates\mahjong_ranking\player_ladder_score.html:17
+#: templates/mahjong_ranking/player_dan_score.html:16
+#: templates/mahjong_ranking/player_invalid_score.html:14
+#: templates/mahjong_ranking/player_kyu_score.html:17
+#: templates/mahjong_ranking/player_ladder_score.html:17
 msgid "Players"
 msgstr "Spieler"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\player_invalid_score.html:4
-#: .\mahjong_ranking\templates\mahjong_ranking\player_invalid_score.html:6
+#: templates/mahjong_ranking/player_invalid_score.html:4
+#: templates/mahjong_ranking/player_invalid_score.html:6
 msgid "Unconfirmed Hanchans from"
 msgstr "Nicht bestätigte Hanchans von"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\player_invalid_score.html:9
+#: templates/mahjong_ranking/player_invalid_score.html:9
 msgid "Invalid hanchans with"
 msgstr "Ungültige Hanchans mit"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\player_kyu_score.html:4
-#: .\mahjong_ranking\templates\mahjong_ranking\player_kyu_score.html:6
+#: templates/mahjong_ranking/player_kyu_score.html:4
+#: templates/mahjong_ranking/player_kyu_score.html:6
 msgid "Kyu Score for"
 msgstr "Kyu Wertung für"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\player_kyu_score.html:9
+#: templates/mahjong_ranking/player_kyu_score.html:9
 msgid "Hanchans that apply to the Kyu Score"
 msgstr "Hanchans welche zur Kyu Wertung zählen"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\player_ladder_score.html:4
-#: .\mahjong_ranking\templates\mahjong_ranking\player_ladder_score.html:5
+#: templates/mahjong_ranking/player_ladder_score.html:4
+#: templates/mahjong_ranking/player_ladder_score.html:5
 msgid "Ladder Score for"
 msgstr "Ladder Wertung für"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\player_ladder_score.html:8
+#: templates/mahjong_ranking/player_ladder_score.html:8
 msgid "Hanchans that apply to the Ladder Score"
 msgstr "Hanchans welche in der Ladder zählen"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\player_ladder_score.html:71
+#: templates/mahjong_ranking/player_ladder_score.html:71
 msgid "Go"
 msgstr "Los"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\seasonranking_list.html:11
+#: templates/mahjong_ranking/seasonranking_list.html:11
 msgid "End"
 msgstr "Ende"
 
-#: .\mahjong_ranking\templates\mahjong_ranking\seasonranking_list.html:12
+#: templates/mahjong_ranking/seasonranking_list.html:12
 msgid "Participants"
 msgstr "Teilnehmer"
 
-#: .\mahjong_ranking\views.py:104
+#: views.py:116
 #, python-format
 msgid "%s has been updated successfully."
 msgstr "%s wurde erfolgreich aktualisiert."
 
-#: .\mahjong_ranking\views.py:107
+#: views.py:119
 #, python-format
 msgid "%s has been added successfully. You can now add a new one."
 msgstr "%s wurde erfolgreich hinzugefügt. Du kannst eine neue eintragen."
 
-#: .\mahjong_ranking\views.py:207
+#: views.py:222
 msgid "No user found matching the name {}"
 msgstr "Kein Benutzer mit dem Namen %s gefunden"
 
+#~ msgid "Set unconfirmed"
+#~ msgstr "Als unbestätigt markieren"
+
 #~ msgid "Full Name"
 #~ msgstr "Voller Name"
 

src/mahjong_ranking/management/commands/exportranking.py

@@ -1,4 +1,4 @@
-"""Export Mahjong Rankings as excel files."""
+"""Export Mahjong Rankings as Excel files."""
 
 import os
 from datetime import date, time, datetime

src/mahjong_ranking/management/commands/fixateranking.py

@@ -0,0 +1,58 @@
+"""
+Recalculates all Kyu/Dan Rankings until the given date
+and writes them to the legacy fields.
+"""
+
+from django.core.management.base import BaseCommand
+from datetime import datetime, date, time
+from mahjong_ranking import models
+from django.utils.dateparse import parse_date
+from django.utils import timezone
+
+LEGACY_ATTRIBUTES = (
+    "dan",
+    "dan_points",
+    "max_dan_points",
+    "kyu",
+    "kyu_points",
+    "hanchan_count",
+    "good_hanchans",
+    "won_hanchans"
+)
+
+
+class Command(BaseCommand):
+    help = "Recalculates all Kyu/Dan Rankings until the given date " + \
+           "and writes them to the legacy fields."
+
+
+def add_arguments(self, parser):
+    parser.add_argument('-s', '--since', nargs='?', type=parse_date,
+                        metavar='YYYY-MM-DD',
+                        help='Use all Hanchans since the given date.')
+    parser.add_argument('-u', '--until', nargs='?', type=parse_date,
+                        metavar='YYYY-MM-DD',
+                        help='Only use Hanchans until the given date.')
+
+
+def handle(self, *args, **options):
+    since = options.get('since', None)
+    until = options.get('until', None)
+    if isinstance(since, date):
+        since = datetime.combine(since, time(0, 0, 0))
+        since = timezone.make_aware(since)
+    if isinstance(until, date):
+        until = datetime.combine(until, time(23, 59, 59))
+        until = timezone.make_aware(until)
+    models.KyuDanRanking.objects.update(since=since, until=until, force_recalc=True)
+    # write the updated values to the legacy fields
+    for ranking in models.KyuDanRanking.objects.all():
+        print(ranking)
+        for attribute in LEGACY_ATTRIBUTES:
+            setattr(ranking, f"legacy_{attribute}", getattr(ranking, attribute))
+            value = getattr(ranking, attribute)
+            legacy_value = getattr(ranking, f"legacy_{attribute}")
+            print(f"{attribute}: {value}, legacy_{attribute}: {legacy_value}")
+        ranking.legacy_date = until.date()
+        print(f"legacy_date: {ranking.legacy_date}")
+        ranking.save()

src/mahjong_ranking/management/commands/resetdanranking.py

@@ -3,13 +3,15 @@ Rest all dan points to 0 at a given date.
 """
 
 from django.core.management.base import BaseCommand
-from datetime import date, datetime, time
+from datetime import datetime
+from datetime import time
 from mahjong_ranking import models
 from django.utils.dateparse import parse_date
 from django.utils import timezone
 
+
 class Command(BaseCommand):
-    """ Recalculate all Kyu/Dan Rankings """
+    """ reset every dan player to 1st dan with 0 points. """
 
     help = "reset every dan player to 1st dan with 0 points."
 
@@ -22,7 +24,8 @@ class Command(BaseCommand):
         legacy_attrs.remove('legacy_date')
         reset_date = timezone.make_aware(datetime.combine(
             options.get('reset_date'), time(23, 59, 59)))
-        models.KyuDanRanking.objects.update(until=reset_date, force_recalc=True)
+        models.KyuDanRanking.objects.update(
+            until=reset_date, force_recalc=True)
         for ranking in models.KyuDanRanking.objects.filter(dan__gt=0):
             print(ranking)
             ranking.dan = 1

src/mahjong_ranking/managers.py

@@ -74,11 +74,13 @@ class HanchanManager(models.Manager):
         [hanchan.get_playerdata(user) for hanchan in queryset]
         return queryset
 
-    def season_hanchans(self, user=None, season=None, until=None):
+    def season_hanchans(self, user: object = None,
+                        season: int = None, until: date = None):
         """Return all Hanchans that belong to a given or the current season.
 
         :param user: Only return Hanchans where this user participated.  
         :param season: the year of the wanted season, current year if None.
+        :param until: only return hanchans played until the given date.
         :return: QuerySet Object
         """
         try:
@@ -92,6 +94,7 @@ class HanchanManager(models.Manager):
 
         :param user: Return Hanchans where this user participated.  
         :param since: only return Hanchans played since the given datetime
+        :param until: only return hanchans played until the given date.
         :param filter_args: To add specific arguments to the Django filter.
         :return: a QuerySet Object
         """
@@ -199,10 +202,8 @@ class SeasonRankingManager(models.Manager):
 class KyuDanRankingManager(models.Manager):
     def json_data(self):
         """ Get all Rankings for a given Season and return them as a list of
-        dict objects, suitable for JSON exports and other processings.
-
-        :param season: Season that should be exported, current season if empty 
-        :return: a list() of dict() objects suiteable for JSON export. 
+        dict objects, suitable for JSON exports and other processing.
+        :return: a list() of dict() objects suitable for JSON export.
         """
         json_data = list()
         values = self.all()
@@ -237,8 +238,9 @@ class KyuDanRankingManager(models.Manager):
 
     def update(self, since=None, until=None, force_recalc=False):
         old_attr = {'dan': None, 'dan_points': None,
-                    'kyu': None, 'kyu_points': None, 'won_hanchans': None,
-                    'good_hanchans': None, 'hanchan_count': None}
+                    'kyu': None, 'kyu_points': None,
+                    'won_hanchans': None, 'good_hanchans': None,
+                    'hanchan_count': None}
         for ranking in self.all():
             old_attr = {attr: getattr(ranking, attr) for attr in
                         old_attr.keys()}
@@ -247,7 +249,8 @@ class KyuDanRankingManager(models.Manager):
             for attr, old_value in old_attr.items():
                 if getattr(ranking, attr) != old_value:
                     LOGGER.warning(
-                        "%(user)s recalc shows differences in %(attr)s! old: %(old)d, new: %(new)d",
+                        "%(user)s recalc shows differences in %(attr)s! ' + "
+                        "'old: %(old)d, new: %(new)d",
                         {'user': ranking.user, 'attr': attr,
-                         'old': old_value or 0, 'new': getattr(ranking, attr) or 0}
+                         'old': old_value or 0, 'new': getattr(ranking, attr, 0)}
                     )

src/mahjong_ranking/middleware.py

@@ -1,12 +1,26 @@
 """Middleware to defer slow denormalization  at the end of a request."""
 from django.core.cache import cache
+
 from mahjong_ranking import models
 from . import LOGGER
 
 
-class DenormalizationUpdateMiddleware(object):  # Ignore PyLintBear (R0903)
+class DenormalizationUpdateMiddleware:
     """To recalculate everything in the queues at the end of a POST request."""
 
+    def __init__(self, get_response=None):
+        self.get_response = get_response
+        super().__init__()
+
+    def __call__(self, request):
+        response = None
+        if hasattr(self, 'process_request'):
+            response = self.process_request(request)
+        response = response or self.get_response(request)
+        if hasattr(self, 'process_response'):
+            response = self.process_response(request, response)
+        return response
+
     def process_response(self, request, response):  # Ignore PyLintBear (R0201)
         """Check and process the recalculation queues on each POST request.
 
@@ -16,7 +30,6 @@ class DenormalizationUpdateMiddleware(object):  # Ignore PyLintBear (R0903)
         """
         event_queue = set()
         season_queue = set()
-
         if request.method != 'POST':
             return response
 

src/mahjong_ranking/migrations/0001_initial.py

@@ -41,7 +41,8 @@ class Migration(migrations.Migration):
                                         serialize=False, auto_created=True,
                                         primary_key=True)),
                 ('start', models.DateTimeField(
-                    help_text='Wichtig damit die richtigen Hanchans in die Wertung kommen.',
+                    help_text="Wichtig damit die richtigen Hanchans in die " + \
+                              "Wertung kommen.",
                     verbose_name='Beginn')),
                 ('player1_input_score',
                  models.IntegerField(verbose_name='Punkte')),
@@ -55,14 +56,14 @@ class Migration(migrations.Migration):
                     null=True, editable=False, blank=True)),
                 ('player1_bonus_points', models.SmallIntegerField(
                     null=True, editable=False, blank=True)),
-                ('player1_comment', models.CharField(verbose_name='Anmerkung',
+                ('player1_comment', models.CharField(verbose_name="Anmerkung",
                                                      max_length=255,
                                                      editable=False,
                                                      blank=True)),
                 ('player2_input_score',
-                 models.IntegerField(verbose_name='Punkte')),
+                 models.IntegerField(verbose_name="Punkte")),
                 ('player2_game_score', models.PositiveIntegerField(
-                    default=0, verbose_name='Punkte', editable=False)),
+                    default=0, verbose_name="Punkte", editable=False)),
                 ('player2_placement', models.PositiveSmallIntegerField(
                     default=0, editable=False)),
                 ('player2_kyu_points', models.SmallIntegerField(
@@ -111,7 +112,8 @@ class Migration(migrations.Migration):
                  models.TextField(verbose_name='Anmerkung', blank=True)),
                 ('confirmed', models.BooleanField(
                     default=True,
-                    help_text='Nur g\xfcltige und best\xe4tigte Hanchans kommen in die Wertung.',
+                    help_text="Nur g\xfcltige und best\xe4tigte Hanchans kommen " + \
+                              "in die Wertung.",
                     verbose_name='Wurde best\xe4tigt')),
                 ('player_names',
                  models.CharField(max_length=255, editable=False)),

src/mahjong_ranking/migrations/0005_auto_20171115_0653.py

@@ -6,7 +6,6 @@ from django.db import migrations, models
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('mahjong_ranking', '0004_auto_20170218_1947'),
     ]
@@ -14,7 +13,9 @@ class Migration(migrations.Migration):
     operations = [
         migrations.AlterModelOptions(
             name='kyudanranking',
-            options={'ordering': ('-dan_points', 'dan', '-kyu_points'), 'verbose_name': 'Kyū/Dan Wertung', 'verbose_name_plural': 'Kyū/Dan Wertungen'},
+            options={'ordering': ('-dan_points', 'dan', '-kyu_points'),
+                     'verbose_name': 'Kyū/Dan Wertung',
+                     'verbose_name_plural': 'Kyū/Dan Wertungen'},
         ),
         migrations.AddField(
             model_name='kyudanranking',

src/mahjong_ranking/migrations/0006_auto_20171214_1318.py

@@ -8,7 +8,6 @@ import django.db.models.deletion
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('mahjong_ranking', '0005_auto_20171115_0653'),
     ]
@@ -42,27 +41,40 @@ class Migration(migrations.Migration):
         migrations.AlterField(
             model_name='eventranking',
             name='user',
-            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, to=settings.AUTH_USER_MODEL),
+            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT,
+                                    to=settings.AUTH_USER_MODEL),
         ),
         migrations.AlterField(
             model_name='hanchan',
             name='player1',
-            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, related_name='user_hanchan+', to=settings.AUTH_USER_MODEL, verbose_name='Spieler 1'),
+            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT,
+                                    related_name='user_hanchan+',
+                                    to=settings.AUTH_USER_MODEL,
+                                    verbose_name='Spieler 1'),
         ),
         migrations.AlterField(
             model_name='hanchan',
             name='player2',
-            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, related_name='user_hanchan+', to=settings.AUTH_USER_MODEL, verbose_name='Spieler 2'),
+            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT,
+                                    related_name='user_hanchan+',
+                                    to=settings.AUTH_USER_MODEL,
+                                    verbose_name='Spieler 2'),
         ),
         migrations.AlterField(
             model_name='hanchan',
             name='player3',
-            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, related_name='user_hanchan+', to=settings.AUTH_USER_MODEL, verbose_name='Spieler 3'),
+            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT,
+                                    related_name='user_hanchan+',
+                                    to=settings.AUTH_USER_MODEL,
+                                    verbose_name='Spieler 3'),
         ),
         migrations.AlterField(
             model_name='hanchan',
             name='player4',
-            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, related_name='user_hanchan+', to=settings.AUTH_USER_MODEL, verbose_name='Spieler 4'),
+            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT,
+                                    related_name='user_hanchan+',
+                                    to=settings.AUTH_USER_MODEL,
+                                    verbose_name='Spieler 4'),
         ),
         migrations.AlterField(
             model_name='kyudanranking',
@@ -82,6 +94,7 @@ class Migration(migrations.Migration):
         migrations.AlterField(
             model_name='seasonranking',
             name='user',
-            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, to=settings.AUTH_USER_MODEL),
+            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT,
+                                    to=settings.AUTH_USER_MODEL),
         ),
     ]

src/mahjong_ranking/migrations/0007_alter_kyudanranking_options_and_more.py

@@ -0,0 +1,25 @@
+# Generated by Django 4.2.2 on 2023-07-19 18:11
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ('mahjong_ranking', '0006_auto_20171214_1318'),
+    ]
+
+    operations = [
+        migrations.AlterModelOptions(
+            name='kyudanranking',
+            options={'ordering': (
+            models.OrderBy(models.F('dan'), descending=True, nulls_last=True),
+            '-dan_points', '-kyu_points', '-won_hanchans', '-good_hanchans',
+            '-last_hanchan_date'), 'verbose_name': 'Kyū/Dan Wertung',
+                     'verbose_name_plural': 'Kyū/Dan Wertungen'},
+        ),
+        migrations.AddField(
+            model_name='kyudanranking',
+            name='legacy_max_dan_points',
+            field=models.PositiveIntegerField(default=0),
+        ),
+    ]

src/mahjong_ranking/models.py

@@ -12,7 +12,7 @@ from django.core.exceptions import ValidationError
 from django.db import models
 from django.urls import reverse
 from django.utils import timezone
-from django.utils.translation import ugettext as _
+from django.utils.translation import gettext as _
 
 from events.models import Event
 from . import DAN_RANKS_DICT, LOGGER, set_dirty
@@ -29,7 +29,8 @@ class EventRanking(models.Model):
     Sie beschränken sich aber auf einen Event und werden nur dann angestossen,
     wenn der Event als Turnier markiert wurde.
     """
-    user = models.ForeignKey(settings.AUTH_USER_MODEL, on_delete=models.PROTECT)
+    user = models.ForeignKey(settings.AUTH_USER_MODEL,
+                             on_delete=models.PROTECT)
     event = models.ForeignKey(Event, on_delete=models.CASCADE)
     placement = models.PositiveIntegerField(blank=True, null=True)
     avg_placement = models.FloatField(default=4)
@@ -46,9 +47,9 @@ class EventRanking(models.Model):
 
     def recalculate(self):
         """
-        Berechnet die durschnittliche Platzierung und Punkte, u.v.m. neu.
+        Berechnet die durchschnittliche Platzierung und Punkte, u.v.m. neu.
 
-        Diese Daten werden benötigt um die Platzierung zu erstellen. Sie
+        Diese Daten werden benötigt, um die Platzierung zu erstellen. Sie
         können zwar sehr leicht errechnet werden, es macht trotzdem Sinn
         sie zwischenzuspeichern.
         """
@@ -289,9 +290,8 @@ class Hanchan(models.Model):
                 self.bonus_points = getattr(self, '%s_bonus_points' % player)
                 self.player_comment = getattr(self, '%s_comment' % player)
 
-    def update_playerdata(self, user, **kwargs):
-        """i small workaround to access score, placement of a specific user
-        prominent from a in the user templates"""
+    def update_player_data(self, user, **kwargs):
+        """to access scores and placement of a specific user from templates"""
         for player in ('player1', 'player2', 'player3', 'player4'):
             if getattr(self, player) == user:
                 setattr(self, '%s_input_score' % player, self.input_score)
@@ -348,6 +348,7 @@ class KyuDanRanking(models.Model):
     legacy_date = models.DateField(blank=True, null=True)
     legacy_dan = models.PositiveSmallIntegerField(blank=True, null=True)
     legacy_dan_points = models.PositiveIntegerField(blank=True, null=True)
+    legacy_max_dan_points = models.PositiveIntegerField(default=0)
     legacy_kyu = models.PositiveSmallIntegerField(blank=True, null=True)
     legacy_kyu_points = models.PositiveIntegerField(blank=True, null=True)
     legacy_hanchan_count = models.PositiveIntegerField(blank=True, null=True)
@@ -358,7 +359,10 @@ class KyuDanRanking(models.Model):
     objects = managers.KyuDanRankingManager()
 
     class Meta(object):
-        ordering = ('-dan_points', 'dan', '-kyu_points')
+        ordering = (models.F("dan").desc(nulls_last=True),
+                    '-dan_points', '-kyu_points',
+                    '-won_hanchans', '-good_hanchans',
+                    '-last_hanchan_date')
         verbose_name = _(u'Kyū/Dan Ranking')
         verbose_name_plural = _(u'Kyū/Dan Rankings')
 
@@ -417,7 +421,7 @@ class KyuDanRanking(models.Model):
 
     def append_tournament_bonuspoints(self, hanchan):
         """
-        Prüft ob es die letzte Hanchan in einem Turnier war. Wenn ja werden
+        Prüft, ob es die letzte Hanchan in einem Turnier war. Wenn ja, werden
         bei Bedarf Bonuspunkte vergeben, falls der Spieler das Turnier
         gewonnen hat.
         :param hanchan: Ein Player Objekt
@@ -428,7 +432,8 @@ class KyuDanRanking(models.Model):
         ).order_by('-start')
         last_hanchan_this_event = hanchans_this_event[0]
         # Das braucht nur am Ende eines Turnieres gemacht werden.
-        if hanchan != last_hanchan_this_event: return False
+        if hanchan != last_hanchan_this_event:
+            return False
         event_ranking = EventRanking.objects.get(
             user=self.user,
             event=hanchan.event
@@ -439,8 +444,8 @@ class KyuDanRanking(models.Model):
                 settings.TOURNAMENT_WIN_BONUSPOINTS)
         if event_ranking.avg_placement == 1:
             bonus_points += settings.TOURNAMENT_FLAWLESS_VICTORY_BONUSPOINTS
-            hanchan.player_comment += u'+{0:d} Pkt: alle Spiele des Turnieres gewonnen. '.format(
-                settings.TOURNAMENT_FLAWLESS_VICTORY_BONUSPOINTS)
+            hanchan.player_comment += '+{0:d} Pkt: alle Spiele des Turnieres \
+            gewonnen. '.format(settings.TOURNAMENT_FLAWLESS_VICTORY_BONUSPOINTS)
 
         if bonus_points and self.dan:
             hanchan.dan_points += bonus_points
@@ -472,7 +477,7 @@ class KyuDanRanking(models.Model):
             # Setze alles auf die legacy Werte und berechne alles von neuem.
             self.dan = self.legacy_dan
             self.dan_points = self.legacy_dan_points or 0
-            self.max_dan_points = self.dan_points
+            self.max_dan_points = self.legacy_max_dan_points or 0
             self.kyu = self.legacy_kyu
             self.kyu_points = self.legacy_kyu_points or 0
             self.hanchan_count = self.legacy_hanchan_count or 0
@@ -489,19 +494,27 @@ class KyuDanRanking(models.Model):
             since = timezone.make_aware(
                 datetime.combine(self.legacy_date, time(0, 0, 0))
             )
-        LOGGER.info(
-            "recalculating Kyu/Dan points for %(user)s since %(since)s...",
-            {'user': self.user, 'since': str(since)}
-        )
         if since:
             valid_hanchans = valid_hanchans.filter(start__gt=since)
+        else:
+            since = valid_hanchans.aggregate(since=models.Min("start"))["since"]
         if until:
             valid_hanchans = valid_hanchans.filter(start__lte=until)
+        else:
+            until = valid_hanchans.aggregate(until=models.Max("start"))["until"]
+        if valid_hanchans.count() > 0:
+            LOGGER.info(f"recalculating Kyu/Dan points for {self.user} " +
+                        f"({since:%Y-%m-%d} - {until:%Y-%m-%d})...")
+        else:
+            LOGGER.info(f"No new valid Hanchans for {self.user}...")
         for hanchan in valid_hanchans:
             self.hanchan_count += 1
+            LOGGER.info(
+                f"{self.user} Hanchan no. {self.hanchan_count} " +
+                f"from {hanchan.start}")
             hanchan.get_playerdata(self.user)
             if since and hanchan.start < since:
-                LOGGER.debug(hanchan, "<", since, "no recalc")
+                LOGGER.info(hanchan, "<", since, "no recalc")
                 self.dan_points += hanchan.dan_points or 0
                 self.kyu_points += hanchan.kyu_points or 0
                 self.update_rank()
@@ -513,7 +526,7 @@ class KyuDanRanking(models.Model):
                     self.append_tournament_bonuspoints(hanchan)
                 self.update_rank()
                 self.append_3_in_a_row_bonuspoints(hanchan)
-                hanchan.update_playerdata(self.user)
+                hanchan.update_player_data(self.user)
                 hanchan.save(recalculate=False)
             self.won_hanchans += 1 if hanchan.placement == 1 else 0
             self.good_hanchans += 1 if hanchan.placement == 2 else 0
@@ -524,7 +537,7 @@ class KyuDanRanking(models.Model):
         """
         Berechne die Kyu bzw. Dan Punkte für eine Hanchan neu.
         :type hanchan: Hanchan
-        :param hanchan: Das Player Objekt das neuberechnet werden soll.
+        :param hanchan: das Player-Objekt, welches neu berechnet werden soll.
         """
         hanchan.kyu_points = None
         hanchan.dan_points = None
@@ -567,14 +580,16 @@ class KyuDanRanking(models.Model):
             # Only substract so much points that player has 0 Points:
             if self.dan_points + hanchan.dan_points < 0:
                 hanchan.player_comment = 'Spieler unterschreitet 0 Punkte.' \
-                    '(Original {} Punkte)'.format(hanchan.dan_points)
+                                         '(Original {} Punkte)'.format(
+                    hanchan.dan_points)
                 hanchan.dan_points -= (self.dan_points + hanchan.dan_points)
             self.dan_points += hanchan.dan_points
         else:
             # Only substract so much points that player has 0 Points:
             if self.kyu_points + hanchan.kyu_points < 0:
                 hanchan.player_comment = 'Spieler unterschreitet 0 Punkte.' \
-                    '(Original {} Punkte)'.format(hanchan.kyu_points)
+                                         '(Original {} Punkte)'.format(
+                    hanchan.kyu_points)
                 hanchan.kyu_points -= (self.kyu_points + hanchan.kyu_points)
             self.kyu_points += hanchan.kyu_points
 
@@ -603,7 +618,8 @@ class KyuDanRanking(models.Model):
 
 
 class SeasonRanking(models.Model):
-    user = models.ForeignKey(settings.AUTH_USER_MODEL, on_delete=models.PROTECT)
+    user = models.ForeignKey(settings.AUTH_USER_MODEL,
+                             on_delete=models.PROTECT)
     season = models.PositiveSmallIntegerField(_('Season'))
     placement = models.PositiveIntegerField(blank=True, null=True)
     avg_placement = models.FloatField(blank=True, null=True)

src/mahjong_ranking/sitemaps.py

@@ -11,38 +11,42 @@ from .models import SeasonRanking
 
 class EventRankingSitemap(GenericSitemap):
     @staticmethod
-    def items():
-        """add all upcoming and archived events to the sitemap."""
+    def items(**kwargs):
+        """add all upcoming and archived events to the sitemap.
+        @param **kwargs:
+        """
         return Event.objects.all().exclude(eventranking=None)
 
     @staticmethod
-    def location(event):
+    def location(event, **kwargs):
         return reverse('event-ranking', kwargs={'event': event.id})
 
 
 class EventHanchanSitemap(GenericSitemap):
     @staticmethod
-    def items():
-        """add all upcoming and archived events to the sitemap."""
+    def items(**kwargs):
+        """add all upcoming and archived events to the sitemap.
+        @param **kwargs:
+        """
         return Event.objects.all().exclude(eventranking=None)
 
     @staticmethod
-    def location(event):
+    def location(event, **kwargs):
         return reverse('event-hanchan-list', kwargs={'event': event.id})
 
 
-class MajongSeasonSitemap(Sitemap):
+class MahjongSeasonSitemap(Sitemap):
     priority = 0.5
 
     @staticmethod
-    def items():
+    def items(**kwargs):
         seasons = SeasonRanking.objects.all().distinct('season').order_by(
             'season')
         seasons = seasons.values_list('season', flat=True)
         return seasons
 
     @staticmethod
-    def location(season):
+    def location(season, **kwargs):
         return reverse('mahjong-ladder', kwargs={'season': season})
 
     @staticmethod

src/mahjong_ranking/templates/mahjong_ranking/eventhanchan_form.html

@@ -18,7 +18,7 @@
   <fieldset class="hanchan">
     {% for hidden in form.hidden_fields %} {{ hidden }} {% endfor %}
     <p>
-      <label for="id_{{ form.start.html_name }}_0" class="field_name {{ form.start.css_classes }}">{{ form.start.label }}:</label>
+      <label for="{{ form.start.if_for_label }}" class="field_name {{ form.start.css_classes }}">{{ form.start.label }}:</label>
       {{ form.start }}
       {{ form.start.errors }}
     </p>

src/mahjong_ranking/templates/mahjong_ranking/hanchan_confirm_delete.html

@@ -7,7 +7,7 @@
 <h3 class="grid_12" id="{{ hanchan.pk }}">{{hanchan.start|time:'H:i'}}: {{ hanchan.player_names }}</h3>
 {% for player in hanchan.player_list %}
     <a class="grid_1" href="{% url 'player-ladder-score' player.user %}"><img
-            src="{% thumbnail user.avatar|default:'unknown_profile.jpg' 'avatar' %}"
+            src="{% thumbnail player.user.avatar|default:'unknown_profile.jpg' 'avatar' %}"
             width="70" height="70"
             class="avatar" alt="{{ player.user }}" title="{{ player.user }}"/></a>
     <div class="grid_2">
@@ -33,7 +33,7 @@
         <legend>{% trans "Delete Hanchan" %}</legend>
         {% include 'form.html' %}
         <label class="field_name fa fa-exclamation-triangle fa-5x fa-pull-left" ></label>
-        <p>Bist du sicher dass du diese Hanchan und alle Ergebnisse und Wertungen welche sich hierauf beziehen löschen möchtest?</p>
+        <p>Bist du sicher, dass du diese Hanchan und alle Ergebnisse und Wertungen, welche sich hierauf beziehen löschen möchtest?</p>
         <br class="clear">
         <p class="buttonbar">
             <button type="button" onclick="window.history.back()"><span class="fa fa-close"></span> {% trans 'Cancel' %}</button>

src/mahjong_ranking/templates/mahjong_ranking/ladder_redbox.html

@@ -5,7 +5,7 @@
     {% for hanchan in latest_hanchan_list %}
     <li><span class="fa-li fa fa-table"></span>
         <a href="{% url 'event-hanchan-list' hanchan.event_id %}">
-            <time datetime="{{ hanchan.start|date:'c' }}">{{ hanchan.start|date:'D' }}
+            <time datetime="{{ hanchan.start|date:'Y-m-d\TH:i:sO' }}">{{ hanchan.start|date:'D' }}
                 {{ hanchan.start|date:'SHORT_DATE_FORMAT' }} {{hanchan.start|time:'H:i'}}
             </time></a>:<br />
         <small>{{hanchan.player_names}}</small>
@@ -18,7 +18,7 @@
     <li>
         <span class="fa-li fa fa-calendar-o"></span>
         <a href="{% url 'event-hanchan-list' event.pk %}">
-        <time datetime="{{event.start|date:'c'}}">{{ event.start|date:'D' }} {{ event.start|date:'SHORT_DATE_FORMAT' }}</time>:
+        <time datetime="{{event.start|date:'Y-m-d\TH:i:sO'}}">{{ event.start|date:'D' }} {{ event.start|date:'SHORT_DATE_FORMAT' }}</time>:
         {{event.name}}</a></li>
     {% endfor %}
 </ul>
@@ -31,7 +31,7 @@
         {% for season_link in season_list%}
         <option
           value="{% url 'mahjong-ladder' season_link %}"
-          {% ifequal season season_link %} selected="selected"{% endifequal %}>{{ season_link }}
+          selected="selected">{{ season_link }}
         </option>
         {% endfor %}
         </select>

src/mahjong_ranking/templates/mahjong_ranking/player_ladder_score.html

@@ -64,7 +64,7 @@
             <select id="season" name="season" size="1">
             {% for season_link in season_list%}
                 <option
-                  {% ifequal season season_link %} selected="selected"{% endifequal %}
+                        selected="selected"
                         value="{{ season_link }}">{{ season_link }}</option>
             {% endfor %}
             </select>
@@ -75,5 +75,5 @@
 {% endblock %}
 
 {% block buttonbar %}
-<a href="?download=xlsx" class="button"><span class="fa fa-table"></span> Download</a>
+<a href="?download=xlsx{% if season %}&season={{ season }}{% endif %}" class="button"><span class="fa fa-table"></span> Download</a>
 {% endblock %}

src/mahjong_ranking/templates/mahjong_ranking/seasonranking_list.html

@@ -49,8 +49,8 @@
         </tr>
         {% empty %}
         <tr>
-            <td colspan="9">Leider hat es noch niemand in das Ranking geschafft.
-                Ein Spieler wird erst ins Ranking genommen wenn er 5 Hanchans absolviert hat.
+            <td colspan="8">Leider hat es noch niemand in das Ranking geschafft.
+                Spieler werden erst ins Ranking genommen, wenn sie 5 Hanchans absolviert haben.
             </td>
         </tr>
         {% endfor %}

src/mahjong_ranking/tests.py

@@ -97,7 +97,6 @@ class KyuDanTest(TestCase):
             self.assertEqual(
                 points[dan_kyu],
                 getattr(ranking, dan_kyu),
-                "{dan_kyu} for {player} won't compute! ranking: {ranking}, sum: {sum}".format(
-                    dan_kyu=dan_kyu, player=ranking.user,
-                    ranking=getattr(ranking, dan_kyu), sum=points[dan_kyu])
+                f"{dan_kyu} for {ranking.user} won't compute! " +
+                f"ranking: {ranking.dan_kyu}, sum: {points[dan_kyu]}"
             )

src/mahjong_ranking/urls.py

@@ -1,39 +1,38 @@
 """ URLS to display the Riichi Mahjong Rankings and the Ladder system."""
 
-from django.conf.urls import url
+from django.urls import path
 from django.views.generic import RedirectView
 
 from . import views
-urlpatterns = [  # Ignore PyLintBear (C0103)
-    url(r'^$',
-        RedirectView.as_view(url='/ranking/mahjong-ladder/', permanent=True)),
-    url(r'^event/(?P<event>[\d]+)/add-hanchan/$',
-        views.HanchanForm.as_view(), name="add-hanchan-form"),
-    url(r'^event/(?P<event>[\d]+)/edit/$',
-        views.EventHanchanForm.as_view(), name="event-hanchan-form"),
-    url(r'^event/(?P<event>[\d]+)/mahjong/$',
-        views.EventHanchanList.as_view(), name="event-hanchan-list"),
-    url(r'^event/(?P<event>[\d]+)/mahjong-ranking/$',
-        views.EventRankingList.as_view(), name="event-ranking"),
-    url(r'^hanchan/(?P<hanchan>[\d]+)/edit/$',
-        views.HanchanForm.as_view(), name="edit-hanchan"),
-    url(r'^hanchan/(?P<hanchan>[\d]+)/delete/$',
-        views.DeleteHanchan.as_view(), name="delete-hanchan"),
-    url(r'^mahjong-ladder/$', views.SeasonRankingList.as_view(),
-        name="mahjong-ladder"),
-    url(r'^mahjong-ladder/(?P<season>[\d]+)/$',
-        views.SeasonRankingList.as_view(), name="mahjong-ladder"),
-    url(r'^player/(?P<username>[\-\.\d\w]+)/dan/$',
-        views.PlayerDanScore.as_view(), name="player-dan-score"),
-    url(r'^player/(?P<username>[\-\.\d\w]+)/invalid/$',
-        views.PlayerInvalidScore.as_view(), name="player-invalid-score"),
-    url(r'^player/(?P<username>[\-\.\d\w]+)/kyu/$',
-        views.PlayerKyuScore.as_view(), name="player-kyu-score"),
-    url(r'^player/(?P<username>[\-\.\d\w]+)/ladder/$',
-        views.PlayerLadderScore.as_view(), name="player-ladder-score"),
-    url(r'^mahjong/$', views.KyuDanRankingList.as_view(),
-        name="kyudanranking-list"),
-    url(r'^mahjong/(?P<order_by>[\+\-][a-z_]+)/$',
-        views.KyuDanRankingList.as_view(), name="kyudanranking-list"),
-]
 
+urlpatterns = [
+    path("", RedirectView.as_view(url='/ranking/mahjong-ladder/', permanent=True)),
+    path('event/<int:event>/add-hanchan/', views.HanchanForm.as_view(),
+         name="add-hanchan-form"),
+    path('event/<int:event>/edit/', views.EventHanchanForm.as_view(),
+         name="event-hanchan-form"),
+    path('event/<int:event>/mahjong/', views.EventHanchanList.as_view(),
+         name="event-hanchan-list"),
+    path('event/<int:event>/mahjong-ranking/', views.EventRankingList.as_view(),
+         name="event-ranking"),
+    path('hanchan/<int:hanchan>/edit/', views.HanchanForm.as_view(),
+         name="edit-hanchan"),
+    path('hanchan/<int:hanchan>/delete/', views.DeleteHanchan.as_view(),
+         name="delete-hanchan"),
+    path('mahjong-ladder/', views.SeasonRankingList.as_view(),
+         name="mahjong-ladder"),
+    path('mahjong-ladder/<int:season>/', views.SeasonRankingList.as_view(),
+         name="mahjong-ladder"),
+    path('player/<slug:username>/dan/', views.PlayerDanScore.as_view(),
+         name="player-dan-score"),
+    path('player/<slug:username>/invalid/', views.PlayerInvalidScore.as_view(),
+         name="player-invalid-score"),
+    path('player/<slug:username>/kyu/', views.PlayerKyuScore.as_view(),
+         name="player-kyu-score"),
+    path('player/<slug:username>/ladder/', views.PlayerLadderScore.as_view(),
+         name="player-ladder-score"),
+    path('mahjong/', views.KyuDanRankingList.as_view(),
+         name="kyudanranking-list"),
+    path('mahjong/<str:order_by>/', views.KyuDanRankingList.as_view(),
+         name="kyudanranking-list"),
+]

src/mahjong_ranking/views.py

@@ -8,7 +8,7 @@ from django.contrib.auth.mixins import LoginRequiredMixin, \
     PermissionRequiredMixin
 from django.contrib.messages.views import SuccessMessageMixin
 from django.urls import reverse
-from django.utils.translation import ugettext as _
+from django.utils.translation import gettext as _
 from django.views import generic
 
 from events.mixins import EventDetailMixin
@@ -45,7 +45,7 @@ def get_kyu_dan_ranking(user=None):
 
 class DeleteHanchan(EventDetailMixin, PermissionRequiredMixin,
                     generic.DeleteView):
-    """Deletes a Hanchan if confimration has been answerd with 'yes'."""
+    """Deletes a Hanchan if confirmation has been answered with 'yes'."""
     form_class = forms.HanchanForm
     model = models.Hanchan
     permission_required = 'mahjong_ranking.delete_hanchan'
@@ -53,7 +53,7 @@ class DeleteHanchan(EventDetailMixin, PermissionRequiredMixin,
 
     def get_success_url(self):
         """
-        Return to the HachanList of the event form the deleted hanchan.
+        Return to the HanchanList of the event form the deleted hanchan.
         :return: URL of the EventHanchanList for the event
         """
         return reverse('event-hanchan-list',
@@ -71,7 +71,7 @@ class HanchanForm(SuccessMessageMixin, EventDetailMixin,
 
     def get_form_class(self):
         """
-        Users with hanchan edit persmission can also un-/confirm hanchans.
+        Users with hanchan edit permission can also un-/confirm a Hanchan.
         :return: forms.HanchanForm, or forms.HanchanAdminForm
         """
         return forms.HanchanAdminForm if self.request.user.has_perm(
@@ -123,27 +123,27 @@ class HanchanForm(SuccessMessageMixin, EventDetailMixin,
 class EventHanchanForm(EventDetailMixin, PermissionRequiredMixin,
                        generic.TemplateView):
     """Display a Formset to add and Edit Hanchans of the specific Event."""
+    formset: forms.HanchanFormset
     permission_required = 'mahjong_ranking.add_hanchan'
     template_name = 'mahjong_ranking/eventhanchan_form.html'
     model = models.Hanchan
 
     def get_context_data(self, **kwargs):
         self.event = models.Event.objects.get(pk=self.kwargs['event'])
+        self.formset = forms.HanchanFormset(
+            instance=self.event,
+            initial=[{'start': self.event.start}]
+        )
         context = super(EventHanchanForm, self).get_context_data()
         context['formset'] = self.formset
         return context
 
     def get(self, request, *args, **kwargs):
         self.get_queryset()
-        self.formset = forms.HanchanFormset(
-            instance=self.event,
-            initial=[{'start': self.event.start}]
-        )
         context = self.get_context_data(**kwargs)
         return self.render_to_response(context)
 
     def post(self, request, *args, **kwargs):
-        print("ICH WURDE GEPOSTET!!!!")
         self.get_queryset()
         self.formset = forms.HanchanFormset(
             self.request.POST,
@@ -160,7 +160,6 @@ class EventHanchanForm(EventDetailMixin, PermissionRequiredMixin,
         return self.render_to_response(context)
 
 
-
 class EventHanchanList(EventDetailMixin, generic.ListView):
     "List all hanchans played on a given event."
     model = models.Hanchan
@@ -173,9 +172,9 @@ class EventRankingList(EventDetailMixin, generic.ListView):
 
 
 class KyuDanRankingList(MahjongMixin, generic.ListView):
-    """List all Players with an Kyu or Dan score. """
+    """List all Players with a Kyu or Dan score. """
     order_by = None
-    paginate_by = 25
+    paginate_by = 100
 
     def dispatch(self, request, *args, **kwargs):
         """Set the order_by settings, revert to default_order if necessary."""
@@ -193,7 +192,7 @@ class KyuDanRankingList(MahjongMixin, generic.ListView):
 
 class SeasonRankingList(MahjongMixin, generic.ListView):
     model = models.SeasonRanking
-    paginate_by = 25
+    paginate_by = 100
     season = None
 
     def get_queryset(self):
@@ -206,18 +205,23 @@ class SeasonRankingList(MahjongMixin, generic.ListView):
 
 
 class PlayerScore(LoginRequiredMixin, generic.ListView):
-    paginate_by = 25
+    paginate_by: int = 100
     user = auth.get_user_model()
+    kyu_dan_ranking = None
+    season = None
 
     def get(self, request, *args, **kwargs):
         user_model = auth.get_user_model()
         try:
             self.user = user_model.objects.get(
                 username=self.kwargs.get('username'))
+            self.kyu_dan_ranking = get_kyu_dan_ranking(user=self.user)
+            self.season = int(self.request.GET.get('season', date.today().year))
         except user_model.DoesNotExist:
             raise django.http.Http404(
                 _("No user found matching the name {}").format(
                     self.kwargs.get('username')))
+
         if request.GET.get('download') == 'xlsx':
             return self.get_xlsx(request, *args, **kwargs)
         return super(PlayerScore, self).get(request, *args, **kwargs)
@@ -229,7 +233,7 @@ class PlayerScore(LoginRequiredMixin, generic.ListView):
             context['kyu_dan_ranking'] = models.KyuDanRanking.objects.get(
                 user=self.user)
         except models.KyuDanRanking.DoesNotExist:
-            context['ranking'] = None
+            context['kyu_dan_ranking'] = None
         try:
             context['ladder_ranking'] = models.SeasonRanking.objects.get(
                 user=self.user,
@@ -239,27 +243,31 @@ class PlayerScore(LoginRequiredMixin, generic.ListView):
         return context
 
     def get_xlsx(self, request, *args, **kwargs):
-        self.object_list = self.get_queryset()
         response = django.http.HttpResponse(
             content_type='application/vnd.openxmlformats-officedocument.spreadsheetml.sheet')
-        response['Content-Disposition'] = 'attachment; ' \
-                                          'filename="{xlsx_filename}"'.format(
-            xlsx_filename=self.xlsx_filename)
-        xlxs_workbook = xlsx.Workbook()
-        xlxs_workbook.generate_sheet(
+        response['Content-Disposition'] = f'attachment; filename="{self.xlsx_filename}"'
+        xlsx_workbook = xlsx.Workbook()
+        xlsx_workbook.generate_sheet(
             title=self.xlsx_filename.split('.')[0],
             columns_settings=self.xlsx_columns,
-            object_list=self.object_list
+            object_list=self.get_queryset()
         )
-        xlxs_workbook.save(response)
+        xlsx_workbook.save(response)
         return response
 
+    @property
+    def xlsx_columns(self):
+        return {}
+
+    @property
+    def xlsx_filename(self):
+        return ""
+
 
 class PlayerDanScore(PlayerScore):
     template_name = 'mahjong_ranking/player_dan_score.html'
 
     def get_queryset(self):
-        self.kyu_dan_ranking = get_kyu_dan_ranking(user=self.user)
         return models.Hanchan.objects.dan_hanchans(
             user=self.user,
             since=self.kyu_dan_ranking.legacy_date)
@@ -299,17 +307,20 @@ class PlayerDanScore(PlayerScore):
 
     @property
     def xlsx_filename(self):
-        return "{username}_dan_score.xlsx".format(username=self.user.username)
+        return f"{self.user.username}_dan_score.xlsx"
 
 
 class PlayerInvalidScore(PlayerScore):
     template_name = 'mahjong_ranking/player_invalid_score.html'
 
+
     def get_queryset(self):
-        self.xlsx_filename = "{username}_invalid_score.xlsx".format(
-            username=self.user.username)
         return models.Hanchan.objects.unconfirmed(user=self.user)
 
+    @property
+    def xlsx_filename(self):
+        return f"{self.user.username}_invalid_score.xlsx"
+
 
 class PlayerKyuScore(PlayerScore):
     template_name = 'mahjong_ranking/player_kyu_score.html'
@@ -355,7 +366,7 @@ class PlayerKyuScore(PlayerScore):
 
     @property
     def xlsx_filename(self):
-        return "{username}_kyu_score.xlsx".format(username=self.user.username)
+        return f"{self.user.username}_kyu_score.xlsx"
 
 
 class PlayerLadderScore(PlayerScore):
@@ -371,7 +382,6 @@ class PlayerLadderScore(PlayerScore):
         return context
 
     def get_queryset(self, **kwargs):
-        self.season = int(self.request.GET.get('season', date.today().year))
         hanchan_list = models.Hanchan.objects.season_hanchans(
             user=self.user,
             season=self.season
@@ -409,7 +419,4 @@ class PlayerLadderScore(PlayerScore):
 
     @property
     def xlsx_filename(self):
-        return "{username}_ladder_score_{season}.xlsx".format(
-            username=self.user.username,
-            season=self.season
-        )
+        return f"{self.user.username}_ladder_{self.season}_score.xlsx"

src/maistar_ranking/admin.py

@@ -1,6 +1,6 @@
 """ Admin Interface to manipulate the maistar ranking """
 from django.contrib import admin
-from django.utils.translation import ugettext as _
+from django.utils.translation import gettext as _
 
 from . import forms, models
 

src/maistar_ranking/forms.py

@@ -1,7 +1,7 @@
 """Django Forms to add and edit Mai-Star games."""
 
 from django import forms
-from django.utils.translation import ugettext as _
+from django.utils.translation import gettext as _
 
 from . import models
 

src/maistar_ranking/locale/de/LC_MESSAGES/django.po

@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: kasu.mahjong_ranking\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2018-05-08 00:17+0200\n"
+"POT-Creation-Date: 2023-07-26 18:31+0200\n"
 "PO-Revision-Date: 2016-09-28 00:24+0200\n"
 "Last-Translator: Christian Berg <xeniac.at@gmail.com>\n"
 "Language-Team: Kasu <verein@kasu.at>\n"
@@ -19,208 +19,207 @@ msgstr ""
 "X-Generator: Poedit 1.8.9\n"
 "X-Translated-Using: django-rosetta 0.7.2\n"
 
-#: .\maistar_ranking\admin.py:24
+#: admin.py:24
 msgid "Recalculate"
 msgstr "Neuberechnen"
 
-#: .\maistar_ranking\forms.py:35
+#: forms.py:35
 #, python-format
 msgid "%s may only participate once."
 msgstr "%s darf nur einmal teilnehmen."
 
-#: .\maistar_ranking\models.py:21
+#: models.py:21
 msgid "Comment"
 msgstr "Kommentar"
 
-#: .\maistar_ranking\models.py:24
+#: models.py:24
 msgid "Player 1"
 msgstr "Spieler 1"
 
-#: .\maistar_ranking\models.py:26 .\maistar_ranking\models.py:33
-#: .\maistar_ranking\models.py:40 .\maistar_ranking\models.py:47
-#: .\maistar_ranking\models.py:54 .\maistar_ranking\models.py:61
-#: .\maistar_ranking\templates\maistar_ranking\ranking_list.html:19
+#: models.py:26 models.py:33 models.py:40 models.py:47 models.py:54
+#: models.py:61 templates/maistar_ranking/ranking_list.html:19
 msgid "Score"
 msgstr "Punkte"
 
-#: .\maistar_ranking\models.py:31
+#: models.py:31
 msgid "Player 2"
 msgstr "Spieler 2"
 
-#: .\maistar_ranking\models.py:38
+#: models.py:38
 msgid "Player 3"
 msgstr "Spieler 3"
 
-#: .\maistar_ranking\models.py:45
+#: models.py:45
 msgid "Player 4"
 msgstr "Spieler 4"
 
-#: .\maistar_ranking\models.py:52
+#: models.py:52
 msgid "Player 5"
 msgstr "Spieler 5"
 
-#: .\maistar_ranking\models.py:59
+#: models.py:59
 msgid "Player 6"
 msgstr "Spieler 6"
 
-#: .\maistar_ranking\models.py:65
+#: models.py:65
 msgid "Has been confirmed"
 msgstr "Wurde bestätigt"
 
-#: .\maistar_ranking\models.py:67
+#: models.py:67
 msgid "the game only counts whe it has been confirmed"
 msgstr "das Spiel zählt nur wenn es bestätigt wurde"
 
-#: .\maistar_ranking\models.py:70 .\maistar_ranking\models.py:153
-#: .\maistar_ranking\templates\maistar_ranking\player_game_list.html:6
-#: .\maistar_ranking\templates\maistar_ranking\ranking_list.html:4
-#: .\maistar_ranking\templates\maistar_ranking\ranking_list.html:72
+#: models.py:70 models.py:154 templates/maistar_ranking/player_game_list.html:6
+#: templates/maistar_ranking/ranking_list.html:4
+#: templates/maistar_ranking/ranking_list.html:72
 msgid "Season"
 msgstr "Saison"
 
-#: .\maistar_ranking\models.py:80
+#: models.py:80
 msgid "Mai-Star Game with {0} from {1:%Y-%m-%d}"
 msgstr "Mai-Star Spiel mit {0} vom {1:%Y-%m-%d}"
 
-#: .\maistar_ranking\templates\maistar_ranking\game_form.html:5
-#: .\maistar_ranking\templates\maistar_ranking\game_form.html:16
-#: .\maistar_ranking\templates\maistar_ranking\game_list.html:27
-#: .\maistar_ranking\templates\maistar_ranking\player_game_list.html:44
-msgid "Edit Game"
-msgstr "Spiel bearbeiten"
-
-#: .\maistar_ranking\templates\maistar_ranking\game_form.html:5
-#: .\maistar_ranking\templates\maistar_ranking\game_form.html:16
-#: .\maistar_ranking\templates\maistar_ranking\game_list.html:41
-msgid "Add Game"
-msgstr "Spiel hinzufügen"
-
-#: .\maistar_ranking\templates\maistar_ranking\game_form.html:76
-msgid "Back"
-msgstr "Zurück"
-
-#: .\maistar_ranking\templates\maistar_ranking\game_form.html:77
-msgid "Save"
-msgstr "Speichern"
-
-#: .\maistar_ranking\templates\maistar_ranking\game_list.html:4
-#: .\maistar_ranking\templates\maistar_ranking\player_game_list.html:6
-msgid "Mai-Star Games"
-msgstr "Mai-Star Spiele"
-
-#: .\maistar_ranking\templates\maistar_ranking\game_list.html:7
-msgid "Played Mai-Star Games"
-msgstr "Gespielte Mai-Star Spiele"
-
-#: .\maistar_ranking\templates\maistar_ranking\game_list.html:11
-msgid "Game"
-msgstr "Spiel"
-
-#: .\maistar_ranking\templates\maistar_ranking\game_list.html:14
-msgid "Place"
-msgstr "Platz"
-
-#: .\maistar_ranking\templates\maistar_ranking\game_list.html:19
-#: .\maistar_ranking\templates\maistar_ranking\player_game_list.html:36
-msgid "Points"
-msgstr "Punkte"
-
-#: .\maistar_ranking\templates\maistar_ranking\game_list.html:24
-#: .\maistar_ranking\templates\maistar_ranking\player_game_list.html:41
-msgid "Delete Game"
-msgstr "Spiel löschen"
-
-#: .\maistar_ranking\templates\maistar_ranking\game_list.html:33
-msgid "No Mai-Star games have been added to this event yet."
-msgstr "Für diese Veranstaltung wurden noch keine Mai-Star Spiele erfasst."
-
-#: .\maistar_ranking\templates\maistar_ranking\game_list.html:40
-msgid "Edit Event"
-msgstr "Veranstaltung bearbeiten"
-
-#: .\maistar_ranking\templates\maistar_ranking\hanchan_confirm_delete.html:4
-#: .\maistar_ranking\templates\maistar_ranking\hanchan_confirm_delete.html:10
+#: templates/maistar_ranking/game_confirm_delete.html:4
+#: templates/maistar_ranking/game_confirm_delete.html:9
 msgid "Delete game"
 msgstr "Spiel löschen"
 
-#: .\maistar_ranking\templates\maistar_ranking\hanchan_confirm_delete.html:13
+#: templates/maistar_ranking/game_confirm_delete.html:12
+#: templates/maistar_ranking/game_list.html:14
+msgid "Place"
+msgstr "Platz"
+
+#: templates/maistar_ranking/game_confirm_delete.html:18
+#: templates/maistar_ranking/game_list.html:19
+#: templates/maistar_ranking/player_game_list.html:36
+msgid "Points"
+msgstr "Punkte"
+
+#: templates/maistar_ranking/game_confirm_delete.html:23
 msgid "Cancel"
 msgstr "Abbrechen"
 
-#: .\maistar_ranking\templates\maistar_ranking\hanchan_confirm_delete.html:14
+#: templates/maistar_ranking/game_confirm_delete.html:25
 msgid "Delete"
 msgstr "Löschen"
 
-#: .\maistar_ranking\templates\maistar_ranking\page.html:5
+#: templates/maistar_ranking/game_form.html:5
+#: templates/maistar_ranking/game_form.html:16
+#: templates/maistar_ranking/game_list.html:27
+#: templates/maistar_ranking/player_game_list.html:44
+msgid "Edit Game"
+msgstr "Spiel bearbeiten"
+
+#: templates/maistar_ranking/game_form.html:5
+#: templates/maistar_ranking/game_form.html:16
+#: templates/maistar_ranking/game_list.html:41
+msgid "Add Game"
+msgstr "Spiel hinzufügen"
+
+#: templates/maistar_ranking/game_form.html:76
+msgid "Back"
+msgstr "Zurück"
+
+#: templates/maistar_ranking/game_form.html:77
+msgid "Save"
+msgstr "Speichern"
+
+#: templates/maistar_ranking/game_list.html:4
+#: templates/maistar_ranking/player_game_list.html:6
+msgid "Mai-Star Games"
+msgstr "Mai-Star Spiele"
+
+#: templates/maistar_ranking/game_list.html:7
+msgid "Played Mai-Star Games"
+msgstr "Gespielte Mai-Star Spiele"
+
+#: templates/maistar_ranking/game_list.html:11
+msgid "Game"
+msgstr "Spiel"
+
+#: templates/maistar_ranking/game_list.html:24
+#: templates/maistar_ranking/player_game_list.html:41
+msgid "Delete Game"
+msgstr "Spiel löschen"
+
+#: templates/maistar_ranking/game_list.html:33
+msgid "No Mai-Star games have been added to this event yet."
+msgstr "Für diese Veranstaltung wurden noch keine Mai-Star Spiele erfasst."
+
+#: templates/maistar_ranking/game_list.html:40
+msgid "Edit Event"
+msgstr "Veranstaltung bearbeiten"
+
+#: templates/maistar_ranking/page.html:5
 msgid "Archive"
 msgstr "Archiv"
 
-#: .\maistar_ranking\templates\maistar_ranking\page.html:7
+#: templates/maistar_ranking/page.html:7
 msgid "Add Event"
 msgstr "Veranstaltung hinzufügen"
 
-#: .\maistar_ranking\templates\maistar_ranking\player_game_list.html:4
+#: templates/maistar_ranking/player_game_list.html:4
 msgid "Ladder Score for"
 msgstr "Ladder Wertung für"
 
-#: .\maistar_ranking\templates\maistar_ranking\player_game_list.html:9
+#: templates/maistar_ranking/player_game_list.html:9
 msgid "Mai-Star Games with"
 msgstr "Mai-Star Spiele mit"
 
-#: .\maistar_ranking\templates\maistar_ranking\player_game_list.html:14
+#: templates/maistar_ranking/player_game_list.html:14
 msgid "Date"
 msgstr "Datum"
 
-#: .\maistar_ranking\templates\maistar_ranking\player_game_list.html:15
+#: templates/maistar_ranking/player_game_list.html:15
 msgid "Event"
 msgstr "Veranstaltung"
 
-#: .\maistar_ranking\templates\maistar_ranking\player_game_list.html:16
+#: templates/maistar_ranking/player_game_list.html:16
 msgid "Players"
 msgstr "Spieler"
 
-#: .\maistar_ranking\templates\maistar_ranking\ranking_list.html:4
+#: templates/maistar_ranking/ranking_list.html:4
 msgid "Mai-Star Ranking"
 msgstr "Mai-Star Platzierung"
 
-#: .\maistar_ranking\templates\maistar_ranking\ranking_list.html:10
-#: .\maistar_ranking\templates\maistar_ranking\ranking_list.html:18
+#: templates/maistar_ranking/ranking_list.html:10
+#: templates/maistar_ranking/ranking_list.html:18
 msgid "Placement"
 msgstr "Platzierung"
 
-#: .\maistar_ranking\templates\maistar_ranking\ranking_list.html:11
+#: templates/maistar_ranking/ranking_list.html:11
 msgid "Avatar"
 msgstr "Avatar"
 
-#: .\maistar_ranking\templates\maistar_ranking\ranking_list.html:12
+#: templates/maistar_ranking/ranking_list.html:12
 msgid "Nickname"
 msgstr "Spitzname"
 
-#: .\maistar_ranking\templates\maistar_ranking\ranking_list.html:13
+#: templates/maistar_ranking/ranking_list.html:13
 msgid "Name"
 msgstr "Name"
 
-#: .\maistar_ranking\templates\maistar_ranking\ranking_list.html:14
+#: templates/maistar_ranking/ranking_list.html:14
 msgid "Average"
 msgstr "Durchschnitt"
 
-#: .\maistar_ranking\templates\maistar_ranking\ranking_list.html:15
+#: templates/maistar_ranking/ranking_list.html:15
 msgid "Games"
 msgstr "Spiele"
 
-#: .\maistar_ranking\templates\maistar_ranking\ranking_list.html:20
+#: templates/maistar_ranking/ranking_list.html:20
 msgid "count"
 msgstr "Anzahl"
 
-#: .\maistar_ranking\templates\maistar_ranking\ranking_list.html:21
+#: templates/maistar_ranking/ranking_list.html:21
 msgid "good"
 msgstr "Gut"
 
-#: .\maistar_ranking\templates\maistar_ranking\ranking_list.html:22
+#: templates/maistar_ranking/ranking_list.html:22
 msgid "won"
 msgstr "Gewonnen"
 
-#: .\maistar_ranking\templates\maistar_ranking\ranking_list.html:43
+#: templates/maistar_ranking/ranking_list.html:43
 msgid ""
 "Unfortunately, nobody has it been done in the ranking.\n"
 "                A player must have 6 games done, to be added to the ranking."
@@ -229,15 +228,15 @@ msgstr ""
 "als 6 Spiele innerhalb einer Saison absolviert haben, werden für das "
 "Endergebnis nicht gewertet."
 
-#: .\maistar_ranking\templates\maistar_ranking\ranking_list.html:52
+#: templates/maistar_ranking/ranking_list.html:52
 msgid "Latest Games"
 msgstr "Letzten Spiele"
 
-#: .\maistar_ranking\templates\maistar_ranking\ranking_list.html:63
+#: templates/maistar_ranking/ranking_list.html:63
 msgid "Latest Events"
 msgstr "Letzten Veranstaltungen"
 
-#: .\maistar_ranking\templates\maistar_ranking\ranking_list.html:70
+#: templates/maistar_ranking/ranking_list.html:70
 msgid "Ladder Archive"
 msgstr "Archiv"
 

src/maistar_ranking/migrations/0001_initial.py

@@ -6,7 +6,6 @@ from django.conf import settings
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('events', '__first__'),
         migrations.swappable_dependency(settings.AUTH_USER_MODEL),
@@ -17,7 +16,8 @@ class Migration(migrations.Migration):
             name='Game',
             fields=[
                 ('id', models.AutoField(verbose_name='ID',
-                                        serialize=False, auto_created=True, primary_key=True)),
+                                        serialize=False, auto_created=True,
+                                        primary_key=True)),
                 ('comment', models.TextField(verbose_name='Anmerkung', blank=True)),
                 ('player1_score', models.SmallIntegerField(verbose_name='Punkte')),
                 ('player1_placement', models.PositiveSmallIntegerField(editable=False)),
@@ -32,31 +32,47 @@ class Migration(migrations.Migration):
                 ('player6_score', models.SmallIntegerField(verbose_name='Punkte')),
                 ('player6_placement', models.PositiveSmallIntegerField(editable=False)),
                 ('confirmed', models.BooleanField(
-                    default=True, help_text='das Spiel z\xe4hlt nur wenn es best\xe4tigt wurde', verbose_name='Wurde best\xe4tigt')),
+                    default=True,
+                    help_text='das Spiel z\xe4hlt nur wenn es best\xe4tigt wurde',
+                    verbose_name='Wurde best\xe4tigt')),
                 ('player_names', models.CharField(max_length=255, editable=False)),
                 ('season', models.PositiveSmallIntegerField(
                     verbose_name='Saison', editable=False, db_index=True)),
                 ('event', models.ForeignKey(
-                    related_name='maistargame_set', to='events.Event', on_delete=models.CASCADE)),
+                    related_name='maistargame_set', to='events.Event',
+                    on_delete=models.CASCADE)),
                 ('player1', models.ForeignKey(related_name='+',
-                                              verbose_name='Spieler 1', to=settings.AUTH_USER_MODEL, on_delete=models.CASCADE)),
+                                              verbose_name='Spieler 1',
+                                              to=settings.AUTH_USER_MODEL,
+                                              on_delete=models.CASCADE)),
                 ('player2', models.ForeignKey(related_name='+',
-                                              verbose_name='Spieler 2', to=settings.AUTH_USER_MODEL, on_delete=models.CASCADE)),
+                                              verbose_name='Spieler 2',
+                                              to=settings.AUTH_USER_MODEL,
+                                              on_delete=models.CASCADE)),
                 ('player3', models.ForeignKey(related_name='+',
-                                              verbose_name='Spieler 3', to=settings.AUTH_USER_MODEL, on_delete=models.CASCADE)),
+                                              verbose_name='Spieler 3',
+                                              to=settings.AUTH_USER_MODEL,
+                                              on_delete=models.CASCADE)),
                 ('player4', models.ForeignKey(related_name='+',
-                                              verbose_name='Spieler 4', to=settings.AUTH_USER_MODEL, on_delete=models.CASCADE)),
+                                              verbose_name='Spieler 4',
+                                              to=settings.AUTH_USER_MODEL,
+                                              on_delete=models.CASCADE)),
                 ('player5', models.ForeignKey(related_name='+',
-                                              verbose_name='Spieler 5', to=settings.AUTH_USER_MODEL, on_delete=models.CASCADE)),
+                                              verbose_name='Spieler 5',
+                                              to=settings.AUTH_USER_MODEL,
+                                              on_delete=models.CASCADE)),
                 ('player6', models.ForeignKey(related_name='+',
-                                              verbose_name='Spieler 6', to=settings.AUTH_USER_MODEL, on_delete=models.CASCADE)),
+                                              verbose_name='Spieler 6',
+                                              to=settings.AUTH_USER_MODEL,
+                                              on_delete=models.CASCADE)),
             ],
         ),
         migrations.CreateModel(
             name='Ranking',
             fields=[
                 ('id', models.AutoField(verbose_name='ID',
-                                        serialize=False, auto_created=True, primary_key=True)),
+                                        serialize=False, auto_created=True,
+                                        primary_key=True)),
                 ('season', models.PositiveSmallIntegerField(verbose_name='Saison')),
                 ('placement', models.PositiveIntegerField(null=True, blank=True)),
                 ('avg_placement', models.PositiveSmallIntegerField(
@@ -65,7 +81,8 @@ class Migration(migrations.Migration):
                 ('games_count', models.PositiveSmallIntegerField(default=0)),
                 ('games_good', models.PositiveSmallIntegerField(default=0)),
                 ('games_won', models.PositiveSmallIntegerField(default=0)),
-                ('user', models.ForeignKey(to=settings.AUTH_USER_MODEL, on_delete=models.CASCADE)),
+                ('user', models.ForeignKey(to=settings.AUTH_USER_MODEL,
+                                           on_delete=models.CASCADE)),
             ],
             options={
                 'ordering': ('-season', 'placement', 'avg_placement', '-avg_score'),

src/maistar_ranking/migrations/0007_auto_20171214_1215.py

@@ -8,7 +8,6 @@ import django.db.models.deletion
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ('maistar_ranking', '0006_auto_20171115_0653'),
     ]
@@ -17,36 +16,49 @@ class Migration(migrations.Migration):
         migrations.AlterField(
             model_name='game',
             name='player1',
-            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, related_name='+', to=settings.AUTH_USER_MODEL, verbose_name='Spieler 1'),
+            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT,
+                                    related_name='+', to=settings.AUTH_USER_MODEL,
+                                    verbose_name='Spieler 1'),
         ),
         migrations.AlterField(
             model_name='game',
             name='player2',
-            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, related_name='+', to=settings.AUTH_USER_MODEL, verbose_name='Spieler 2'),
+            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT,
+                                    related_name='+', to=settings.AUTH_USER_MODEL,
+                                    verbose_name='Spieler 2'),
         ),
         migrations.AlterField(
             model_name='game',
             name='player3',
-            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, related_name='+', to=settings.AUTH_USER_MODEL, verbose_name='Spieler 3'),
+            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT,
+                                    related_name='+', to=settings.AUTH_USER_MODEL,
+                                    verbose_name='Spieler 3'),
         ),
         migrations.AlterField(
             model_name='game',
             name='player4',
-            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, related_name='+', to=settings.AUTH_USER_MODEL, verbose_name='Spieler 4'),
+            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT,
+                                    related_name='+', to=settings.AUTH_USER_MODEL,
+                                    verbose_name='Spieler 4'),
         ),
         migrations.AlterField(
             model_name='game',
             name='player5',
-            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, related_name='+', to=settings.AUTH_USER_MODEL, verbose_name='Spieler 5'),
+            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT,
+                                    related_name='+', to=settings.AUTH_USER_MODEL,
+                                    verbose_name='Spieler 5'),
         ),
         migrations.AlterField(
             model_name='game',
             name='player6',
-            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, related_name='+', to=settings.AUTH_USER_MODEL, verbose_name='Spieler 6'),
+            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT,
+                                    related_name='+', to=settings.AUTH_USER_MODEL,
+                                    verbose_name='Spieler 6'),
         ),
         migrations.AlterField(
             model_name='ranking',
             name='user',
-            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, to=settings.AUTH_USER_MODEL),
+            field=models.ForeignKey(on_delete=django.db.models.deletion.PROTECT,
+                                    to=settings.AUTH_USER_MODEL),
         ),
     ]

src/maistar_ranking/models.py

@@ -6,7 +6,7 @@ from django.db import models
 from django.db.models.signals import post_delete, post_save
 from django.dispatch import receiver
 from django.urls import reverse
-from django.utils.translation import ugettext as _
+from django.utils.translation import gettext as _
 
 from events.models import Event
 from . import settings, managers
@@ -149,7 +149,8 @@ class Game(models.Model):
 
 class Ranking(models.Model):
     """the player scores in the ladder for one season. """
-    user = models.ForeignKey(settings.AUTH_USER_MODEL, on_delete=models.PROTECT)
+    user = models.ForeignKey(settings.AUTH_USER_MODEL,
+                             on_delete=models.PROTECT)
     season = models.PositiveSmallIntegerField(_("Season"))
     placement = models.PositiveIntegerField(blank=True, null=True)
     avg_placement = models.PositiveSmallIntegerField(blank=True, null=True)
@@ -210,7 +211,8 @@ def update_maistar_ranking(sender, **kwargs):
     """
     A Django signal hook to trigger a recalculation of the rankings as soon
     as a Mai-Star game has been added, deleted, or modified.
-    :param sender: The callback function which will be connected to this signal. See Receiver functions for more information.
+    :param sender: The callback function which will be connected to this signal.
+                   See Receiver functions for more information.
     :param kwargs: """
     instance = kwargs['instance']
     for player in instance.player_list: